[jira] [Created] (THRIFT-4595) Support for Message Bus Transport

2018-06-27 Thread James E. King III (JIRA)
James E. King III created THRIFT-4595: - Summary: Support for Message Bus Transport Key: THRIFT-4595 URL: https://issues.apache.org/jira/browse/THRIFT-4595 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-06-27 Thread Christopher Friedt (JIRA)
Linux 3.8, and they will likely require "make check" to pass successfully in future versions. Might as well ensure it works now. If you want to duplicate my build easily in Docker, you can use the attachment (e.g. tar xpvzf thrift-ci-build-20180627.tar.xz; cd thrift-20180627; docker

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
attachment (e.g. tar xpvzf thrift-ci-build-20180627.tar.xz; cd thrift-20180627; docker build -t foo .) {noformat} make check ... /bin/bash ../../../libtool --tag=CXX --mode=link x86_64-alpine-linux-musl-g++ -Wall -Wextra -pedantic -Os -fomit-frame-pointer -L/usr/lib -Wl,--no-un

[jira] [Updated] (THRIFT-4594) Unable to Build Test Suite in Alpine Linux

2018-06-27 Thread Christopher Friedt (JIRA)
Test Suite >Affects Versions: 0.11.0 > Environment: Ubuntu Bionic (native) > alpine:latest (docker) >Reporter: Christopher Friedt >Priority: Minor > Fix For: 0.12.0 > > Attachments: thrift-ci-build-20180627.t

[jira] [Commented] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread James E. King III (JIRA)
Issue Type: Bug > Components: Test Suite >Affects Versions: 0.11.0 > Environment: Ubuntu Bionic (native) > alpine:latest (docker) >Reporter: Christopher Friedt >Priority: Minor > Fix For: 0.12.0 > > Attachments

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
plicate my build easily in Docker, you can use the attachment (e.g. tar xpvzf thrift-ci-build-20180627.tar.xz; cd thrift-20180627; docker build -t foo .) {noformat} make check ... make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cpp/test' Running 54 test cases... An error me

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
plicate my build easily in Docker, you can use the attachment (e.g. tar xpvzf thrift-ci-build-20180627.tar.xz; cd thrift-20180627; docker build -t foo .) {noformat} make check ... make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cpp/test' Running 54 test cases... An error me

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
t-ci-build-20180627.tar.xz; cd thrift-20180627; docker build -t foo .) {noformat} make check ... make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cpp/test' Running 54 test cases... An error message from getaddrinfo on the console is expected: Thrift: Wed Jun 27 20:16:03 2018 g

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
t-ci-build-20180627.tar.xz; cd thrift-20180627; docker build -t foo .) {noformat} make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cpp/test' Running 54 test cases... An error message from getaddrinfo on the console is expected: Thrift: Wed Jun 27 20:16:03 2018 getaddrinf

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
, I'm working on automating builds of thrift for Alpine Linux 3.8, and they will likely require "make check" to pass successfully in future versions. Might as well ensure it works now.   {noformat} make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cpp/test' Runni

[jira] [Updated] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Friedt updated THRIFT-4594: --- Attachment: thrift-ci-build-20180627.tar.gz > Unit Tests fail

[jira] [Created] (THRIFT-4594) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
of thrift for Alpine Linux 3.8, and they will likely require "make check" to pass successfully in future versions. Might as well ensure it works now.   ``` make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cpp/test' Running 54 test cases... An error message from g

[jira] [Created] (THRIFT-4593) Unit Tests failing

2018-06-27 Thread Christopher Friedt (JIRA)
of thrift for Alpine Linux 3.8, and they will likely require "make check" to pass successfully in future versions. Might as well ensure it works now.   ``` make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cpp/test' Running 54 test cases... An error message from g

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525590#comment-16525590 ] ASF GitHub Bot commented on THRIFT-4496: Jens-G edited a comment on issue #1567: THRIFT-4496:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525588#comment-16525588 ] ASF GitHub Bot commented on THRIFT-4496: Jens-G edited a comment on issue #1567: THRIFT-4496:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525580#comment-16525580 ] ASF GitHub Bot commented on THRIFT-4496: Jens-G commented on issue #1567: THRIFT-4496: python

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525579#comment-16525579 ] ASF GitHub Bot commented on THRIFT-4496: Jens-G commented on a change in pull request #1567:

[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525478#comment-16525478 ] ASF GitHub Bot commented on THRIFT-4551: NameFILIP commented on issue #1548: THRIFT-4551: Run

[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525473#comment-16525473 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525472#comment-16525472 ] ASF GitHub Bot commented on THRIFT-4496: jeking3 commented on issue #1567: THRIFT-4496: python

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525465#comment-16525465 ] ASF GitHub Bot commented on THRIFT-4496: jeking3 commented on issue #1567: THRIFT-4496: python

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525447#comment-16525447 ] ASF GitHub Bot commented on THRIFT-4496: nsrtvwls edited a comment on issue #1567: THRIFT-4496:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525439#comment-16525439 ] ASF GitHub Bot commented on THRIFT-4496: nsrtvwls commented on issue #1567: THRIFT-4496: python

[jira] [Commented] (THRIFT-4592) JS: readI32 performance on large arrays is very poor in Chrome

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525346#comment-16525346 ] ASF GitHub Bot commented on THRIFT-4592: arittr opened a new pull request #1569: THRIFT-4592:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525336#comment-16525336 ] ASF GitHub Bot commented on THRIFT-4496: jeking3 commented on issue #1567: THRIFT-4496: python

[jira] [Commented] (THRIFT-3950) Memory leak while calling oneway method

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525231#comment-16525231 ] ASF GitHub Bot commented on THRIFT-3950: bforbis opened a new pull request #1568: THRIFT-3950:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525230#comment-16525230 ] ASF GitHub Bot commented on THRIFT-4496: nsrtvwls commented on issue #1567: THRIFT-4496: python

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525220#comment-16525220 ] ASF GitHub Bot commented on THRIFT-4496: nsrtvwls commented on a change in pull request #1567:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525219#comment-16525219 ] ASF GitHub Bot commented on THRIFT-4496: nsrtvwls commented on a change in pull request #1567:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525215#comment-16525215 ] ASF GitHub Bot commented on THRIFT-4496: nsrtvwls commented on issue #1567: THRIFT-4496: python

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525213#comment-16525213 ] ASF GitHub Bot commented on THRIFT-4496: nsrtvwls commented on a change in pull request #1567:

[jira] [Commented] (THRIFT-4520) Modernize JS/node

2018-06-27 Thread Brian Forbis (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525174#comment-16525174 ] Brian Forbis commented on THRIFT-4520: -- +1. Furthermore, rather than forever supporting  multiple

[jira] [Commented] (THRIFT-4551) Add prettier for consistent JS code formatting

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525087#comment-16525087 ] ASF GitHub Bot commented on THRIFT-4551: jeking3 commented on issue #1548: THRIFT-4551: Run

[jira] [Commented] (THRIFT-4586) Thrift generated strings for Cocoa/Objective-C should use copy not strong.

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525026#comment-16525026 ] ASF GitHub Bot commented on THRIFT-4586: jeking3 commented on issue #1564: THRIFT-4586:

Cocoa change code review

2018-06-27 Thread James E. King III
Folks who know Cocoa please review this change for correctness and backwards compatibility: https://github.com/apache/thrift/pull/1564 Thanks, Jim

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525021#comment-16525021 ] ASF GitHub Bot commented on THRIFT-4496: jeking3 edited a comment on issue #1567: THRIFT-4496:

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525010#comment-16525010 ] ASF GitHub Bot commented on THRIFT-4496: jeking3 commented on issue #1567: THRIFT-4496: python

[jira] [Resolved] (THRIFT-4225) Error handling malformed arguments leaks memory, corrupts transport buffers causing next RPC to fail

2018-06-27 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4225. --- Resolution: Fixed Committed - thanks! > Error handling malformed arguments leaks

[jira] [Commented] (THRIFT-4225) Error handling malformed arguments leaks memory, corrupts transport buffers causing next RPC to fail

2018-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525000#comment-16525000 ] ASF GitHub Bot commented on THRIFT-4225: jeking3 closed pull request #1565: THRIFT-4225: Delete