[jira] [Commented] (THRIFT-5520) Java Lib: add method to convert Option type to java Optional

2022-02-21 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495410#comment-17495410 ] Liu Jiayu commented on THRIFT-5520: --- PR is https://github.com/apache/thrift/pull/2524 > Java Lib: add

[jira] [Updated] (THRIFT-5520) Java Lib: add method to convert Option type to java Optional

2022-02-21 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5520: -- Description: This requires JDK8+ but I think it's reasonable. Because of that, it's a breaking

[jira] [Created] (THRIFT-5520) Java Lib: add method to conver Option type to java Optional

2022-02-21 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5520: - Summary: Java Lib: add method to conver Option type to java Optional Key: THRIFT-5520 URL: https://issues.apache.org/jira/browse/THRIFT-5520 Project: Thrift

[jira] [Updated] (THRIFT-5520) Java Lib: add method to conver Option type to java Optional

2022-02-21 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5520: -- Labels: Breaking-Change (was: ) > Java Lib: add method to conver Option type to java Optional >

[jira] [Updated] (THRIFT-5520) Java Lib: add method to convert Option type to java Optional

2022-02-21 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5520: -- Summary: Java Lib: add method to convert Option type to java Optional (was: Java Lib: add method to

[jira] [Updated] (THRIFT-5520) Java Lib: add method to convert Option type to java Optional

2022-02-21 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5520: -- Description: This requires JDK8+ but I think it's reasonable. Because of that, it's a breaking change

[jira] [Created] (THRIFT-5524) In Java lib, add param for option_type to generate JDK8 optional types but with postfix in parallel with original getter

2022-02-22 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5524: - Summary: In Java lib, add param for option_type to generate JDK8 optional types but with postfix in parallel with original getter Key: THRIFT-5524 URL:

[jira] [Commented] (THRIFT-5521) In Java lib, add param for option_type to generate JDK8 optional types

2022-02-22 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496080#comment-17496080 ] Liu Jiayu commented on THRIFT-5521: --- 5524 is based on 5521 > In Java lib, add param for option_type

[jira] [Updated] (THRIFT-5520) add method to convert Option type to java Optional

2022-02-22 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5520: -- Description: This requires JDK8+ but I think it's reasonable, because the current thrift lowest

[jira] [Updated] (THRIFT-5524) Add param for option_type to generate JDK8 optional types but with postfix in parallel with original getter

2022-02-22 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5524: -- Summary: Add param for option_type to generate JDK8 optional types but with postfix in parallel with

[jira] [Created] (THRIFT-5526) java gen to use private_members instead of private-members as a consistent param casing

2022-02-22 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5526: - Summary: java gen to use private_members instead of private-members as a consistent param casing Key: THRIFT-5526 URL: https://issues.apache.org/jira/browse/THRIFT-5526

[jira] [Created] (THRIFT-5525) java gen to use reuse_objects instead of reuse-objects as a consistent param casing

2022-02-22 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5525: - Summary: java gen to use reuse_objects instead of reuse-objects as a consistent param casing Key: THRIFT-5525 URL: https://issues.apache.org/jira/browse/THRIFT-5525

[jira] [Created] (THRIFT-5543) Java lib FieldMetaData should be more type-safe by adding type parameter to metadata registerations

2022-03-31 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5543: - Summary: Java lib FieldMetaData should be more type-safe by adding type parameter to metadata registerations Key: THRIFT-5543 URL: https://issues.apache.org/jira/browse/THRIFT-5543

[jira] [Created] (THRIFT-5544) add java code gen param to support including field annotation as metadata

2022-03-31 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5544: - Summary: add java code gen param to support including field annotation as metadata Key: THRIFT-5544 URL: https://issues.apache.org/jira/browse/THRIFT-5544 Project: Thrift

[jira] [Created] (THRIFT-5545) Follow newer gradle convention in organizing source code directories

2022-04-01 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5545: - Summary: Follow newer gradle convention in organizing source code directories Key: THRIFT-5545 URL: https://issues.apache.org/jira/browse/THRIFT-5545 Project: Thrift

[jira] [Created] (THRIFT-5555) Java codegen and library to support future-returning client interface and implementation

2022-04-12 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-: - Summary: Java codegen and library to support future-returning client interface and implementation Key: THRIFT- URL: https://issues.apache.org/jira/browse/THRIFT-

[jira] [Commented] (THRIFT-5548) Kotlin code generator

2022-04-12 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17521225#comment-17521225 ] Liu Jiayu commented on THRIFT-5548: --- [~jensg] FYI the pull request is ready now. > Kotlin code

[jira] [Created] (THRIFT-5549) Json generator should indent properly while generating includes

2022-04-06 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5549: - Summary: Json generator should indent properly while generating includes Key: THRIFT-5549 URL: https://issues.apache.org/jira/browse/THRIFT-5549 Project: Thrift

[jira] [Created] (THRIFT-5551) Add @Override annotation for generated Java code where possible

2022-04-11 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5551: - Summary: Add @Override annotation for generated Java code where possible Key: THRIFT-5551 URL: https://issues.apache.org/jira/browse/THRIFT-5551 Project: Thrift

[jira] [Created] (THRIFT-5552) Apply clang-format to java code gen file

2022-04-11 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5552: - Summary: Apply clang-format to java code gen file Key: THRIFT-5552 URL: https://issues.apache.org/jira/browse/THRIFT-5552 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5553) java library to use newer gradle API

2022-04-12 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5553: - Summary: java library to use newer gradle API Key: THRIFT-5553 URL: https://issues.apache.org/jira/browse/THRIFT-5553 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5556) allow json gen to generate ricker set of include information

2022-04-12 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5556: - Summary: allow json gen to generate ricker set of include information Key: THRIFT-5556 URL: https://issues.apache.org/jira/browse/THRIFT-5556 Project: Thrift

[jira] [Created] (THRIFT-5572) current travis build is broken (error timeout) within kerl erlang build step

2022-04-22 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5572: - Summary: current travis build is broken (error timeout) within kerl erlang build step Key: THRIFT-5572 URL: https://issues.apache.org/jira/browse/THRIFT-5572 Project:

[jira] [Assigned] (THRIFT-5570) update java lib document about gradle usage

2022-04-20 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5570: - Assignee: Liu Jiayu > update java lib document about gradle usage >

[jira] [Created] (THRIFT-5570) update java lib document about gradle usage

2022-04-20 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5570: - Summary: update java lib document about gradle usage Key: THRIFT-5570 URL: https://issues.apache.org/jira/browse/THRIFT-5570 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-5571) add metadata map building to kotlin generator

2022-04-20 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5571: - Summary: add metadata map building to kotlin generator Key: THRIFT-5571 URL: https://issues.apache.org/jira/browse/THRIFT-5571 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-5564) Propose to migrate to GitHub Actions and replace Travis and Appveyor

2022-04-18 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5564: - Summary: Propose to migrate to GitHub Actions and replace Travis and Appveyor Key: THRIFT-5564 URL: https://issues.apache.org/jira/browse/THRIFT-5564 Project: Thrift

[jira] [Created] (THRIFT-5565) upgrade travis ci base image to xenial

2022-04-19 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5565: - Summary: upgrade travis ci base image to xenial Key: THRIFT-5565 URL: https://issues.apache.org/jira/browse/THRIFT-5565 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5567) remove reference to common lisp namespace

2022-04-19 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5567: - Summary: remove reference to common lisp namespace Key: THRIFT-5567 URL: https://issues.apache.org/jira/browse/THRIFT-5567 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5568) Use spotless gradle plugin and google-java-format to enforce a consistent code format

2022-04-19 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5568: - Summary: Use spotless gradle plugin and google-java-format to enforce a consistent code format Key: THRIFT-5568 URL: https://issues.apache.org/jira/browse/THRIFT-5568

[jira] [Created] (THRIFT-5566) migrate java tutorial from ant to gradle

2022-04-19 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5566: - Summary: migrate java tutorial from ant to gradle Key: THRIFT-5566 URL: https://issues.apache.org/jira/browse/THRIFT-5566 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-5537) Drop support for end-of-life python versions (including python 2)

2022-04-24 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527126#comment-17527126 ] Liu Jiayu commented on THRIFT-5537: --- +1 for this > Drop support for end-of-life python versions

[jira] [Updated] (THRIFT-5573) In Java lib, TAsyncClient does not reset ___error after exception was raised

2022-04-24 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5573: -- Description: Currently when an exception is thrown, serialized and de-serialized into async client

[jira] [Created] (THRIFT-5573) In Java lib, TAsyncClient does not reset ___error after exception was raised

2022-04-24 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5573: - Summary: In Java lib, TAsyncClient does not reset ___error after exception was raised Key: THRIFT-5573 URL: https://issues.apache.org/jira/browse/THRIFT-5573 Project:

[jira] [Assigned] (THRIFT-5537) Drop support for end-of-life python versions (including python 2)

2022-04-25 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5537: - Assignee: Liu Jiayu > Drop support for end-of-life python versions (including python 2) >

[jira] [Resolved] (THRIFT-5551) Add @Override annotation for generated Java code where possible

2022-04-26 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu resolved THRIFT-5551. --- Resolution: Fixed > Add @Override annotation for generated Java code where possible >

[jira] [Assigned] (THRIFT-5572) current travis build is broken (error timeout) within kerl erlang build step

2022-04-25 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5572: - Assignee: Liu Jiayu > current travis build is broken (error timeout) within kerl erlang build

[jira] [Assigned] (THRIFT-5558) Move JS-only tests from /test to /lib/js

2022-04-25 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5558: - Assignee: Liu Jiayu > Move JS-only tests from /test to /lib/js >

[jira] [Comment Edited] (THRIFT-5548) Kotlin code generator

2022-04-06 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518532#comment-17518532 ] Liu Jiayu edited comment on THRIFT-5548 at 4/7/22 1:23 AM: --- [~jensg] thanks

[jira] [Commented] (THRIFT-5548) Kotlin code generator

2022-04-06 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518532#comment-17518532 ] Liu Jiayu commented on THRIFT-5548: --- [~jensg] thanks for the questions. So far the work (pull request)

[jira] [Created] (THRIFT-5584) Use gradle toolchain to specify build time Java version

2022-05-12 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5584: - Summary: Use gradle toolchain to specify build time Java version Key: THRIFT-5584 URL: https://issues.apache.org/jira/browse/THRIFT-5584 Project: Thrift Issue

[jira] [Assigned] (THRIFT-5600) Upgrade rust toolchain to 1.50

2022-06-25 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5600: - Assignee: Liu Jiayu > Upgrade rust toolchain to 1.50 > -- > >

[jira] [Created] (THRIFT-5600) Upgrade rust toolchain to 1.50

2022-06-25 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5600: - Summary: Upgrade rust toolchain to 1.50 Key: THRIFT-5600 URL: https://issues.apache.org/jira/browse/THRIFT-5600 Project: Thrift Issue Type: Improvement

[jira] [Assigned] (THRIFT-5523) update rust lib to edition 2021 and use 1.58.1 toolchain

2022-07-01 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5523: - Assignee: Liu Jiayu > update rust lib to edition 2021 and use 1.58.1 toolchain >

[jira] [Updated] (THRIFT-5523) update rust lib to edition 2021 and use 1.61 toolchain

2022-07-01 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5523: -- Summary: update rust lib to edition 2021 and use 1.61 toolchain (was: update rust lib to edition

[jira] [Updated] (THRIFT-5600) Upgrade rust toolchain to 1.61 and edition 2021

2022-07-01 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5600: -- Summary: Upgrade rust toolchain to 1.61 and edition 2021 (was: Upgrade rust toolchain to 1.50) >

[jira] [Closed] (THRIFT-5556) allow json gen to generate ricker set of include information

2022-07-01 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu closed THRIFT-5556. - Resolution: Won't Fix > allow json gen to generate ricker set of include information >

[jira] [Closed] (THRIFT-5523) update rust lib to edition 2021 and use 1.61 toolchain

2022-07-01 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu closed THRIFT-5523. - Resolution: Duplicate > update rust lib to edition 2021 and use 1.61 toolchain >

[jira] [Commented] (THRIFT-5587) Introduce guid as additional builtin type

2022-06-03 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545760#comment-17545760 ] Liu Jiayu commented on THRIFT-5587: --- Thanks for the proposal. I'd prefer to use uuid as it's the name

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547940#comment-17547940 ] Liu Jiayu commented on THRIFT-5587: --- I agree with that: * for binary use the 16 bytes and byte

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547941#comment-17547941 ] Liu Jiayu commented on THRIFT-5587: --- Taking a step back, I wonder if we can standardize on a paved

[jira] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587 ] Liu Jiayu deleted comment on THRIFT-5587: --- was (Author: jiayuliu): Taking a step back, I wonder if we can standardize on a paved path for adding newer standalone types in terms of

[jira] [Created] (THRIFT-5574) add ubuntu focal build in CI

2022-04-27 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5574: - Summary: add ubuntu focal build in CI Key: THRIFT-5574 URL: https://issues.apache.org/jira/browse/THRIFT-5574 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-5564) Migrate to GitHub Actions and replace Travis and Appveyor

2022-04-29 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530293#comment-17530293 ] Liu Jiayu commented on THRIFT-5564: --- I agree with you - we shall see if the promise can hold. [~jensg] 

[jira] [Created] (THRIFT-5560) Use JUnit 5 (Jupiter) for Java unit tests

2022-04-17 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5560: - Summary: Use JUnit 5 (Jupiter) for Java unit tests Key: THRIFT-5560 URL: https://issues.apache.org/jira/browse/THRIFT-5560 Project: Thrift Issue Type: Improvement

[jira] [Assigned] (THRIFT-5560) Use JUnit 5 (Jupiter) for Java unit tests

2022-04-17 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5560: - Assignee: Liu Jiayu > Use JUnit 5 (Jupiter) for Java unit tests >

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522044#comment-17522044 ] Liu Jiayu commented on THRIFT-5483: --- [~jt2594838]  I don't follow your example. HashMap is unordered,

[jira] [Updated] (THRIFT-5483) Support customized comparator in Java

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5483: -- Priority: Trivial (was: Major) > Support customized comparator in Java >

[jira] [Comment Edited] (THRIFT-5483) Support customized comparator in Java

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522058#comment-17522058 ] Liu Jiayu edited comment on THRIFT-5483 at 4/14/22 4:41 AM: OK in this case

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522041#comment-17522041 ] Liu Jiayu commented on THRIFT-5483: --- [~jt2594838] in my opinion this isn't something that should be

[jira] [Closed] (THRIFT-5524) Add param for option_type to generate JDK8 optional types but with postfix in parallel with original getter

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu closed THRIFT-5524. - Assignee: Liu Jiayu Resolution: Won't Fix after some discussion, won't go down this path. > Add

[jira] [Commented] (THRIFT-5014) Do Direct Comparison on Raw Values Instead of Objects

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522043#comment-17522043 ] Liu Jiayu commented on THRIFT-5014: --- i think this issue can be closed given the pull request is merged

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

2022-04-14 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522087#comment-17522087 ] Liu Jiayu commented on THRIFT-5483: --- I'm not the original author nor designer for these part of the

[jira] [Comment Edited] (THRIFT-5483) Support customized comparator in Java

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522058#comment-17522058 ] Liu Jiayu edited comment on THRIFT-5483 at 4/14/22 4:40 AM: OK in this case

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522058#comment-17522058 ] Liu Jiayu commented on THRIFT-5483: --- OK in this case your issue isn't related to comparator, but

[jira] [Assigned] (THRIFT-5485) @SuppressWarnings is placed above Javadoc

2022-04-13 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5485: - Assignee: Liu Jiayu > @SuppressWarnings is placed above Javadoc >

[jira] [Created] (THRIFT-5563) fix deprecation and enable xlint for java library

2022-04-17 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5563: - Summary: fix deprecation and enable xlint for java library Key: THRIFT-5563 URL: https://issues.apache.org/jira/browse/THRIFT-5563 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-5544) add java code gen param to support including field annotation as metadata

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5544: -- Description: Currently the code generator has a map of string to string field that denotes the

[jira] [Commented] (THRIFT-5533) Fix Java warnings: @param, @return and deprecation

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523588#comment-17523588 ] Liu Jiayu commented on THRIFT-5533: --- [~jensg] FYI this will be fixed in

[jira] [Assigned] (THRIFT-5544) add java code gen param to support including field annotation as metadata

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5544: - Assignee: Liu Jiayu > add java code gen param to support including field annotation as

[jira] [Created] (THRIFT-5561) enforce a consistent code style and import ordering for Java library

2022-04-17 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5561: - Summary: enforce a consistent code style and import ordering for Java library Key: THRIFT-5561 URL: https://issues.apache.org/jira/browse/THRIFT-5561 Project: Thrift

[jira] [Created] (THRIFT-5562) remove gradle wrapper jar file from source tree

2022-04-17 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5562: - Summary: remove gradle wrapper jar file from source tree Key: THRIFT-5562 URL: https://issues.apache.org/jira/browse/THRIFT-5562 Project: Thrift Issue Type:

[jira] [Assigned] (THRIFT-5557) Move Java-only tests from /test to /lib/java

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5557: - Assignee: Liu Jiayu > Move Java-only tests from /test to /lib/java >

[jira] [Assigned] (THRIFT-5563) fix deprecation and enable xlint for java library

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5563: - Assignee: Liu Jiayu > fix deprecation and enable xlint for java library >

[jira] [Assigned] (THRIFT-5561) enforce a consistent code style and import ordering for Java library

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5561: - Assignee: Liu Jiayu > enforce a consistent code style and import ordering for Java library >

[jira] [Updated] (THRIFT-5545) Follow newer gradle convention in organizing source code directories

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5545: -- Description: Currently the directory layout of `lib/java` is: {{❯ tree -L 2}} {{.}} {{├──

[jira] [Updated] (THRIFT-5545) Follow newer gradle convention in organizing source code directories

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5545: -- Description: Currently the directory layout of `lib/java` is: ❯ tree -L 2 . ├── CMakeLists.txt ├──

[jira] [Assigned] (THRIFT-5553) java library to use newer gradle API

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5553: - Assignee: Liu Jiayu > java library to use newer gradle API >

[jira] [Assigned] (THRIFT-5543) Java lib FieldMetaData should be more type-safe by adding type parameter to metadata registerations

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5543: - Assignee: Liu Jiayu > Java lib FieldMetaData should be more type-safe by adding type parameter

[jira] [Resolved] (THRIFT-5557) Move Java-only tests from /test to /lib/java

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu resolved THRIFT-5557. --- Resolution: Fixed fixed in

[jira] [Commented] (THRIFT-5557) Move Java-only tests from /test to /lib/java

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523750#comment-17523750 ] Liu Jiayu commented on THRIFT-5557: --- [~jensg] I think this is already fixed by

[jira] [Assigned] (THRIFT-5545) Follow newer gradle convention in organizing source code directories

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5545: - Assignee: Liu Jiayu > Follow newer gradle convention in organizing source code directories >

[jira] [Updated] (THRIFT-5545) Follow newer gradle convention in organizing source code directories

2022-04-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5545: -- Description: Currently the directory layout of `lib/java` is: {{❯ tree -L 2}} {{.}} {{├──

[jira] [Created] (THRIFT-5580) Enhance the kotlin cross test suite

2022-05-07 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5580: - Summary: Enhance the kotlin cross test suite Key: THRIFT-5580 URL: https://issues.apache.org/jira/browse/THRIFT-5580 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5581) Upgrade gradle version to 7.4+

2022-05-08 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5581: - Summary: Upgrade gradle version to 7.4+ Key: THRIFT-5581 URL: https://issues.apache.org/jira/browse/THRIFT-5581 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5582) Improve TProtocol.java

2022-05-09 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5582: - Summary: Improve TProtocol.java Key: THRIFT-5582 URL: https://issues.apache.org/jira/browse/THRIFT-5582 Project: Thrift Issue Type: Improvement

[jira] [Created] (THRIFT-5575) Create a GitHub workflow using CMake

2022-04-29 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5575: - Summary: Create a GitHub workflow using CMake Key: THRIFT-5575 URL: https://issues.apache.org/jira/browse/THRIFT-5575 Project: Thrift Issue Type: Improvement

[jira] [Assigned] (THRIFT-5575) Create a GitHub workflow using CMake

2022-04-29 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5575: - Assignee: Liu Jiayu > Create a GitHub workflow using CMake >

[jira] [Assigned] (THRIFT-5564) Migrate to GitHub Actions and replace Travis and Appveyor

2022-04-29 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5564: - Assignee: Liu Jiayu > Migrate to GitHub Actions and replace Travis and Appveyor >

[jira] [Created] (THRIFT-5644) Upgrade to Java 17 (latest LTS version) in build env

2022-09-28 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5644: - Summary: Upgrade to Java 17 (latest LTS version) in build env Key: THRIFT-5644 URL: https://issues.apache.org/jira/browse/THRIFT-5644 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-5644) Upgrade to Java 17 (latest LTS version) in build env

2022-09-28 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5644: -- Description: This will at the same time resolve the JDK bug that triggers TSL error in Java run. >

[jira] [Assigned] (THRIFT-5642) OCaml in docker build environment is broken

2022-09-27 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5642: - Assignee: Liu Jiayu > OCaml in docker build environment is broken >

[jira] [Created] (THRIFT-5642) OCaml in docker build environment is broken

2022-09-27 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5642: - Summary: OCaml in docker build environment is broken Key: THRIFT-5642 URL: https://issues.apache.org/jira/browse/THRIFT-5642 Project: Thrift Issue Type: Bug

[jira] [Updated] (THRIFT-5642) OCaml in docker build environment is broken

2022-09-27 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5642: -- Description: # we need to add --disable-sandboxing in ubuntu focal due to newer opam version #

[jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier

2022-10-25 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623816#comment-17623816 ] Liu Jiayu commented on THRIFT-4037: --- fwiw, i have been moving CI to GitHub Actions and while doing

[jira] [Resolved] (THRIFT-5574) add ubuntu focal build in CI

2022-09-19 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu resolved THRIFT-5574. --- Resolution: Fixed > add ubuntu focal build in CI > > >

[jira] [Assigned] (THRIFT-5631) Execution failed for task ':generateBeanJava'.

2022-09-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5631: - Assignee: Liu Jiayu > Execution failed for task ':generateBeanJava'. >

[jira] [Assigned] (THRIFT-5632) Fix java lib pmd main offending errors

2022-09-18 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5632: - Assignee: Liu Jiayu > Fix java lib pmd main offending errors >

[jira] [Assigned] (THRIFT-5574) add ubuntu focal build in CI

2022-09-19 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5574: - Assignee: Liu Jiayu > add ubuntu focal build in CI > > >

[jira] [Created] (THRIFT-5632) Fix java lib pmd main offending errors

2022-09-18 Thread Liu Jiayu (Jira)
Liu Jiayu created THRIFT-5632: - Summary: Fix java lib pmd main offending errors Key: THRIFT-5632 URL: https://issues.apache.org/jira/browse/THRIFT-5632 Project: Thrift Issue Type: Improvement

  1   2   >