Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
Excellent, I will merge this, and we'll get it into 0.11.0 - so yay! We
can consider the backwards-compatible construction adapter to be deprecated so
that it can be removed in the follow
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808549
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -221,3 +221,4 @@ ENV THRIFT_ROOT /thrift
RUN mkdir -p $THRIFT_ROOT/src
COPY Dockerfile
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148808038
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148793389
--- Diff: lib/go/test/tests/client_error_test.go ---
@@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1382#discussion_r148793005
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -217,6 +217,62 @@ RUN rm -rf /var/cache/apt/* && \
rm -rf /tmp/* && \
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790161
--- Diff: lib/cl/externals/bundle.lisp ---
@@ -0,0 +1,161 @@
+(cl:in-package #:cl-user)
--- End diff --
Missing license statement.
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790890
--- Diff:
lib/cl/externals/software/usocket-0.7.0.1/vendor/OpenTransportUDP.lisp ---
@@ -0,0 +1,146 @@
+;;;-*-Mode: LISP; Package: CCL -*-
--- End
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148791102
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790668
--- Diff: lib/cl/externals/software/bordeaux-threads-v0.8.5/.travis.yml ---
@@ -0,0 +1,44 @@
+language: lisp
--- End diff --
If you checked
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148791220
--- Diff: lib/cl/binary-protocol.lisp ---
@@ -0,0 +1,255 @@
+(in-package #:org.apache.thrift.implementation)
+
+ This file defines
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148790488
--- Diff: lib/cl/externals/software/alexandria-20170830-git/.boring ---
@@ -0,0 +1,13 @@
+# Boring file regexps:
--- End diff --
If you
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148789088
--- Diff: compiler/cpp/src/thrift/generate/t_cl_generator.cc ---
@@ -0,0 +1,544 @@
+// Copyright (c) 2008- Patrick Collison <patr...@collison
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1410
@jfarrell for some reason there is no recorded Travis CI build for this
pull request. When the author squashes and resubmits hopefully this will kick
off a proper build?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1410
Some initial thoughts, before I review all of the files individually:
1. Please squash.
2. Please add [THRIFT-82] at the beginning of the commit description and
the pull request
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1407
I wonder if this is why sleep 10 is needed between haxe tests and whether
that could be improved now? I'll apply the other ones and see. :)
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1407
@Jens-G I see only one of the three commits here committed in master?
---
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1406
THRIFT-4343: enable nodejs-8.x on ubuntu-artful image and update grunt-jsdoc
also fix a perl failure as we were using a deprecated language feature
in the cross test server for perl.
Client
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1405
THRIFT-4376: fix more high impact coverity defects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift coverity
Alternatively you
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1404
THRIFT-4376: fix a few high impact coverity defects:
1458947: memory leak in compiler
1458787: resource leak in c_glib led to discovery of assert() abuse
1459090: fix string.find result
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1403
THRIFT-2998, combined #378 with enabling nodejs in make cross
Yes, one little dlang warning fix slipped in there too. :)
You can merge this pull request into a Git repository by running
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/945
If that is the case and the change is no longer desired, we need to close
this out somehow.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1289
@nsuke it sounds like you would recommend that we do not accept this fix,
and have people do their own conversion before trying to add a string, to make
sure it is a byte string (UTF-8 encoded
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1289
Based on what I've read about py3 strings, and the fact that thrift strings
are designated to be encoded as UTF8, this change seems correct. I'm not so
sure about what happens on the other side
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1402
Makes sense, thanks for the info. Every little bit helps us all improve
what we do next.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1400
It only works when creating the PR :)
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1400
Please remember to put the Jira THRIFT ticket name into the title of every
pull request. It makes it easier to merge, as a notification is posted in the
jira with the pull command to use.
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1400#discussion_r147188692
--- Diff: lib/php/src/ext/thrift_protocol/config.m4 ---
@@ -25,6 +25,8 @@ PHP_ARG_ENABLE(thrift_protocol, whether to enable the
thrift_protocol extension
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
0.11.0 cycle hasn't started yet - you still have some time (I don't know
how much).
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185494
--- Diff: lib/csharp/src/Transport/TNamedPipeServerTransport.cs ---
@@ -239,40 +239,51 @@ public override void Write(byte[] buf, int off, int
len
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185064
--- Diff: lib/csharp/src/Transport/TNamedPipeClientTransport.cs ---
@@ -88,7 +89,18 @@ public override void Write(byte[] buf, int off, int len
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185326
--- Diff: lib/csharp/src/Transport/TNamedPipeClientTransport.cs ---
@@ -88,7 +89,18 @@ public override void Write(byte[] buf, int off, int len
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1402#discussion_r147185736
--- Diff: lib/csharp/src/Transport/TNamedPipeServerTransport.cs ---
@@ -239,40 +239,51 @@ public override void Write(byte[] buf, int off, int
len
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1400
What's the Jira ticket number this is associated with?
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1399#discussion_r147157619
--- Diff: lib/py/setup.py ---
@@ -22,7 +22,7 @@
import sys
try:
from setuptools import setup, Extension
-except:
+except
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/378
To properly test this fix I need to add http transport support to the
nodejs cross programs, so I'll do that as part of the effort.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1274
I pulled these changes into a sandbox and started the `ubuntu-xenial`
docker image, and then ran `build/docker/scripts/autotools.sh` which is what
Travis CI would do for one of the unit test jobs
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/378
@tstanev Thank you for putting in the time. The PR backlog on the project
is getting better - there were over 100 PRs at the beginning of the year and
we're down to 50, so every little bit helps
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1274
I'll pull the changes into my sandbox and run unit, cross, ubsan, and sca
jobs.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1274
Travis is experiencing an outage event w.r.t Docker Hub that started this
morning.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
Don't worry, I'm just doing my usual "push things forward" bit. :) I got
the backlog down to 52 open PRs, but that's still about 45 too many for my
taste.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1380
Any news?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1318
@dthaluru, @RandyAbernethy any updates?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1311
@davinchia we've cleared out the CI build issues, so if you could squash
your changes to one commit then rebase on master, then do a force push to
refresh this pull request, it'll kick off a new
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1289
Could you open a Jira ticker for this?
https://thrift.apache.org/docs/HowToContribute
Also could you rebase on master and refresh the PR so we get a clean build,
now that CI
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1274
This had some errors and needs more work - please move it forward.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
@allengeorge if you add framed transport in dart to the cross test, that
would test a lot... but it would not test error conditions such as this one.
Just a reminder, this needs to move forward.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1261
@djzort reminder we need a Jira THRIFT issue and squash and rebase on
master.
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1141#discussion_r146879631
--- Diff: lib/nodejs/lib/thrift/http_connection.js ---
@@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) {
var req = (self.https
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1093
@StachOverflow will you be moving this forward or should it be closed?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
What needs to happen next to move this forward?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1075
@SimenB if you are interested in resurrecting this let me know - rebase on
current master and push to CI will run all our tests.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1058
This change needs a Jira ticket; please see
https://thrift.apache.org/docs/HowToContribute. Also if you can rebase on
master and push that will kick a new CI build; CI needs to pass (or failures
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1056
This needs to be rebased on the current master and resubmitted; we need a
clean CI build before we can proceed.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1045
So I agree that changes like this need representation in the cross test.
It would be nice if folks could patch up any ill will and move this forward.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1038
This needs a Jira item opened for it, and needs to be rebased and merge
conflicts fixed.
See; https://thrift.apache.org/docs/HowToContribute
Thanks.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1003
@gonthe can you rebase on master?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1002
This hasn't been touched in over a year - what needs to be done?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/982
Does this need further work or should it be closed?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/979
Folks who originally commented on this, please follow up.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/972
This needs to be rebased on the current master, conflicts resolved, and
pushed to kick a new build.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/945
Reminder, this needs to move forward.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/904
@nsuke This should be rebased against master since there are conflicts, and
resubmitted; also see THRIFT-1805 as there is some discussion on what is okay
and what is not in this context.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/884
@nsuke a reminder to rebase and submit, and I would limit it to just the
lib/d/src/thrift/transport/file.d file.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/842
@nsuke a reminder to rebase and resubmit
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/839
@nsuke a reminder to rebase and resubmit
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/838
@nsuke a reminder to rebase and resubmit
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/831
I have an open backlog item to use Set::Scalar for perl sets.
https://issues.apache.org/jira/browse/THRIFT-3190
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/831#discussion_r146873988
--- Diff: test/perl/TestClient.pl ---
@@ -250,16 +250,16 @@ sub usage {
#
# SET TEST
#
-my $setout = [];
+my $setout
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/820
Want to rebase on master and see if CI passes?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/798
We need to decide if we move forward with this or not. I'm in favor of
const correctness here however it is one of those things you need to do from
the beginning because it changes the ABI. We
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/782
This would be useful in the static code analysis build to generate all
language files. Any chance you can rebase this, or if no longer wanted, close
this PR and the Jira ticket that drove it?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/744
@lihanharry would it be possible for you to rebase this on the current
upstream master and resubmit it?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/662
Can we move this PR forward or close it?
---
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1399
THRIFT-4370: build generated code before running static code analysisâ¦
⦠- fix E722 flake8 issues identified in python code
You can merge this pull request into a Git repository by running
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1398
We don't re-release previous versions. You will need to apply the patch to
your own copy of a previous version.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
As far as I know builds in CI are stable. Rebase against master.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1391
I posted a message on the developer mailing list about removing php5
support. We'll see what comes of it. php5 is currently still shipping so I
have some reservations about removing support
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1392
I opened THRIFT-4367 for this.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1396
Manually inspecting the result in a sandbox.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1395
@jfarrell please close this, it was merged in commit
44701e82ad351d7472101ad81aa13e775ffb7384
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1391
I already discussed the possibility of retiring the trusty build
environment to reduce project maintenance. Maybw now is the time to do it.
That said, I would really like to get input from
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1391
Hmm, I'm just curious about this - given support for php5 was dropped, any
idea why the ubuntu-trusty "make check" job succeeded (because it has PHP 5.5.9
in it)? Is the build job no
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1397
change DOCKER_ env vars for travis integration to work better and enable
hub images for official PR builds
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1391#discussion_r146107107
--- Diff: lib/php/src/ext/thrift_protocol/config.m4 ---
@@ -1,25 +1,27 @@
-dnl Copyright (C) 2009 Facebook
-dnl Copying and distribution
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1391
@jfarrell I see licensing changes in this pull request, can you review?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1391
I saw cross test pass before, so I think we're good.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1391
UBsan build failed due to https://issues.apache.org/jira/browse/THRIFT-2913.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1391
Is this for THRIFT-4353? Can you squash it? Rebase it on master to fix
the CI issues.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1392
Please see: https://thrift.apache.org/docs/HowToContribute
This does not have an associated [Thrift
Jira](https://issues.apache.org/jira/projects/THRIFT) issue and is not properly
named
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
Seems like it still has some issues in the cross test with c_glib.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
Given the backlog on the project, I don't blame you! :)
---
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1389
THRIFT-4351: use travis build stages to optimize build (and more)
avoiding duplicate rebuilds of the same image, and also
allow personal docker hub repositories for private fork
builds
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/1387
---
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1387
THRIFT-4351: use travis build stages to optimize build,
avoiding duplicate rebuilds of the same image
THRIFT-4345: solidify docker build strategy for maximum
coverage: trusty, xenial
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1382
We support go back to version 1.2.1 or 1.4.3 (I can't remember which, but I
think 1.2.1 is on trusty). That said, I'm in the middle of reworking the
docker images to be as stock as possible
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1363
@MartinHaimberger If you could do me a favor and rebase on the current
master, I finally got all the CI build issues resolved so I'd like to see a
clean build before I merge. There are some minor
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1380
It looks like you may not have static link libraries for libevent, and
openssl on your system? It also looks like automake didn't figure it out
properly.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1380
On the Travis build - the Ubuntu Trusty image is using D 2.070.0 (see:
https://github.com/apache/thrift/tree/master/build/docker).
Currently we don't really have an official record
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1379
Looks like we need "publish" support or something for that last build job.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1380
To address the last sentence in your comment above: We're standardizing on
cmake and moving everything towards that, albeit slowly. Could you tell me if
this makes older D versions unusable
301 - 400 of 1222 matches
Mail list logo
