Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/904
This should be rebased against upstream/master since there are conflicts,
and resubmitted; also see THRIFT-1805 as there is some discussion on what is
okay and what is not in this context
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/858
Resubmitted in #1243.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1243
THRIFT-3627 fix missing basic code style consistency of JavaScript.
The original PR #858 is over a year old; there are no merge conflicts, but
I want to make sure it still passes all the CI builds
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/842
The merge conflicts need to be resolved and PR re-submitted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/838
The merge conflicts need to be resolved and PR re-submitted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/839
The merge conflicts need to be resolved and PR re-submitted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/794
@jfarrell THRIFT-3904 and other, earlier commits already did the same
thing, so this PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1242
THRIFT-3539: resubmitting PR #784 to get the fix qualified and merged
There was a comment in the Jira ticket this didn't work. Let's see what a
fresh build says. The author's original fork
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/744
@lihanharry would it be possible for you to rebase this on the current
upstream master and resubmit it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/744
THRIFT-4171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/701
@jfarrell this can be closed - it was merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/669
Resubmitted as #1241 - will shepherd it through the rest of the process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1241
THRIFT-4170: re-submitting PR #669 to fix lua backwards compatibility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/669
I opened THRIFT-4170 for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/657
@jfarrell this can be closed, as it was merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/624
I like this notion, the enums make it more readable. If you would be
willing to revive it and reapply it against the current master, we can take
another look at it. Also a Jira ticket
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/555
@jfarrell recommend closing this PR. It was abandoned; no Jira ticket;
author's fork has been destroyed.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/516
@jfarrell recommend closing this PR. It never got a thrift ticket, and has
an external dependency to a library that has been discontinued:
```
UPDATE: this project will be deprecated
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/480
@jfarrell this PR can be closed. It never got a Jira ticket and from the
comments above didn't work properly, and hasn't been updated.
---
If your project is set up for it, you can reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/387
@jfarrell this issue is resolved and closed in Jira. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1064
@jfarrell this can be closed, as it was merged into 0.10.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1227
Going to merge what? There's no need to merge branches into master. The
only unique changes in the branches is the version numbering.
---
If your project is set up for it, you can reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1240
This is related to THRIFT-3607.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1238
The build failure is due to a docker image rebuild because of a submit that
was not against master from yesterday/today.
---
If your project is set up for it, you can reply to this email and have
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1238
Although all builds passed, the plug-in builds were not enabled properly
for autoconf and a plug-in build with cmake was missing. Pushing a fix.
---
If your project is set up for it, you can
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1237
Appveyor died due to an environmental error getting "ant" with chocolatey.
I have to do an empty commit and kick another one, but I'm going to wait until
THRIFT-4071 so it isn't as
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1239
We'll re-use THRIFT-4160 for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/560
@jfarrell this can be closed. It was merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1239
Please open an Apache Jira ticket for each pull request.
https://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/639
@jfarrell you probably meant to close this, but it was already closed, and
got reopened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1238
THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI
Removed build jobs 2 and 4 as they were duplicates of 1 and 3 but on debian
instead of ubuntu, this adds too little value
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1227
Okay, but this pull request is still invalid. We don't want to merge 0.9.3
into master. Did you mean to open an Apache Jira question ticket instead of a
pull request?
---
If your project is set
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1236
THRIFT-4165: better cmake support for C++ language level, fixed compiler
warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/1235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/1228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1235
THRIFT-4164: update openssl cleanup to match current requirements
Ran ctest -T MemCheck which runs all tests through valgrind and all passed.
Manually inspected the TInterruptTest which includes
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1217
THRIFT-4162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1216
THRIFT-4161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
THRIFT-4160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1031
Okay, well I'm going to approve and merge, and open a Jira item to add
crosstest support for cocoa (if not there, I'll check) and for unix sockets in
cocoa.
---
If your project is set up
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1227
@jfarrell I think this can be closed; if folks need to ask a question you
can do it on the developer's mailing list or open an Apache Jira ticket against
the thrift project as a question
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/194
@jfarrell this is marked closed/fixed in Jira. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/226
@jfarrell this can be closed; the Jira ticket is resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/278
@jfarrell this can be closed. It was resolved incomplete/later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/328
@jfarrell this was resolved as a duplicate. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/354
@jfarrell this was closed fixed a while back. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/356
@jfarrell this was closed incomplete a while back. The PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/386
@jfarrell this was resolved invalid - please close PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/432
@jfarrell this can be closed - it was fixed a while back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/475
@jfarrell this can be closed - it was fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/500
@jfarrell this is closed/fixed in Jira. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/529
@jfarrell Recommend we close this as won't fix. It never passed and the
original author's github repository isn't around any more.
---
If your project is set up for it, you can reply to this email
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/501
@jfarrell this is closed fixed in Jira. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/577
@jfarrell this is marked closed fixed in Jira. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/639
@jfarrell this was done in another set of PRs so this can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/651
@jfarrell this was marked Won't Fix in Jira. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/688
@jfarrell this issue has been closed/fixed and the pull request can be
closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/733
@jfarrell this is marked Closed/Fixed in jira; this pull request can be
closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/991
@jfarrell I checked the current haskell build file and we've already
modified it to work the dependencies. This item doesn't have a Jira ticket I
can comment on, so this can be closed
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/995
@jfarrell please close this pull request as it was rejected last year.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1233
I logged the build failure as THRIFT-4155 as it appears to be an
intermittent test failure. I've seen it twice this week.
---
If your project is set up for it, you can reply to this email
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1011
Superceded by #1233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1233
THRIFT-4154: properly close socket whether it is persistent or not on
close()
Replaces PR #1011. Resubmitting to get a CI build that passes.
You can merge this pull request into a Git repository
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1011
I opened THRIFT-4154 and I am going to submit a second PR for this. If it
passes CI builds I can merge it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1082
@jfarrell the Jira ticket was resolved as "Won't Fix" here; can you close
this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/896
I think this should be closed and resubmitted, the history got messed up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1228
For anybody interested in reviewing this pull request, I pretty much
followed the logic that boost::mutex is using with one exception. In cases
where boost ignores an error condition to avoid
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1029
@jfarrell or @hush-hush could you please close this? There were two pull
requests for this Jira ticket and I only put one of them into the "This closes"
part of the comment.
---
If yo
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1031
Have you used this in a project and know that it works? Given this is an
improvement I'd like to get it in, but if you don't have time right now to add
make cross support, I can add a story
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1232
I'm curious - did every case where lexical_cast was used report this error
running in ubsan or was it perhaps just one of them? The original boost defect
says, "Undefined behaviour in lexical
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1231
THRIFT-4140: fix unsafe call to gmtime
I took the patch from the Jira entry and made it work on both unix and
windows.
You can merge this pull request into a Git repository by running:
$ git
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1031
Hi @clindsay just checking in to see if you had made any progress on adding
cross test support for cocoa. If not that's okay... it would be really nice
to have it though.
---
If your project
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1218
Please rebase against upstream/master and force push to kick a new build.
I'd like to see CI pass (or get much closer) before merging.
---
If your project is set up for it, you can reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1217
Please rebase against upstream/master and force push to kick a new build.
I'd like to see CI pass (or get much closer) before merging.
---
If your project is set up for it, you can reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1216
Please rebase against upstream/master and force push to kick a new build.
I'd like to see CI pass (or get much closer) before merging.
---
If your project is set up for it, you can reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
Please rebase this branch against upstream/master and force push to kick
off a new build. I would like to see the CI build pass (or get much closer
than it is now) before merging.
---
If your
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1229
THRIFT-4151: disable pthread concurrency analysis code in standard builds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1228
THRIFT-3978: tighten up pthread mutex implementation, removing asserts and
replacing them with exceptions
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1215
When this does merge into master, it's probably worth updating the
README.md indicating this is a breaking change (for the better). I would like
to take a look at how some of the other runtime
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1225
Job #5 of Build #3520 failed with something interesting and relevant:
```
PHP 5.5.9-1ubuntu4.21 Development Server started at Mon Mar 27 13:56:33 2017
Listening on http://127.0.0.1:9090
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1215#discussion_r108155957
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -728,6 +728,42 @@ inline bool ttypes_are_compatible(int8_t t1, int8_t
t2
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1215
I'll open a story in Jira for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1225
THRIFT-4141: fix haxe installation in docker build for debian, ubuntu
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1220#discussion_r108151340
--- Diff: build/docker/debian/Dockerfile ---
@@ -157,7 +157,7 @@ ENV PATH /usr/local/go/bin:$PATH
# Haxe
RUN mkdir -p /usr/lib/haxe
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1220#discussion_r108147597
--- Diff: build/docker/debian/Dockerfile ---
@@ -157,7 +157,7 @@ ENV PATH /usr/local/go/bin:$PATH
# Haxe
RUN mkdir -p /usr/lib/haxe
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1220#discussion_r108147499
--- Diff: build/docker/centos/Dockerfile ---
@@ -74,10 +74,8 @@ RUN yum install -y \
perl-Bit-Vector \
perl-Class-Accessor
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
If you have the fixes let's get them all in together. The current fix is
not complete and causes counting errors, which lead to - I don't know...
---
If your project is set up for it, you can
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
None that I know of. What you can do is:
1. Make sure language support is in the Dockerfile for the ubuntu and
debian builds.
2. Look for CROSS_LANGS in the top level Makefile.am
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1220
THRIFT-4069: perl library cleanup - namespaces, versioning, exception fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1215
Yes, I recommend you:
1. Squash your commits (optional, but we'll do it anyway when we merge into
apache master)
2. Rebase against upstream master.
3. Force push
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1084
Are these changes integrated into the "make cross" cross-language
validation suite?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
@xiaosuo just a reminder, if you have additional fixes (it sounds like you
do)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1212
Would you be able to open an Apache Jira ticket against the THRIFT project
for this issue? Please see:
https://thrift.apache.org/docs/HowToContribute
Thanks for helping us improve
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1210
I opened THRIFT-4129 for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1219
THRIFT-4079: emit use clauses in Types.pm generated files as well (fix
reopened defect)
The original fix only took care of the generated file for the service, if
the service has a method
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106959992
--- Diff: compiler/cpp/src/thrift/parse/t_field.h ---
@@ -68,7 +68,7 @@ class t_field : public t_doc {
int32_t get_key() const { return key_
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106794619
--- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c
---
@@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106793777
--- Diff: compiler/cpp/src/thrift/parse/t_field.h ---
@@ -68,7 +68,7 @@ class t_field : public t_doc {
int32_t get_key() const { return key_
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106793785
--- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c
---
@@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
This patch as-is causes a counting error, so if you can amend this one with
those changes we can get them all fixed together.
---
If your project is set up for it, you can reply to this email
601 - 700 of 1222 matches
Mail list logo
