[GitHub] thrift pull request: THRIFT-3060: NodeJS Client - Fix connection r...

2015-12-03 Thread cjthompson
Github user cjthompson commented on the pull request: https://github.com/apache/thrift/pull/395#issuecomment-161700301 Is there any reason to not include this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift pull request: Fix generated Node JS code

2015-11-30 Thread cjthompson
Github user cjthompson commented on the pull request: https://github.com/apache/thrift/pull/707#issuecomment-160679046 I'm not a C developer, but at first glance it looks like it might work. Let's see if anyone from the apache foundation agrees to merge it. --- If your project

[GitHub] thrift pull request: Fix generated Node JS code

2015-11-20 Thread cjthompson
Github user cjthompson commented on the pull request: https://github.com/apache/thrift/pull/707#issuecomment-158525127 Looking at this change, I believe this will break namespacing because the output will be invalid JavaScript: javascript var Namespace.Object.Type

[GitHub] thrift pull request: NodeJS Client: Fix connection retry logic

2015-03-30 Thread cjthompson
Github user cjthompson commented on the pull request: https://github.com/apache/thrift/pull/395#issuecomment-87740047 I submitted a patch to issue THRIFT-3060. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your