[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

2017-01-20 Thread lifei
Github user lifei commented on the issue: https://github.com/apache/thrift/pull/1086 @jeking3 modified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

2017-01-19 Thread lifei
Github user lifei commented on the issue: https://github.com/apache/thrift/pull/1086 > I think that putting the statusCode into the text description would be useful here added --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code

2016-10-20 Thread lifei
Github user lifei commented on the issue: https://github.com/apache/thrift/pull/1086 https://issues.apache.org/jira/browse/THRIFT-3926 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request #1087: THRIFT-3927 Emitting an error instead of throwing...

2016-09-14 Thread lifei
GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1087 THRIFT-3927 Emitting an error instead of throwing in the async callback Because the data event of a connection is async handled, throw an exception can not tell the code the error. emit the error

[GitHub] thrift pull request #1086: THRIFT-3926 Emit an error for bad http status cod...

2016-09-14 Thread lifei
GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1086 THRIFT-3926 Emit an error for bad http status code Sometimes the thrift servers is not ready to serve requests from the client. The status code of response from the services is 40x or 50x

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

2015-10-09 Thread lifei
Github user lifei closed the pull request at: https://github.com/apache/thrift/pull/545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

2015-10-09 Thread lifei
Github user lifei commented on the pull request: https://github.com/apache/thrift/pull/545#issuecomment-146838596 https://github.com/apache/thrift/commit/01a77ab01e7459d96059a2b49d9885d14a360ef1 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

2015-07-09 Thread lifei
Github user lifei commented on the pull request: https://github.com/apache/thrift/pull/545#issuecomment-120211338 https://issues.apache.org/jira/browse/THRIFT-3230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

2015-07-08 Thread lifei
GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/545 THRIFT-3230: transform typedef when getting type name Python compiler generates wrong code if there is function throwing a typedef of exception with another namespace. We should use the real type