[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510799#comment-14510799
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511098#comment-14511098
]
Ben Craig commented on THRIFT-2441:
---
committed. Thanks jeking3!
Cannot shutdown
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511148#comment-14511148
]
Hudson commented on THRIFT-2441:
SUCCESS: Integrated in Thrift #1517 (See
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506429#comment-14506429
]
James E. King, III commented on THRIFT-2441:
With the work done in
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500841#comment-14500841
]
James E. King, III commented on THRIFT-2441:
I have the thrift compiler built
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501092#comment-14501092
]
James E. King, III commented on THRIFT-2441:
I got a little further using the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492919#comment-14492919
]
ASF GitHub Bot commented on THRIFT-2441:
Github user bufferoverflow commented on
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492894#comment-14492894
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491418#comment-14491418
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491422#comment-14491422
]
ASF GitHub Bot commented on THRIFT-2441:
GitHub user jeking3 reopened a pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491435#comment-14491435
]
ASF GitHub Bot commented on THRIFT-2441:
GitHub user jeking3 reopened a pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491475#comment-14491475
]
James E. King, III commented on THRIFT-2441:
Okay, THRIFT-2441 is ready to
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491416#comment-14491416
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491486#comment-14491486
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491419#comment-14491419
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 closed the pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491412#comment-14491412
]
ASF GitHub Bot commented on THRIFT-2441:
GitHub user jeking3 reopened a pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491411#comment-14491411
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491417#comment-14491417
]
ASF GitHub Bot commented on THRIFT-2441:
GitHub user jeking3 reopened a pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491415#comment-14491415
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 closed the pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491423#comment-14491423
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491424#comment-14491424
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 closed the pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491536#comment-14491536
]
ASF GitHub Bot commented on THRIFT-2441:
Github user bufferoverflow commented on
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491324#comment-14491324
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490578#comment-14490578
]
ASF GitHub Bot commented on THRIFT-2441:
Github user ben-craig commented on a
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490579#comment-14490579
]
Ben Craig commented on THRIFT-2441:
---
+1
Cannot shutdown TThreadedServer when clients
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487648#comment-14487648
]
Ben Craig commented on THRIFT-2441:
---
oh, sorry about that. I wasn't sure if this had
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487599#comment-14487599
]
James E. King, III commented on THRIFT-2441:
What's the next step I need to
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487663#comment-14487663
]
James E. King, III commented on THRIFT-2441:
Note that although peek had to
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481296#comment-14481296
]
ASF GitHub Bot commented on THRIFT-2441:
GitHub user jeking3 opened a pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481322#comment-14481322
]
James E. King, III commented on THRIFT-2441:
Please ignore item 428, it is
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395897#comment-14395897
]
ASF GitHub Bot commented on THRIFT-2441:
GitHub user jeking3 opened a pull
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394389#comment-14394389
]
Ben Craig commented on THRIFT-2441:
---
I approve of the direction of this patch.
I
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394525#comment-14394525
]
James E. King, III commented on THRIFT-2441:
I opened THRIFT-3081 to track
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394837#comment-14394837
]
Ben Craig commented on THRIFT-2441:
---
I don't know why the peek is there. In the server
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394851#comment-14394851
]
James E. King, III commented on THRIFT-2441:
I rewrote peek to use
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394778#comment-14394778
]
James E. King, III commented on THRIFT-2441:
In each of the three threaded
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395519#comment-14395519
]
James E. King, III commented on THRIFT-2441:
I'm separating the test so that
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393314#comment-14393314
]
James E. King, III commented on THRIFT-2441:
interrupt() means the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393216#comment-14393216
]
James E. King, III commented on THRIFT-2441:
I was able to eliminate the need
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392880#comment-14392880
]
Ben Craig commented on THRIFT-2441:
---
I think we're converging on a great answer.
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392929#comment-14392929
]
James E. King, III commented on THRIFT-2441:
The only gotcha I see in this is
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390576#comment-14390576
]
James E. King, III commented on THRIFT-2441:
[~roger.meier] the patch that
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390581#comment-14390581
]
James E. King, III commented on THRIFT-2441:
Let's discuss a potential
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391544#comment-14391544
]
James E. King, III commented on THRIFT-2441:
That seems reasonable, however
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391596#comment-14391596
]
Randy Abernethy commented on THRIFT-2441:
-
+1 for any patches involving
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391440#comment-14391440
]
Ben Craig commented on THRIFT-2441:
---
Did not provide a way to maintain the current
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388456#comment-14388456
]
James E. King, III commented on THRIFT-2441:
Looking over TServerSocket.cpp I
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388768#comment-14388768
]
Ben Craig commented on THRIFT-2441:
---
I agree that the issue is a real one, and should
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388513#comment-14388513
]
Ben Craig commented on THRIFT-2441:
---
TServerSocket's pattern is basically what I had in
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389405#comment-14389405
]
James E. King, III commented on THRIFT-2441:
Reviewing the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14389585#comment-14389585
]
Randy Abernethy commented on THRIFT-2441:
-
The interrupt() method allows the
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386277#comment-14386277
]
Randy Abernethy commented on THRIFT-2441:
-
Hey Ben,
I agree with your rational,
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386646#comment-14386646
]
James E. King, III commented on THRIFT-2441:
I believe this change is an
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386681#comment-14386681
]
Ben Craig commented on THRIFT-2441:
---
however this patch applies after the listening
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386696#comment-14386696
]
Ben Craig commented on THRIFT-2441:
---
When there is a network disconnect, the socket
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386751#comment-14386751
]
James E. King, III commented on THRIFT-2441:
The code in TSocket and
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386763#comment-14386763
]
Ben Craig commented on THRIFT-2441:
---
I am leery in general of closing a transport in
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386836#comment-14386836
]
James E. King, III commented on THRIFT-2441:
I understand now, and your
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386953#comment-14386953
]
Randy Abernethy commented on THRIFT-2441:
-
Indeed, good example.
Cannot
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386093#comment-14386093
]
Ben Craig commented on THRIFT-2441:
---
-1 for this specific fix. Closing a socket that
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385896#comment-14385896
]
Hudson commented on THRIFT-2441:
SUCCESS: Integrated in Thrift #1486 (See
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382706#comment-14382706
]
James E. King, III commented on THRIFT-2441:
I can verify the fix posted on
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959749#comment-13959749
]
Chris Stylianou commented on THRIFT-2441:
-
This looks like a possible solution:
63 matches
Mail list logo