Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r175284941
--- Diff: build/appveyor/MSVC-appveyor-build.bat ---
@@ -39,7 +39,7 @@ CD "%BUILDDIR%" || EXIT /B
-DWITH_PYTHON=%WITH_PY
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r175284886
--- Diff: compiler/cpp/src/thrift/generate/t_generator.h ---
@@ -268,6 +271,30 @@ class t_generator {
return out.str();
}
+ const
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r175276394
--- Diff: build/appveyor/MSVC-appveyor-build.bat ---
@@ -39,7 +39,7 @@ CD "%BUILDDIR%" || EXIT /B
-DWITH_PYTHON=%WITH_PY
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r175276410
--- Diff: compiler/cpp/src/thrift/generate/t_generator.h ---
@@ -268,6 +271,30 @@ class t_generator {
return out.str();
}
+ const
GitHub user ozymaxx reopened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python a
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174771623
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests on dou
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174687128
--- Diff: test/py/RunClientServer.py ---
@@ -298,7 +300,11 @@ def main():
print('')
for genpydir in generated_dirs:
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174687088
--- Diff: test/py/CMakeLists.txt ---
@@ -27,7 +27,7 @@ add_test(NAME python_test_generate
)
add_test(NAME python_test
-COMMAND ${PYTH
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174686538
--- Diff: lib/java/gradle/unitTests.gradle ---
@@ -68,6 +68,20 @@ test {
include '**/Test*.class'
exclude '**/Test*\$*.class'
+
Github user ozymaxx commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174686397
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests on dou
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174495089
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests on dou
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174494320
--- Diff: lib/java/gradle/unitTests.gradle ---
@@ -68,6 +68,20 @@ test {
include '**/Test*.class'
exclude '**/Test*\$*.class'
+
GitHub user ozymaxx reopened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python a
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
GitHub user ozymaxx reopened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python a
Github user ozymaxx closed the pull request at:
https://github.com/apache/thrift/pull/1496
---
GitHub user ozymaxx opened a pull request:
https://github.com/apache/thrift/pull/1496
THRIFT-4476: Typecasting problem on list items (+ low precision double
rendering, + mis-rendering non-fractional double literals in Python)
- high precision double rendering in JS, Java, Python and
19 matches
Mail list logo
