[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729665#comment-16729665 ] James E. King III commented on THRIFT-4633: --- This did not make it into 0.12.0. It looks like there were comments on the PR requesting more changes. > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: Jens Geyer >Priority: Minor > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617339#comment-16617339 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G edited a comment on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421958796 > thrift -r --gen csharp:async tutorial.thrift > There is a problem that does not generate shared.thrift async method. I fixed that. Jim committed it yesterday. If there is still an issue, we should fix that as well not construct crude workarounds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617338#comment-16617338 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421958796 > thrift -r --gen csharp:async tutorial.thrift > There is a problem that does not generate shared.thrift async method. I fixed that. Jim committed it yesterday. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616990#comment-16616990 ] ASF GitHub Bot commented on THRIFT-4633: kaanid edited a comment on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421873398 thrift -r --gen csharp:async tutorial.thrift There is a problem that does not generate shared.thrift async method. so,Secondary generation thrift --gen csharp:async tutorial.thrift There is still a problem, the asynchronous method inherits the error and needs to be manually modified. See README.md for details. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616989#comment-16616989 ] ASF GitHub Bot commented on THRIFT-4633: kaanid commented on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421873398 thrift -r --gen csharp:async tutorial.thrift There is a problem that does not generate shared.thrift async method. so,Secondary generation == thrift --gen csharp:async tutorial.thrift There is still a problem, the asynchronous method inherits the error and needs to be manually modified. See README.md for details. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616494#comment-16616494 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G edited a comment on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421621446 I get lots of errors in Calculator.cs? EDIT: Ahh, that's a bug. => ticket and PR made This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616490#comment-16616490 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G edited a comment on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421621446 I get lots of errors in Calculator.cs? EDIT: Ahh, that's a bug. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616481#comment-16616481 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421621446 I get lots of errors in Calculator.cs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616476#comment-16616476 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#discussion_r217893137 ## File path: tutorial/csharp.async/README.md ## @@ -0,0 +1,8 @@ +# Tutorial Frameword 4.5+ Clent Async + +## Setp +1. thrift -gen csharp:async shared.thrift +2. thrift -r -gen csharp:async tutorial.thrift +3. Put it in Tutorial folder +4. Generated && Run Review comment: I have a general problem wth the workflow. IMHO even if we copy the files manually, we should keep the folder structure. Hence, I'd suggest to have the user copy the entire gen-csharp folder as is, not single files. Remember, it is a tutorial after all. It should be easy to grasp and show best practices. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616475#comment-16616475 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#discussion_r217893137 ## File path: tutorial/csharp.async/README.md ## @@ -0,0 +1,8 @@ +# Tutorial Frameword 4.5+ Clent Async + +## Setp +1. thrift -gen csharp:async shared.thrift +2. thrift -r -gen csharp:async tutorial.thrift +3. Put it in Tutorial folder +4. Generated && Run Review comment: I have a general problem wth the workflow. IMHO even if we copy the files manually, we should keep the folder structure. Hence, I'd suggest to have the user copy the entire gen-csharp folder as is, not single files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616471#comment-16616471 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#discussion_r217892842 ## File path: tutorial/csharp.async/README.md ## @@ -0,0 +1,8 @@ +# Tutorial Frameword 4.5+ Clent Async + +## Setp +1. thrift -gen csharp:async shared.thrift +2. thrift -r -gen csharp:async tutorial.thrift Review comment: a) thrift -r generates the file AND all included files. Is step 1 really necessary then? b) Setup, not Setp This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[
https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616465#comment-16616465
]
ASF GitHub Bot commented on THRIFT-4633:
Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework
4.5 Async Client example
URL: https://github.com/apache/thrift/pull/1586#discussion_r217892763
##
File path:
tutorial/csharp.async/CSharpAsyncTutorial.Client/Properties/AssemblyInfo.cs
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("CSharpAsyncTutorial.Client")]
+[assembly: AssemblyDescription("")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("Microsoft")]
+[assembly: AssemblyProduct("CSharpAsyncTutorial.Client")]
+[assembly: AssemblyCopyright("Copyright © Microsoft 2018")]
Review comment:
(c) ASF ... etc
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add C# Async Client Tutorial
>
>
> Key: THRIFT-4633
> URL: https://issues.apache.org/jira/browse/THRIFT-4633
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
> Fix For: 0.12.0
>
>
> Adding Jira ticket for PR so that it gets into release notes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616467#comment-16616467 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#discussion_r217892842 ## File path: tutorial/csharp.async/README.md ## @@ -0,0 +1,8 @@ +# Tutorial Frameword 4.5+ Clent Async + +## Setp +1. thrift -gen csharp:async shared.thrift +2. thrift -r -gen csharp:async tutorial.thrift Review comment: thrift -r generates the file AND all included files. Is step 1 really necessary then? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[
https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616470#comment-16616470
]
ASF GitHub Bot commented on THRIFT-4633:
Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework
4.5 Async Client example
URL: https://github.com/apache/thrift/pull/1586#discussion_r217892800
##
File path:
tutorial/csharp.async/CSharpAsyncTutorial.Server/Properties/AssemblyInfo.cs
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("CSharpAsyncTutorial.Server")]
+[assembly: AssemblyDescription("")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("Microsoft")]
+[assembly: AssemblyProduct("CSharpAsyncTutorial.Server")]
+[assembly: AssemblyCopyright("Copyright © Microsoft 2018")]
Review comment:
(c) ASF ... etc
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add C# Async Client Tutorial
>
>
> Key: THRIFT-4633
> URL: https://issues.apache.org/jira/browse/THRIFT-4633
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
> Fix For: 0.12.0
>
>
> Adding Jira ticket for PR so that it gets into release notes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[
https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616468#comment-16616468
]
ASF GitHub Bot commented on THRIFT-4633:
Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework
4.5 Async Client example
URL: https://github.com/apache/thrift/pull/1586#discussion_r217892727
##
File path: tutorial/csharp.async/CSharpAsyncTutorial.Client/Program.cs
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+using System;
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Thrift;
+using Thrift.Protocol;
+using Thrift.Transport;
+
+namespace CSharpAsyncTutorial.Client
+{
+class Program
+{
+static void Main(string[] args)
+{
+Task.Run(async () => {
+await Run();
+}).Wait();
+}
+
+static async Task Run()
+{
+try
+{
+string host = "localhost";
+//string host = "thrift.service.consul";
+int port = 9090;
+
+var transport = new TSocket(host, port, 10);
+TBufferedTransport transportBuff = new
TBufferedTransport(transport, 2048);
+TProtocol protocol = new TBinaryProtocol(transportBuff);
+transport.Open();
+Calculator.Client client = new Calculator.Client(protocol);
+
+Console.WriteLine($"run Client
host:{transport.Host},port:{transport.Port}");
+await client.pingAsync();
+
+int testCount = 10;
+var sw = Stopwatch.StartNew();
+foreach (var m in Enumerable.Range(0, testCount))
+{
+int sum = client.add(1, 1);
+}
+sw.Stop();
+Console.WriteLine($"TBufferedTransport Execute client.add(1,
1) do:{testCount} ms:{sw.ElapsedMilliseconds}");
+
+sw.Restart();
+foreach (var m in Enumerable.Range(0, testCount))
+{
+int sum = await client.addAsync(1, 1);
+}
+sw.Stop();
+Console.WriteLine($"TBufferedTransport Execute
client.addAsync(1, 1) do:{testCount} ms:{sw.ElapsedMilliseconds}");
+
+
+//await client.calculateAsync(1,new Work() {
Op=Operation.ADD,Comment="add Comment"});//InvalidOperation
Review comment:
???
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add C# Async Client Tutorial
>
>
> Key: THRIFT-4633
> URL: https://issues.apache.org/jira/browse/THRIFT-4633
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
> Fix For: 0.12.0
>
>
> Adding Jira ticket for PR so that it gets into release notes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[
https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616466#comment-16616466
]
ASF GitHub Bot commented on THRIFT-4633:
Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework
4.5 Async Client example
URL: https://github.com/apache/thrift/pull/1586#discussion_r217892866
##
File path: tutorial/csharp.async/Tutorial/Properties/AssemblyInfo.cs
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("Tutorial")]
+[assembly: AssemblyDescription("")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("Microsoft")]
+[assembly: AssemblyProduct("Tutorial")]
+[assembly: AssemblyCopyright("Copyright © Microsoft 2018")]
Review comment:
company, product,copyright ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add C# Async Client Tutorial
>
>
> Key: THRIFT-4633
> URL: https://issues.apache.org/jira/browse/THRIFT-4633
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
> Fix For: 0.12.0
>
>
> Adding Jira ticket for PR so that it gets into release notes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[
https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616464#comment-16616464
]
ASF GitHub Bot commented on THRIFT-4633:
Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework
4.5 Async Client example
URL: https://github.com/apache/thrift/pull/1586#discussion_r217892722
##
File path: tutorial/csharp.async/CSharpAsyncTutorial.Client/Program.cs
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+using System;
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Thrift;
+using Thrift.Protocol;
+using Thrift.Transport;
+
+namespace CSharpAsyncTutorial.Client
+{
+class Program
+{
+static void Main(string[] args)
+{
+Task.Run(async () => {
+await Run();
+}).Wait();
+}
+
+static async Task Run()
+{
+try
+{
+string host = "localhost";
+//string host = "thrift.service.consul";
Review comment:
???
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add C# Async Client Tutorial
>
>
> Key: THRIFT-4633
> URL: https://issues.apache.org/jira/browse/THRIFT-4633
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
>Affects Versions: 0.11.0
>Reporter: James E. King III
>Assignee: James E. King III
>Priority: Minor
> Fix For: 0.12.0
>
>
> Adding Jira ticket for PR so that it gets into release notes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616469#comment-16616469 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#discussion_r217892854 ## File path: tutorial/csharp.async/README.md ## @@ -0,0 +1,8 @@ +# Tutorial Frameword 4.5+ Clent Async + +## Setp +1. thrift -gen csharp:async shared.thrift +2. thrift -r -gen csharp:async tutorial.thrift +3. Put it in Tutorial folder +4. Generated && Run Review comment: generate, not generated This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4633) Add C# Async Client Tutorial
[ https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615235#comment-16615235 ] ASF GitHub Bot commented on THRIFT-4633: Jens-G commented on issue #1586: THRIFT-4633: .net framework 4.5 Async Client example URL: https://github.com/apache/thrift/pull/1586#issuecomment-421451152 Looking into it ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add C# Async Client Tutorial > > > Key: THRIFT-4633 > URL: https://issues.apache.org/jira/browse/THRIFT-4633 > Project: Thrift > Issue Type: Improvement > Components: C# - Library >Affects Versions: 0.11.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > > Adding Jira ticket for PR so that it gets into release notes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
