[GitHub] tinkerpop pull request #715: change behaviour of repeat step to be depth fir...

2017-09-14 Thread mpollmeier
GitHub user mpollmeier opened a pull request: https://github.com/apache/tinkerpop/pull/715 change behaviour of repeat step to be depth first search (DFS) OLTP traversals are normally DFS unless there is you use a barrier step. This wasn't the case for `repeat` though, and this

Re: [DISCUSS] GLV Test Suite

2017-09-14 Thread Stephen Mallette
that's what i meant by "reflection" or as you suggest eval(). I guess the point is that if the language can support some way of taking the string value and turning it automatically into a traversal in that GLVs style then we should do that. On Thu, Sep 14, 2017 at 4:45 PM, Daniel Kuppitz

Re: [DISCUSS] GLV Test Suite

2017-09-14 Thread Daniel Kuppitz
For unparameterized queries it can probably be as easy as: @given("the traversal of") def translate_traversal(step): g = step.context.g step.context.traversal = eval(step.text) Cheers, Daniel On Thu, Sep 14, 2017 at 1:39 PM, Daniel Kuppitz wrote: > That's great

Re: [DISCUSS] GLV Test Suite

2017-09-14 Thread Daniel Kuppitz
That's great stuff. I haven't used Cucumber / Gherkin for years, but I really like the BDD approach. and then you can look at the GLV Gremlin translations specifically here: > https://github.com/apache/tinkerpop/blob/TINKERPOP-1784/ >

[DISCUSS] GLV Test Suite

2017-09-14 Thread Stephen Mallette
I've brought this issue up in the past and had suggested some options I had in mind but now I've finally put the basics of those ideas in place so I figured I'd start a fresh thread. Recall that the issue at hand is that we don't have a test suite for GLVs as gremlin-test is bound to the JVM. We

[jira] [Updated] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-14 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1783: Component/s: process > PageRank gives incorrect results for graphs with sinks >

[jira] [Updated] (TINKERPOP-1777) Gremlin .max step returns -2147483648 for empty result sets

2017-09-14 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1777: Component/s: process > Gremlin .max step returns -2147483648 for empty result

[jira] [Updated] (TINKERPOP-1777) Gremlin .max step returns -2147483648 for empty result sets

2017-09-14 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1777: Affects Version/s: 3.2.6 > Gremlin .max step returns -2147483648 for empty

[jira] [Commented] (TINKERPOP-1772) "Getting started" page not correct leading to difficulties to start with console

2017-09-14 Thread JIRA
[ https://issues.apache.org/jira/browse/TINKERPOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166826#comment-16166826 ] Cédric L. Charlier commented on TINKERPOP-1772: --- I tried to replicate on a third

[jira] [Commented] (TINKERPOP-1782) RangeByIsCountStrategy doesn't handle floating point numbers properly

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166523#comment-16166523 ] ASF GitHub Bot commented on TINKERPOP-1782: --- Github user dkuppitz commented on a diff in the

[GitHub] tinkerpop pull request #714: TINKERPOP-1782 RangeByIsCountStrategy doesn't h...

2017-09-14 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/714#discussion_r138940544 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/RangeByIsCountStrategyTest.java --- @@ -99,6

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166503#comment-16166503 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-14 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/704 I just cherry-picked the two commits from @jorgebay's PR and merged tp32 into master afterwards. So master should be in a good state now. ---

[jira] [Closed] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread Florian Hockmann (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florian Hockmann closed TINKERPOP-1766. --- Resolution: Fixed > Gremlin.Net: Closed connections should not be re-used >

[jira] [Updated] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread Florian Hockmann (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florian Hockmann updated TINKERPOP-1766: Fix Version/s: 3.3.1 3.2.7 > Gremlin.Net: Closed connections

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166463#comment-16166463 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-14 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/704 yeah - i remember that now! i wonder how i messed that up. ---

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166439#comment-16166439 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user jorgebay commented on the issue:

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-14 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/704 It's weird because 6a3fc39a912bec98707dd69d461955330627df10 was merged by @spmallette on master in 75502eef222b0dfc7aa83c2456ab319a9f9dd1a6 (he beat me to it because I was taking too long to do

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166400#comment-16166400 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-14 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/704 what the heck?! I wonder what got messed up there. i don't see a merge from jorge from tp32 to master after that, so i guess it never got in there, yet how could it have been ignored? we

[jira] [Created] (TINKERPOP-1783) PageRank gives incorrect results for graphs with sinks

2017-09-14 Thread Artem Aliev (JIRA)
Artem Aliev created TINKERPOP-1783: -- Summary: PageRank gives incorrect results for graphs with sinks Key: TINKERPOP-1783 URL: https://issues.apache.org/jira/browse/TINKERPOP-1783 Project: TinkerPop

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166366#comment-16166366 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user FlorianHockmann commented on the

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-14 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/704 Thanks for the explanation @spmallette. I was about to ask about the approach for merging pull requests as the documentation only talks about the case where separate pull requests are

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166122#comment-16166122 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #704: TINKERPOP-1766 Gremlin.Net: Add handling for closed co...

2017-09-14 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/704 @FlorianHockmann When you merge a PR to tp32, please make sure you also merge tp32 to master. Technically it is best to do that locally first, make sure both tp32 and master are building

[jira] [Commented] (TINKERPOP-1766) Gremlin.Net: Closed connections should not be re-used

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166052#comment-16166052 ] ASF GitHub Bot commented on TINKERPOP-1766: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #704: TINKERPOP-1766 Gremlin.Net: Add handling for cl...

2017-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/704 ---

[jira] [Commented] (TINKERPOP-1761) GremlinExecutor: Timeout future not cancelled on successful script evaluation

2017-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165813#comment-16165813 ] ASF GitHub Bot commented on TINKERPOP-1761: --- Github user ko-mueller commented on the issue:

[GitHub] tinkerpop issue #709: TINKERPOP-1761: Cancel script evaluation timeout

2017-09-14 Thread ko-mueller
Github user ko-mueller commented on the issue: https://github.com/apache/tinkerpop/pull/709 Alright, it just would be nice to have this fixed in the next release. I didn't upgrade from 3.2.5 to 3.3.0 because of this. It's not a big issue for me right now, just that I'd like to stay