[jira] [Commented] (TINKERPOP-1830) Race condition in Tinkergraph index creation

2017-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248312#comment-16248312 ] ASF GitHub Bot commented on TINKERPOP-1830: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex

2017-11-10 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/745 `mvn -pl tinkergraph-gremlin -DskipIntegrationTests=false -am clean install` build SUCCESS VOTE +1 ---

[jira] [Commented] (TINKERPOP-1830) Race condition in Tinkergraph index creation

2017-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248263#comment-16248263 ] ASF GitHub Bot commented on TINKERPOP-1830: --- Github user mpollmeier commented on the issue:

[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex

2017-11-10 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/745 I made the same incorrect assumption. Fixed with your latest snippet and tested with our large testbase. No NPEs, no race conditions so far, looks good. VOTE +1 ---

[jira] [Commented] (TINKERPOP-1830) Race condition in Tinkergraph index creation

2017-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247717#comment-16247717 ] ASF GitHub Bot commented on TINKERPOP-1830: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex

2017-11-10 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/745 @mpollmeier Sorry, I thought that `putIfAbsent()` returned the current map but it returns old mapping or `null` hence the `NPEs`. Should be: ```java protected void put(final String

[jira] [Commented] (TINKERPOP-1829) Improve flexibility of detachment for EventStrategy

2017-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247552#comment-16247552 ] ASF GitHub Bot commented on TINKERPOP-1829: --- Github user okram commented on the issue:

[GitHub] tinkerpop issue #746: TINKERPOP-1829 Made detachment configurable in EventSt...

2017-11-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/746 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1829) Improve flexibility of detachment for EventStrategy

2017-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247387#comment-16247387 ] ASF GitHub Bot commented on TINKERPOP-1829: --- GitHub user spmallette opened a pull request:

[GitHub] tinkerpop pull request #746: TINKERPOP-1829 Made detachment configurable in ...

2017-11-10 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/746 TINKERPOP-1829 Made detachment configurable in EventStrategy https://issues.apache.org/jira/browse/TINKERPOP-1831 The default behavior is representative of how EventStrategy currently

[jira] [Created] (TINKERPOP-1831) Refactor EventStrategy

2017-11-10 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-1831: --- Summary: Refactor EventStrategy Key: TINKERPOP-1831 URL: https://issues.apache.org/jira/browse/TINKERPOP-1831 Project: TinkerPop Issue Type: