[jira] [Commented] (TINKERPOP-2011) Use NumberHelper on choose()

[ https://issues.apache.org/jira/browse/TINKERPOP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551072#comment-16551072 ] ASF GitHub Bot commented on TINKERPOP-2011: --- Github user twilmes commented

[GitHub] tinkerpop issue #894: TINKERPOP-2011 Use NumberHelper on choose()

Github user twilmes commented on the issue: https://github.com/apache/tinkerpop/pull/894 Code & tests LGTM. VOTE: +1 ---

[jira] [Commented] (TINKERPOP-2011) Use NumberHelper on choose()

[ https://issues.apache.org/jira/browse/TINKERPOP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551010#comment-16551010 ] ASF GitHub Bot commented on TINKERPOP-2011: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #894: TINKERPOP-2011 Use NumberHelper on choose()

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/894 Yep, done. I added an entry in the root `.gitignore` file and added another `.gitignore` file in `docker/hadoop/`. The two auto-generated `Dockerfile`s will be ignored from now on. ---

[jira] [Commented] (TINKERPOP-2011) Use NumberHelper on choose()

[ https://issues.apache.org/jira/browse/TINKERPOP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550952#comment-16550952 ] ASF GitHub Bot commented on TINKERPOP-2011: --- Github user FlorianHockmann co

[GitHub] tinkerpop issue #894: TINKERPOP-2011 Use NumberHelper on choose()

Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/894 Looks like I accidentally added that `Dockerfile`. I should have checked more carefully what my commit added but shouldn't we prevent that from happening again with an entry in the `.gitig

[jira] [Commented] (TINKERPOP-2011) Use NumberHelper on choose()

[ https://issues.apache.org/jira/browse/TINKERPOP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550925#comment-16550925 ] ASF GitHub Bot commented on TINKERPOP-2011: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #894: TINKERPOP-2011 Use NumberHelper on choose()

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/894 By the way, the `Dockerfile`, that's removed by this PR, has nothing to do with the PR, but the file is an autogenerated file that shouldn't be in the repository. ---

[jira] [Commented] (TINKERPOP-2011) Use NumberHelper on choose()

[ https://issues.apache.org/jira/browse/TINKERPOP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550918#comment-16550918 ] ASF GitHub Bot commented on TINKERPOP-2011: --- GitHub user dkuppitz opened a

[GitHub] tinkerpop pull request #894: TINKERPOP-2011 Use NumberHelper on choose()

GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/894 TINKERPOP-2011 Use NumberHelper on choose() https://issues.apache.org/jira/browse/TINKERPOP-2011 Treat numerical options in `ChooseStep` as in any other numerical comparison (value matt

[jira] [Commented] (TINKERPOP-1996) Introduce read() and write() steps

[ https://issues.apache.org/jira/browse/TINKERPOP-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550910#comment-16550910 ] ASF GitHub Bot commented on TINKERPOP-1996: --- GitHub user spmallette opened

[GitHub] tinkerpop pull request #893: TINKERPOP-1996 io()

GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/893 TINKERPOP-1996 io() https://issues.apache.org/jira/browse/TINKERPOP-1996 Introduces `io()` with full support for GLVs and both OLAP and OLTP. There's a bit too much to type here to fu

[jira] [Commented] (TINKERPOP-2006) GraphML serialization invalid if a vertex and edge have similar named property

[ https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550832#comment-16550832 ] ASF GitHub Bot commented on TINKERPOP-2006: --- Github user twilmes commented

[GitHub] tinkerpop pull request #891: TINKERPOP-2006 - Fix for valid GraphML export w...

Github user twilmes commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/891#discussion_r204067177 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java --- @@ -218,20 +220,33 @@ private void writeTyp

[jira] [Commented] (TINKERPOP-2006) GraphML serialization invalid if a vertex and edge have similar named property

[ https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550828#comment-16550828 ] ASF GitHub Bot commented on TINKERPOP-2006: --- Github user twilmes commented

[GitHub] tinkerpop pull request #891: TINKERPOP-2006 - Fix for valid GraphML export w...

Github user twilmes commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/891#discussion_r204065865 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java --- @@ -218,20 +220,33 @@ private void writeTyp

[jira] [Commented] (TINKERPOP-2006) GraphML serialization invalid if a vertex and edge have similar named property

[ https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550825#comment-16550825 ] ASF GitHub Bot commented on TINKERPOP-2006: --- Github user twilmes commented

[GitHub] tinkerpop pull request #891: TINKERPOP-2006 - Fix for valid GraphML export w...

Github user twilmes commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/891#discussion_r204065136 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java --- @@ -218,20 +220,33 @@ private void writeTyp

[GitHub] tinkerpop pull request #890: Expose Pick in module.exports

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/890 ---

[jira] [Closed] (TINKERPOP-2009) Pick.any and Pick.none should be exposed in Gremlin-JavaScript

[ https://issues.apache.org/jira/browse/TINKERPOP-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Bay closed TINKERPOP-2009. Resolution: Fixed > Pick.any and Pick.none should be exposed in Gremlin-JavaScript > -

[GitHub] tinkerpop issue #890: Expose Pick in module.exports

Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/890 Cherry picked and landed in c324002c7d2184b87ef1e90067c318ebf727311f (`tp32`, `tp33` and `master`). Thanks @arings! ---

[jira] [Commented] (TINKERPOP-2012) Target .NET Standard 2.0 for Gremlin.Net

[ https://issues.apache.org/jira/browse/TINKERPOP-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550376#comment-16550376 ] Jorge Bay commented on TINKERPOP-2012: -- .NET Standard 2.0 can be comfortable for