[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...

2016-11-17 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/498 Wow, can't wait to try that out. @spmallette I bet this will also solve your `mkdirs` issues. If it's really as good as you say and if it doesn't have any downsides, we should make

[GitHub] tinkerpop issue #489: TINKERPOP-1530 Consistent use of instance()

2016-11-17 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/489 `docker/build.sh -t -i -n` kinda succeeded (it got stuck in Giraph tests, but I guess it wasn't rebased after this issue had been fixed). VOTE: +1 --- If your project is set up

[GitHub] tinkerpop pull request #439: TINKERPOP-980: added sysv and systemd init scri...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/439#discussion_r88381456 --- Diff: docs/src/upgrade/release-3.3.x.asciidoc --- @@ -31,3 +31,20 @@ Please see the link:https://github.com/apache/tinkerpop/blob/3.3.3/CHANGELOG.asc

[GitHub] tinkerpop pull request #439: TINKERPOP-980: added sysv and systemd init scri...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/439#discussion_r88381587 --- Diff: gremlin-server/src/main/bin/gremlin-server.conf --- @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] tinkerpop pull request #439: TINKERPOP-980: added sysv and systemd init scri...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/439#discussion_r88381061 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -1482,6 +1513,62 @@ and standard deviation evaluation times, as well as the 75th, 95th

[GitHub] tinkerpop pull request #439: TINKERPOP-980: added sysv and systemd init scri...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/439#discussion_r88381003 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -1482,6 +1513,62 @@ and standard deviation evaluation times, as well as the 75th, 95th

[GitHub] tinkerpop pull request #439: TINKERPOP-980: added sysv and systemd init scri...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/439#discussion_r88381583 --- Diff: gremlin-server/src/main/bin/gremlin-server.conf --- @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] tinkerpop pull request #439: TINKERPOP-980: added sysv and systemd init scri...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/439#discussion_r88381095 --- Diff: docs/src/reference/gremlin-applications.asciidoc --- @@ -1482,6 +1513,62 @@ and standard deviation evaluation times, as well as the 75th, 95th

[GitHub] tinkerpop issue #496: TINKERPOP-1556 allow developers to pass options to doc...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/496 Okay, cool, then... VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop issue #496: TINKERPOP-1556 allow developers to pass options to doc...

2016-11-16 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/496 Isn't the `DOCKER_OPTS` environment variable used by default? Or is this only true for the daemon? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop issue #495: TINKERPOP-1502 & TINKERPOP-1482: Chained has-container...

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/495 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #494: TINKERPOP-1443 - Introduce API check into the build

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/494 > the `ImmutablePath` method changes are internal changes I think that's the point. It would have been an internal change if the methods were internal, but they're public. We can ass

[GitHub] tinkerpop issue #495: TINKERPOP-1502 & TINKERPOP-1482: Chained has-container...

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/495 Since this PR touches `FilterRankingStrategyTest`s, it would be nice to have this issue fixed as well (and have some tests added to cover this scenario): ``` gremlin>

[GitHub] tinkerpop issue #495: TINKERPOP-1502 & TINKERPOP-1482: Chained has-container...

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/495 Yea, looks better now. Not sure if we should really keep all the steps in `g.V(1).outE('knows').hasLabel('created').more().bla()`. It's like the Java compiler would keep stuff within

[GitHub] tinkerpop issue #495: TINKERPOP-1502 & TINKERPOP-1482: Chained has-container...

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/495 Alright, looks like I pulled too early, just got some more changes coming through. I will retest the latest. --- If your project is set up for it, you can reply to this email and have your

[GitHub] tinkerpop issue #495: TINKERPOP-1502 & TINKERPOP-1482: Chained has-container...

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/495 ``` gremlin> g.V(1).outE("knows") ==>e[7][1-knows->2] ==>e[8][1-knows->4] gremlin> g.V(1).outE("knows").hasLabel("created") ==&g

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/457 Btw. I don't think that this error is related to any of our components. The `mkdirs` problem has been reported in Docker's issue tracker several times and whenever they thought they solved

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

2016-11-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/457 Hmm, that's very unlikely. Check the output of `docker images`. The `TAG` column shows the Hadoop version. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #493: TINKERPOP-1538 [master]

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/493 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #492: TINKERPOP-1538 [tp32]

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/492 All good now. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tinkerpop issue #485: TINKERPOP-1529 LazyBarrierStrategy is too aggressive (...

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/485 Here's an example that shows how it produces the expected result and still tries to use `barrier()`'s as often as possible: ``` gremlin> g = TinkerFactory.createModern().traver

[GitHub] tinkerpop issue #491: TINKERPOP-1538 Use non-default port for gremlin server...

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/491 Looks good, tests are not affected by other applications using port 8182. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tinkerpop issue #492: TINKERPOP-1538 [tp32]

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/492 There's still an interference between `GremlinDriverIntegrateTest` and a locally running DSE Graph instance. ``` --- T E S T

[GitHub] tinkerpop issue #485: TINKERPOP-1529 LazyBarrierStrategy is too aggressive (...

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/485 The only change I would like to do: rename "frozen steps" to "lazy steps" as they're not completely untouchable for all other strategies, it's really just about `b

[GitHub] tinkerpop issue #487: TINKERPOP-1399 NumberHelper needs to go into util and ...

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/487 It only has a private constructor already. Making it final is a good call though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop issue #485: TINKERPOP-1529 LazyBarrierStrategy is too aggressive (...

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/485 Well, what you're saying is "put all the logic into `LazyBarrierStrategy`". But what about `PathRetractionStrategy`? Same rules apply there - copy the code there as well? And if we a

[GitHub] tinkerpop issue #485: TINKERPOP-1529 LazyBarrierStrategy is too aggressive (...

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/485 Because it's more complex then that. Example: ``` g.V().as("a").out().store("a").in().sideEffect().groupCount().unfold().sideEffect()... ``` In the fi

[GitHub] tinkerpop issue #488: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy (tp...

2016-11-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/488 This PR is no longer relevant, as we have a discussion going in https://github.com/apache/tinkerpop/pull/486 (where `SimplePathStep` is no longer a `PathProcessor`). --- If your project is set

[GitHub] tinkerpop pull request #488: TINKERPOP-1545 IncidentToAdjacentStrategy is bu...

2016-11-14 Thread dkuppitz
Github user dkuppitz closed the pull request at: https://github.com/apache/tinkerpop/pull/488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-12 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 Requirements were not cached in `tp31`. I have a neat solution for `master/`, but not for `tp32`. In `tp32` we can either reset the requirements after each strategy has been applied or we can

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-11 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 I think we have 2 options: 1. reset requirements (a simple `this.requirements = null;`) at the end of mutating methods (`addStep` and `removeStep`) 2. don't cache requirements before

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-11 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 I see, that sucks. Looks like there's nothing that resets the cache at any point. IMO the admin methods `addStep` and `removeStep` should invalidate the cache. --- If your project is set up

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-11 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 Oh, you mean `Traversal.getTraverserRequirements()`. That's useless anyways (in this case). The strategy has to check every single step. --- If your project is set up for it, you can reply

[GitHub] tinkerpop pull request #488: TINKERPOP-1545 IncidentToAdjacentStrategy is bu...

2016-11-11 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/488 TINKERPOP-1545 IncidentToAdjacentStrategy is buggy (tp32) https://issues.apache.org/jira/browse/TINKERPOP-1545 Made SimplePathStep implement PathProcessor and IncidentToAdjacentStrategy

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-11 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 I really don't see what you mean by "it gets cached". `getRequirements()` as well as `getSelfAndChildRequirements()` look pretty stateless to me. --- If your project is set up for i

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-11 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 > Why not use the "marker model" ? This PR targets `tp31`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] tinkerpop pull request #487: TINKERPOP-1399 NumberHelper needs to go into ut...

2016-11-11 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/487 TINKERPOP-1399 NumberHelper needs to go into util and have a private constructor https://issues.apache.org/jira/browse/TINKERPOP-1399 Moved `NumberHelper

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/482 `docker/build.sh -t -i -n` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 Force-pushed. Filtering steps based on 2 conditions (type and traversal requirements) was easier than I thought (thanks to `TraversalHelper.anyStepRecursively()`). --- If your project is set

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 You know what, I will revert the change and not implement `PathProcessor` in `SimplePathStep`. Here's why: `IncidentToAdjacentStrategy` should only rely on the `getRequirements()` result

[GitHub] tinkerpop issue #486: TINKERPOP-1545 IncidentToAdjacentStrategy is buggy

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/486 The `PathProcessor` interface has no function for SimpleStep and doesn't add any overhead. AFAIK `PathProcessor` is only used by strategies to easily identify traversals with "sp

[GitHub] tinkerpop pull request #486: TINKERPOP-1545 IncidentToAdjacentStrategy is bu...

2016-11-10 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/486 TINKERPOP-1545 IncidentToAdjacentStrategy is buggy https://issues.apache.org/jira/browse/TINKERPOP-1545 Made `SimplePathStep` implement `PathProcessor` and `IncidentToAdjacentStrategy

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/482 I'm cool with that change. I still have to run a `docker/build.sh -t -i -n` though - will do so as soon as I have the resources available (unless someone else volunteers). --- If your project

[GitHub] tinkerpop issue #483: TINKERPOP-1547: Two bugs found associated with MatchSt...

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/483 Please don't merge this PR yet. While testing the changes in `RangeByIsCountStrategy` I realized that we can add a minor tweak to get another great optimization. I'll push my local changes

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

2016-11-09 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/457 All good here, `docker/build.sh -t -i -n` succeeded 2 times in a row for me. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tinkerpop pull request #485: TINKERPOP-1529 LazyBarrierStrategy is too aggre...

2016-11-08 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/485 TINKERPOP-1529 LazyBarrierStrategy is too aggressive (variant 2) https://issues.apache.org/jira/browse/TINKERPOP-1529 This fixes a long-term bug that was introduced when

[GitHub] tinkerpop pull request #484: TINKERPOP-1529 LazyBarrierStrategy is too aggre...

2016-11-08 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/484 TINKERPOP-1529 LazyBarrierStrategy is too aggressive https://issues.apache.org/jira/browse/TINKERPOP-1529 This fixes a long-term bug that was introduced when `LazyBarrierStrategy

[GitHub] tinkerpop issue #479: TINKERPOP-1434 Block calls on "remote" traversal to ge...

2016-11-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/479 Finally! 3 good builds in row, using `docker/build.sh -t -i -n` VOTE: +10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tinkerpop issue #481: TINKERPOP-1428: profile() throws NPE for union(group, ...

2016-11-03 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/481 Manual tests look good. `docker/build.sh -t -i -n` worked up to the point where it always fails for me in `tp32`. VOTE: +1 --- If your project is set up for it, you can reply

[GitHub] tinkerpop pull request #481: TINKERPOP-1428: profile() throws NPE for union(...

2016-11-03 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/481#discussion_r86388694 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/GroupSideEffectStep.java --- @@ -45,7 +45,7

[GitHub] tinkerpop issue #479: TINKERPOP-1434 Block calls on "remote" traversal to ge...

2016-11-02 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/479 Unfortunately I still get the same errors. Looks like they always happen in `RemoteGraphGroovyTranslatorProcessStandardTest`. --- If your project is set up for it, you can reply to this email

[GitHub] tinkerpop pull request #474: TINKERPOP-1471: IncidentToAdjacentStrategy use ...

2016-11-01 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/474#discussion_r86029705 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java --- @@ -105,21 +105,11

[GitHub] tinkerpop issue #474: TINKERPOP-1471: IncidentToAdjacentStrategy use hidden ...

2016-11-01 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/474 VOTE: +1 A little refactoring would be nice though: ``` for (final Step step : traversal.getSteps()) { if (step instanceof TraversalParent

[GitHub] tinkerpop issue #468: TINKERPOP-1420 Removal of previously deprecated gremli...

2016-11-01 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/468 So weird. Build succeeded with `docker/build.sh -t -i -n` after I've rebuilt my containers and removed the `.glv` file from my `gremlin-python` directory. VOTE: +1 --- If your

[GitHub] tinkerpop issue #472: TINKERPOP-1508: Add choose(predicate,trueTraversal)

2016-10-31 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/472 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #472: TINKERPOP-1508: Add choose(predicate,trueTraver...

2016-10-31 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/472#discussion_r85858468 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/ChooseStepTest.java --- @@ -38,7 +42,10

[GitHub] tinkerpop issue #471: TINKERPOP-1506: Optional/Coalesce should not allow sid...

2016-10-31 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/471 I've done some manual tests. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-31 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/470 Interesting. I've had different results in myy benchmark and it looked more like just a lot of noise in the measurements, since Bryn's branch was sometimes a bit faster. There's a crazy

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-31 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/470 LGTM, thus VOTE: +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

2016-10-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/446 Oh, now I see what you're saying. Yes, this would be the right way to go. The current `PropertyMapStep` implementation is pretty weird. ```java protected Map<String, E&g

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

2016-10-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/446 To support something like `valueMap(T.label, "name")`? This would be cool, but would go into another PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...

2016-10-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/470 I've done some manual tests and all looks good to me. Although the changes in this PR look scary, it doesn't seem to have a bad performance impact (I couldn't see a performance impact at all

[GitHub] tinkerpop issue #468: TINKERPOP-1420 Removal of previously deprecated gremli...

2016-10-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/468 `docker/build.sh -t -i -n` fails for me with: ``` Tests run: 490, Failures: 0, Errors: 1, Skipped: 54, Time elapsed: 32.5 sec <<<

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

2016-10-28 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/446 I've seen lots of code where people actually use `id` as a property name. ``` gremlin> g = TinkerGraph.open().traversal() ==>graphtraversalsource[tinkergraph[vertices:0 e

[GitHub] tinkerpop issue #461: TINKERPOP-932 Added "force" option on session close.

2016-10-28 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/461 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #463: TINKERPOP-919 Added supportsDuplicateMultiProperties()

2016-10-28 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/463 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #462: TINKERPOP-1525 Avoid starting VP worker iterations tha...

2016-10-28 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/462 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #458: Message scope initialization in PeerPressureVertexProg...

2016-10-28 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/458 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #465: TINKERPOP-1235 Removed deprecated "performance" tests.

2016-10-28 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/465 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #467: Added getProjectKeys in ProjectStep

2016-10-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/467 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #455: TINKERPOP-1495: Global list deduplication doesn't work...

2016-10-12 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/455 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/447 Cool. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #447: TINKERPOP-1455: Provide String-based withStrategy()/wi...

2016-10-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/447 Code looks good, `docker/build.sh -t -i` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-10-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/444 The gist was that you could live without the 2 additional files, but your life would be affected by an everlasting sadness. Hence we concluded that we keep the symbolic links. However

[GitHub] tinkerpop issue #442: TINKERPOP-1467 Corrected a number of problems in close...

2016-10-03 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/442 Looks good here too. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop pull request #445: TINKERPOP-1470: InlineFilterStrategy should try...

2016-10-03 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/445#discussion_r81550568 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/InlineFilterStrategy.java --- @@ -72,97

[GitHub] tinkerpop issue #441: TINKERPOP-1467 Corrected a number of problems in close...

2016-09-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/441 FYI: 3x BUILD SUCCESS in a row. My vote still holds true. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-09-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/444 This branch was rebased and force pushed. If you've had it checked out before, you'll likely have a merge conflict in your local version. Try to checkout a fresh copy: ``` git

[GitHub] tinkerpop issue #441: TINKERPOP-1467 Corrected a number of problems in close...

2016-09-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/441 As said in a private chat, integration tests were stuck when I ran them first. However, the second attempt succeeded. More investigation is apparently needed, but for this PR: VOTE: +1

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/444 @okram We could get rid of the additional release steps if we would remove the 2 extra `gremlin.sh` files. Any reason why you prefer those? If you're just too lazy to type out the `target` path

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/444 ``` daniel@cube /projects/apache/tinkerpop (TINKERPOP-1158) gremlin.sh -v emits log4j initialization errors $ bin/gremlin.sh -v gremlin 3.1.5-SNAPSHOT daniel@cube /projects/apache

[GitHub] tinkerpop pull request #444: TINKERPOP-1158 gremlin.sh -v emits log4j initia...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/444#discussion_r81171446 --- Diff: gremlin-console/src/main/bin/gremlin.sh --- @@ -111,3 +115,5 @@ fi # Start the JVM, execute the application, and return its exit code

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/444 Sorry, I must have lost some changes when I made the last rebase. Unbound variable errors are fixed now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #444: TINKERPOP-1158 gremlin.sh -v emits log4j initializatio...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/444 I saw this error yesterday, but fixed it (after rebasing). Are you sure you've had the latest version for your test? --- If your project is set up for it, you can reply to this email and have

[GitHub] tinkerpop pull request #444: TINKERPOP-1158 gremlin.sh -v emits log4j initia...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/444#discussion_r81114584 --- Diff: bin/gremlin.sh --- @@ -1,22 +0,0 @@ -#!/bin/bash --- End diff -- It's no longer a file, it's a symbolic link. GitHub only makes

[GitHub] tinkerpop pull request #444: TINKERPOP-1158 gremlin.sh -v emits log4j initia...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/444#discussion_r81114609 --- Diff: gremlin-console/bin/gremlin.sh --- @@ -0,0 +1 @@ +../target/apache-tinkerpop-gremlin-console-3.1.5-SNAPSHOT-standalone/bin/gremlin.sh

[GitHub] tinkerpop pull request #441: TINKERPOP-1467 Corrected a number of problems i...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/441#discussion_r81113714 --- Diff: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java --- @@ -1248,6 +1250,73 @@ public void

[GitHub] tinkerpop pull request #441: TINKERPOP-1467 Corrected a number of problems i...

2016-09-29 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/441#discussion_r81113830 --- Diff: docs/src/upgrade/release-3.1.x-incubating.asciidoc --- @@ -27,6 +27,23 @@ TinkerPop 3.1.5 *Release Date: NOT OFFICIALLY RELEASED YET

[GitHub] tinkerpop pull request #443: TINKERPOP-1158 gremlin.sh -v emits log4j initia...

2016-09-28 Thread dkuppitz
Github user dkuppitz closed the pull request at: https://github.com/apache/tinkerpop/pull/443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] tinkerpop pull request #444: TINKERPOP-1158 gremlin.sh -v emits log4j initia...

2016-09-28 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/444 TINKERPOP-1158 gremlin.sh -v emits log4j initialization errors https://issues.apache.org/jira/browse/TINKERPOP-1158 Tweaked `gremlin.sh` so that it can be started from anywhere

[GitHub] tinkerpop issue #436: TINKERPOP-944 Deprecate Graph.Exceptions.elementNotFou...

2016-09-25 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/436 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #429: TINKERPOP-1457 Fixed Lambda serialization in bytecode ...

2016-09-23 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/429 `docker/build.sh -t -i -n` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tinkerpop issue #424: TINKERPOP-1451 TinkerGraph persistence cannot handle a...

2016-09-19 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/424 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop pull request #428: TINKERPOP-927 bin/publish-docs.sh should only u...

2016-09-19 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/428 TINKERPOP-927 bin/publish-docs.sh should only upload diffs. https://issues.apache.org/jira/browse/TINKERPOP-927 VOTE: +1 You can merge this pull request into a Git repository

[GitHub] tinkerpop pull request #427: TINKERPOP-927 bin/publish-docs.sh should only u...

2016-09-19 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/427 TINKERPOP-927 bin/publish-docs.sh should only upload diffs. https://issues.apache.org/jira/browse/TINKERPOP-927 VOTE: +1 You can merge this pull request into a Git repository

[GitHub] tinkerpop issue #411: TINKERPOP-1444: Benchmark bytecode->Traversal creation...

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/411 All good, here's the missing VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #420: Fix multiple occurrences of 'the'

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/420 This PR has been merged. Thank you for **the the** contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/417 Regarding the `match()` translation, it's indeed very easy: ``` gremlin> g.V().as("a").outE("created").as("b"). ..1> inV().as(&qu

[GitHub] tinkerpop issue #399: TINKERPOP-1369 Renamed REST API to HTTP API

2016-09-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/399 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #406: TINKERPOP-1391 issue with where filter

2016-09-13 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/406 Right, this one was cherry-picked. But now, after a reset, a merge and a forced push, the commit hashes are still different. --- If your project is set up for it, you can reply to this email

<    1   2   3   4   5   6   >