Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/952
@jorgebay @spmallette Thanks for finding the issue and sorting guys!
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette I can confirm that this test works for bytecode submission so
possibly an issue in the way the bindings are being submitted? Should the
language parameter be gremlin-groovy
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Ok, have pushed the changes along with the documentation
changes we'd discussed. Hopefully it's an easy fix.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Ok so your above code runs fine and returns a value. It appears
that my call to g.V(1).property() is not liked.
My request looks like this now:
`[RequestMessage
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
I've just tried it not parsing the bindings to strings and get the same
issue. So I'm wondering now if I do need to parse the parameters or if I'm just
calling the addProperty function wrong
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette Doing better now thank you!
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@jorgebay @spmallette So I've written the following test, however I'm
getting a Provided key/value array length must be a multiple of two when
submitting. I am guessing this is due
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette, my apologies I've been unwell the last week. I have done the
test but it showed that I need to parse the bindings so that the standard Op
processor can read them, it doesn't
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r218858884
--- Diff:
gremlin-server/src/test/resources/org/apache/tinkerpop/gremlin/server/gremlin-server-integration.yaml
---
@@ -41,6 +41,7 @@ serializers
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r217498294
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r214833558
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r214832381
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/client.js
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r214831866
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
Hiya guys,
I have moved the code out of the existing classes and have created a Client
class that can handle script sending and a Translator class that can convert
bytecode
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette thanks for the feedback. I'll wait on further input from
@jorgebay and implement it to be more closely aligned with the other GLVs based
on this and further feedback.
---
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r213212310
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/remote-connection.js
---
@@ -66,7 +67,27 @@ class RemoteStrategy
GitHub user mattallenuk opened a pull request:
https://github.com/apache/tinkerpop/pull/922
TINKERPOP-1959: Ability to send a script to the Gremlin Server.
Hiya,
Submitting a PR for consideration re sending a script to a Gremlin server.
I've added an eval
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/898
I'm also using Gremlin Javascript in a Typescript project. I'd be happy to
give the typings file generation a crack if @daem0ndev is not able to.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Awesome, thanks guys for the help in getting it there!
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay I think I've got it now. Starting to see through the fog.
Hopefully that last push is the one :)
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
```
First, rewinding head to replay your work on top of it...
Generating patches: 100% (757/757), done.
Applying: valueMap should always return string keys
Using index info
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Ok, done that which way do I rebase? Tried
```
git checkout TINKERPOP-1977
git rebase origin/tp32
```
and getting some merges required with files I've not touched.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
origin https://github.com/mattallenuk/tinkerpop.git (fetch)
origin https://github.com/mattallenuk/tinkerpop.git (push)
upstreamhttps://github.com/apache/tinkerpop.git (fetch
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
If i look at https://github.com/mattallenuk/tinkerpop/commits/tp32, it
appears to be what you were expecting? Have I done it the wrong way around?
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
:( sorry
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette thanks I think I've got it right now. Not a git expert, still
learning :)
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay I've rebased my TINKERPOP-1977 onto tp32 and made changes to the
documentation. Not sure I've done it right as I'm seeing lots of conflicts here
now lol!
Let me know
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette, @jorgebay it has been a pleasure to contribute back, thank you
both for helping me get it done and for helping to improve my skills as the
pull has progressed. This is my first
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay Yes that is a great idea have implemented and made the changes
requested. Have also updated the tests to use the PlainTextSaslAuthenticator
class.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay I've modified the Sasl Authenticator so that a mechanism can now
be passed in along with any mechanism options. I've changed the Sasl Plain
Authenticator to mimic the Java handler
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette thank you I'll give that a go.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette you may be able to help me with this. I'm trying to understand
the SASL authentication process looking at how the Java code handles it
(https://github.com/apache/tinkerpop/blob
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Great, I'm working on making the SASL authenticator better so that it can
handle any mechanism and goes through the SASL client first authentication
flow. Hopefully have that done soon.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Ok, I have found the issue. Maven doesn't create a TLS secured gremlin
server for it's secure server. I changed my connection string to use a plain
web socket with no TLS and the tests have
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette, no worries.
Problem no 2 is a timeout on making connection to the secure gremlin
server, my plan is to try the tests on a local gremlin server that I control
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette, sorry, my apologies, haven't been able to look at this much
over the last few days. Have some time planned nearer end of the week to
progress this. I have Maven working but when
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Still having issues with Maven build but think I'm getting closer to making
it work. Once working I'll get the integration tests working. Also going to
look at option B on the Sasl class.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay Unfortunately I cannot get the integration tests to run locally
on my mac I am getting an error on maven around
gremlin-server:jar:3.4.0-snapshot not being found. I don't really
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/889#discussion_r201431625
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js
---
@@ -151,7 +156,16 @@ class
Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/889#discussion_r201429698
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/remote-connection.js
---
@@ -33,9 +33,11 @@ class RemoteConnection
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay, I've abstracted out the transport and made some changes to the
DriverRemoteConnection class to handle the authenticator response.
My only concern with the implementation
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay. I did actually do it this way originally but was trying to avoid
changing DriverRemoteConnection too much. Will upload these changes this week
for review.
@spmallette
GitHub user mattallenuk opened a pull request:
https://github.com/apache/tinkerpop/pull/889
Tinkerpop 1977 - Sasl Authentication
Have implemented Sasl Authentication after discussion on Gremlin Users
group. I think this is along the lines of the thinking of the TINKERPOP-1977
43 matches
Mail list logo
