[GitHub] tinkerpop issue #756: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

2017-11-22 Thread pietermartin
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/756 VOTE +1 ---

[GitHub] tinkerpop pull request #756: TINKERPOP-1832: TraversalHelper.replaceStep set...

2017-11-22 Thread pietermartin
GitHub user pietermartin opened a pull request: https://github.com/apache/tinkerpop/pull/756 TINKERPOP-1832: TraversalHelper.replaceStep sets previousStep to the wrong step `TraversalHelper.replaceStep` needs to first remove the step before adding in the new step. Else it gets its

[GitHub] tinkerpop pull request #751: TINKERPOP-1832: TraversalHelper.replaceStep set...

2017-11-22 Thread pietermartin
Github user pietermartin closed the pull request at: https://github.com/apache/tinkerpop/pull/751 ---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

2017-11-22 Thread pietermartin
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/751 Closing to retarget tp32 ---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

2017-11-20 Thread pietermartin
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/751 I'd have to check but pretty sure its the same on 3.2.x ---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

2017-11-19 Thread pietermartin
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/751 VOTE +1 ---

[GitHub] tinkerpop pull request #751: TINKERPOP-1832: TraversalHelper.replaceStep set...

2017-11-19 Thread pietermartin
GitHub user pietermartin opened a pull request: https://github.com/apache/tinkerpop/pull/751 TINKERPOP-1832: TraversalHelper.replaceStep sets previousStep to the wrong step https://issues.apache.org/jira/browse/TINKERPOP-1832 `TraversalHelper.replaceStep` needs to first

[GitHub] tinkerpop issue #706: TINKERPOP-1767 Added Io.requiresVersion(Object)

2017-09-07 Thread pietermartin
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/706 All tests pass on Sqlg. VOTE +1 ---

[GitHub] tinkerpop issue #636: TINKERPOP-1691 Changed semantics of EventStrategyProce...

2017-06-21 Thread pietermartin
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/636 `EventStrategyProcessTest` Line 857 `assertEquals(1, IteratorUtils.count(v.properties()));` also needs a `g.V(v)` With that in all my tests are passing. --- If your project is set

[GitHub] tinkerpop issue #530: TINKERPOP-1531: DedupTest.g_V_asXaX_repeatXbothX_times...

2017-01-10 Thread pietermartin
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/530 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or