Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
We have enough votes to commit this. I'll handle it today. Thanks everyone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I reconfirmed with the latest updates and reaffirm my +1 vote from before.
- On Docker, this builds cleanly with `docker/build.sh -t -n -i`
- On Mac, this builds cleanly with `mvn clean
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Well - this isn't a rebase - it is a merge. See the ugly merge commit here:
d49f692f890d1c868f9de674901e14c34e7c20ba
For further explanation:
```text
D:\Data\TEMP\@Other\t
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
@pauljackson It's all good. It's only the history here in the PR that looks
weird. Since it's just the one commit, it'll be right in git history when it's
actually merged.
---
If your project
Github user pauljackson commented on the issue:
https://github.com/apache/tinkerpop/pull/457
It didnât look intuitively correct, but I didnât know what was normal.
Whatâs the easiest way to make this right, right, right? Just start over and
create a new pull request?
Th
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I didn't consider that your remote branch was behind. Duh. What should have
been done is a forced push `git push -f origin tp31` to replace your remote
branch with your local branch. Instead g
Github user pauljackson commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Thank you Robert. This was adequate, I think, to give me some things to
Google.
Iâve run these commands from my local clone of my fork. It looks like
that was all that was necessary
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
good to know they both work. i sorta figured `merge` would be ok in this
case as github would just figure out the diff and only include his one commit.
when we merged that to our stuff, it woul
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Either one appears to work cleanly. Just update first - `git fetch --all`.
Obviously, make sure you're on your branch `git checkout tp31`.
Then either `git rebase upstream/tp31` or `git m
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
well - your `tp31` is now out of date because a number of changes
(including the one that i need to test this branch with) have been added to
that branch that are not in yours. If you were work
Github user pauljackson commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Sorry, Iâm fluent in git (shame). From reading, I gleaned that rebase is
a type of merge from one branch to another. Since I created the pull request on
tp31 I donât understand what it mea
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Looks like #498 has merged. @pauljackson if you could kindly rebase this on
`tp31` for me I can give it a final test.
---
If your project is set up for it, you can reply to this email and have
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I think we can get this merged once #498 goes in as it solves my problems
with the build it seems. @pauljackson i will ping back here when that merges
and request an additional rebase from you
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
```text
$ sestatus -v
SELinux status: disabled
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
It's common these days to be enabled by default. Try: sestatus
Robert Dale
On Tue, Nov 15, 2016 at 10:53 AM, spmallette wrote:
> Github user spmallette commented on the issue:
>
> https://github.com/apache/tinkerpop/pull/457
>
> i didn't think so. I purposely didn't turn anything on th
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Btw. I don't think that this error is related to any of our components. The
`mkdirs` problem has been reported in Docker's issue tracker several times and
whenever they thought they solved it, so
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
i didn't think so. I purposely didn't turn anything on that I know of.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Hmm, that's very unlikely. Check the output of `docker images`. The `TAG`
column shows the Hadoop version.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
@dkuppitz does that make any sense to you? is docker not using 2.7.2
somehow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pauljackson commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Looking at the Hadoop code gives no direct clue (to me), but it does seem
to indicate that you are not using the 2.7.2 version, which might explain the
inconsistent results. Maybe your local m
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
The stack trace is pasted above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user pauljackson commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Is there a stacktrace or other output that might help us figure this out?
Specific test that fails?
Thanks,
-Paul
From: stephen mallette [mailto:notificati...@github.
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I configured a system with the same specs as listed, but I got 3
consecutive successes. Not sure what the issue could be.
---
If your project is set up for it, you can reply to this email and hav
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
```text
$ docker --version
Docker version 1.12.3, build 6b644ec
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 14.04.
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
@spmallette what's your Docker version and host platform? Curious to see if
I can recreate the failure.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I'm still in a position where tp31 is fine on docker but this PR is not. I
rely on docker pretty heavily, so until I figure out what's wrong with my
environment, I'm hesitant to +1 this though
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/457
All good here, `docker/build.sh -t -i -n` succeeded 2 times in a row for me.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I remember that we talked about that, but I thought we'd said this version
was ok
```text
$ docker --version
Docker version 1.12.3, build 6b644ec
```
no?
---
If y
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I just started a fresh build. Regarding the stacktraces: Wasn't the
`mkdirs()` errors related to your outdated Docker version?
---
If your project is set up for it, you can reply to this email a
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I retested again overnight after rebasing the PR on `tp31` and still having
success with Docker build on Ubuntu and Mac. Looking at the code changes, I
don't see how they would cause that Spark fa
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
Sorry to say I'm still getting errors.
```text
Results :
Tests in error:
GroupTestV3d0$Traversals>GroupTestV3d0.g_V_group_byXoutE_countX_byXnameX:139->AbstractGreml
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
any update on your Docker build @spmallette? still works ok for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
i didn't try with just `-t` - pretty sure it is just integration tests
though. i found what i think is a fix to my problem though - i removed all my
docker images and had them rebuild and i jus
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
@spmallette are you hitting that with `docker/build.sh -t` also or only
with integration tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/457
i'm having a tough time getting this to build with docker. not sure
whykeep getting failures that seem unrelated to this PR (dies in spark).
```text
java.lang.IllegalStateExcep
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I didn't encounter any failures with the TinkerGraph integration tests on
Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
I verified multiple platforms to ensure the changes didn't have any adverse
affects.
- On Docker, this builds cleanly with `docker/build.sh -t -n -i`
- On Mac, this builds cleanly
38 matches
Mail list logo
