[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-05 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/509 Changes look easy enough to give a quick after-merge VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 Sorry. I thought we had 3 VOTEs and I merged. I just asked @dkuppitz to VOTE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-02 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/509 Sure, the conflicts should be resolved now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-02 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/509 @FlorianHockmann looks like you have some conflicts on your branch - could you rebase on tp32 please? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-01 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/509 Yeah, `start()` could really lead to problems in client applications. I will remove it from the statics. --- If your project is set up for it, you can reply to this email and have your

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 I would actually remove `start()` from static imports. Its never used as its more of a "helper method" and then less chance for naming collisions. --- If your project is set up for it, you can

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-01 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/509 Ok, I wasn't sure whether those methods make sense for a GLV, but it's good to know as I can now also implement it that way for the C# GLV. My last commit adds hard-coded

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-12-01 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 Perfect. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] tinkerpop issue #509: TINKERPOP-1576 gremlin-python calls non-existent metho...

2016-11-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/509 In Gremlin-Java, those methods do the following: ``` public static GraphTraversal start() { return new DefaultGraphTraversal<>(); } public