[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-29 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/606 Thanks Marko! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-26 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 Please see https://github.com/apache/tinkerpop/pull/615 . Here is what I did: 1. Created a JIRA first. 2. Fixed the problem. 3. Created a test case that fails with the problem, but

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-24 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/606 In theory, yes. But it seems to behave fine as it is. Here's a scenario for the gremlin-groovy shell: ``` g = TinkerGraph.open() v0 = g.addVertex("x", 1) v1 =

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 It must effect semantics as `until` is different from `emit`. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-20 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/606 I spoke to @ml86 (we are colleagues) and we think that this error doesn't actually change the functionality. It only leads to computational overhead. But that makes it hard to write a test

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 You need splits so the traverser remains "local" to the child branch. I think your fix for this particular problem is correct, it would be great if you could also add a test case to `RepeatTest`

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-11 Thread ml86
Github user ml86 commented on the issue: https://github.com/apache/tinkerpop/pull/606 I continued to read the code and it turned auto that my initial assumption that the traverser split was caused by the use of addEmitToTraversal was wrong. The split would occur anyway since

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-08 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/606 You don't run `gremlin-test` module. That just contains the tests themselves. You need to run a `Graph` implementation that uses `gremlin-test`, like `tinkergraph-gremlin`. I think that's your

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-03 Thread ml86
Github user ml86 commented on the issue: https://github.com/apache/tinkerpop/pull/606 I am not able to get the test setup running for developing the requested tests. I tried : ``` export

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-03 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/606 Did this problem exist in 3.1.x? If so, perhaps it should be fixed back in tp31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 Whoa!? That is a huge problem. Can you do three things for this please? 1. Can you write a test case in `RepeatTest` that shows it breaking, but with your fix, it working. 2. Can you