Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
I just cherry-picked the two commits from @jorgebay's PR and merged tp32
into master afterwards. So master should be in a good state now.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/704
yeah - i remember that now! i wonder how i messed that up.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/704
It's weird because 6a3fc39a912bec98707dd69d461955330627df10 was merged by
@spmallette on master in 75502eef222b0dfc7aa83c2456ab319a9f9dd1a6 (he beat me
to it because I was taking too long to do
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/704
what the heck?! I wonder what got messed up there. i don't see a merge
from jorge from tp32 to master after that, so i guess it never got in there,
yet how could it have been ignored? we
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
Thanks for the explanation @spmallette. I was about to ask about the
approach for merging pull requests as the documentation only talks about the
case where separate pull requests are
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/704
@FlorianHockmann When you merge a PR to tp32, please make sure you also
merge tp32 to master. Technically it is best to do that locally first, make
sure both tp32 and master are building
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/704
VOTE +1
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
> Should we file a different ticket for the pool improvements?
Yes, I think a dedicated ticket for those improvements is a good idea and
it makes probably sense if you create it
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/704
About request pipelining, you can send in a queue one by one regardless of
whether or not it was received. On the read side, once a message is received
you issue a following call to
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
Thanks for your comments so far, I'll implement the changes you suggested.
I definitely agree that the driver and especially the connection pool needs
to be improved and I would
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/704
I've left some line comments on the pr.
Apart from the issue this patch is addressing, we should create separate
tickets for issues related to the .NET driver pool:
- Blocking (use
11 matches
Mail list logo
