Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
nice @dkuppitz - i can finally VOTE +1:1st_place_medal:
better merge it through fast before someone sees a problem! :smiling_imp:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Ok - the issue is related to how the `tabs.css` is in there:
```html
```
if that were a relative url like everything else, we'd have it.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
i guess i will try
again.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Worked well for me.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
I just generated docs locally on this branch and i didn't get the tabs - it
showed radio buttons. something wrong with the stylesheet after rebase maybe?
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
It does scale to up to 4 tabs. Should we ever have more, we only need to
tweak the
[maxTabs](https://github.com/apache/tinkerpop/pull/766/files#diff-c362bf9cce8980393d4230e56c86a655R31)
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
I was hoping to see us merge this for next release, but now that we have to
release this patch because of the groovy bug, there won't be a lot of time to
do much with the cool changes you have
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
I have no problem pushing it off. It's unlikely that any other PR is going
to affect the changes in this PR, so rebasing should be a no-brainer at any
time.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
wow - thanks to @robertdale with
https://github.com/apache/tinkerpop/commit/34f924e50db3a20a3ba538c4e16bbfcfa9e7b873
because i can finally generate these docs with docker. i guess the question
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
don't have any of that stuff from my last attempt. what are you looking for
exactly? i could fire it up again
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@spmallette did you save your console log?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
tried again using images from this branch and died the same way. so weird
when stuff like this happens with docker.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
I rebuilt my containers using this branch and `docker/build.sh -d` just
finished `gremlin-variants.asciidoc`.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
i deleted both when i did it, but i didn't rebuild from master - i built
from this branch i guess
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Hmm.. there doesn't seem to be much difference. Are you deleting both the
hadoop and base images?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Try rebuilding the docker images using master.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/766
I saw some problems using docker above to generate docsis that still an
issue? I'm getting this:
```text
* source:
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Excellent!
VOTE +1
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
In the 'Console' tab, muli-line statements work. They have the `\`
continuation after the callout. However, on the 'language' tab, these seem to
be lost thus copy-paste multi-line statements
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz I pushed a CTR fix for invisibility to tp32/master. This fixes
the screen from being rendered to pixels wide. It didn't help the code
block language popup though.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@robertdale I like the look :) Do you want to give it a try and tweak the
CSS? I just took it from [here](https://codepen.io/JamieKDonnelly/pen/wBQQPK),
changed some colors and that's it. Maybe
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Just what I was afraid of... the tabs look just like they do in the
screenshots. And I don't mean that in a good way :smile:
Seriously, this is fantastic. Multi-line works too.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
@dkuppitz I did see that. There was a dep added to the image. I have that
rebuilding now. Will let you know the results.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/766
Hmm, this was another ticket and should be solved in this branch as I
rebased it after the latest release.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/766
What about for those of us unable to build it?
```
sh docker/build.sh -d
* source: /usr/src/tinkermem/docs/src/recipes/olap-spark-yarn.asciidoc
target:
25 matches
Mail list logo
