Github user GCHQResearcher1337 commented on the issue:
https://github.com/apache/tinkerpop/pull/876
@spmallette Yep. Awesome - thanks for all your input + reviews!
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
I will take care of merging this now that we have reviews done. Thanks for
patiently working through this process @GCHQResearcher1337 - is that how you
will forever be known to us by the way?
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/876
VOTE: +1
---
Github user GCHQResearcher1337 commented on the issue:
https://github.com/apache/tinkerpop/pull/876
@dkuppitz Thanks for your comments. I think I've fixed the issues you
spotted.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/876
VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
Nice @GCHQResearcher1337 - VOTE +1
---
Github user GCHQResearcher1337 commented on the issue:
https://github.com/apache/tinkerpop/pull/876
I've now added support for named loops - described in
https://issues.apache.org/jira/browse/TINKERPOP-967, however I have not
introduced a new `times()` step.
I think a new
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/876
I agree it should be treated differently. Since `as()` labeling has an
impact on the path history, it really shouldn't be used for this case.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
> perhaps there is a reason to unite the two concepts.
can't really think of a reason to "unite the two concepts" - I think that
we want to keep it as `repeat(âaâ,â¦) !=
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
Some more notes from Marko (i haven't had a chance to let them sink in
myself, just pasting them here):
```text
times(a,2) == loops(a,eq(2))
```
the idea being, you
Github user GCHQResearcher1337 commented on the issue:
https://github.com/apache/tinkerpop/pull/876
@spamallete I think I steered away from that because I initially
misunderstood what marko meant - as you pointed out the plumbing (`incrLoops`
taking a `stepLabel`) for nested repeats
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
@GCHQResearcher1337 any reason you didn't implement the labelling for
`repeat()` as described in the JIRA issue:
```text
repeat('a',out('knows').repeat('b',out('parent')))
```
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
@GCHQResearcher1337 I should have also added in my last comment:
1. Please add [CHANGELOG
](https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc) entries
as necessary
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
This PR shows a pretty nice level of understanding of the intricacies of
the core of how Gremlin works. We rarely get PRs that touch this area of
TinkerPop to any depth. I found it
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
wow - this is a cool pull request. it may take some time to go through
review as it is a non-trivial change. thanks.
---
15 matches
Mail list logo
