[
https://issues.apache.org/jira/browse/TINKERPOP-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551199#comment-15551199
]
Jorge Bay commented on TINKERPOP-1490:
--
{{async}} is a reserved keyword in many languages:
- In
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/450
1: I mentioned the difficulty of delivering a `RemoteConnection`
implementation inside the TinkerPop repository above.
2: I commented in TINKERPOP-1490 that `async` is a reserved keyword, in
[
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551349#comment-15551349
]
ASF GitHub Bot commented on TINKERPOP-1489:
---
Github user jorgebay commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551606#comment-15551606
]
ASF GitHub Bot commented on TINKERPOP-1489:
---
Github user spmallette commented on a diff in
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/449
This is a breaking change in the sense as the package name changed. I doubt
it should break most users, but a breaking change nonetheless. I think it would
have been better to deprecate it
[
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551631#comment-15551631
]
ASF GitHub Bot commented on TINKERPOP-1489:
---
Github user jorgebay commented on a diff in the
[
https://issues.apache.org/jira/browse/TINKERPOP-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551622#comment-15551622
]
ASF GitHub Bot commented on TINKERPOP-1488:
---
Github user spmallette commented on the issue:
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/450#discussion_r82163673
--- Diff: gremlin-javascript/pom.xml ---
@@ -0,0 +1,132 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/450#discussion_r82167244
--- Diff: gremlin-javascript/pom.xml ---
@@ -0,0 +1,132 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
[
https://issues.apache.org/jira/browse/TINKERPOP-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553308#comment-15553308
]
ASF GitHub Bot commented on TINKERPOP-1158:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TINKERPOP-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Kuppitz closed TINKERPOP-1158.
-
Resolution: Fixed
Fix Version/s: 3.2.3
3.1.5
> gremlin.sh
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/444
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/TINKERPOP-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez closed TINKERPOP-1488.
-
Resolution: Fixed
Fix Version/s: 3.2.3
> Make LazyBarrierStrategy part
[
https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552585#comment-15552585
]
ASF GitHub Bot commented on TINKERPOP-1458:
---
Github user davebshow commented on a diff in
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/448
This looks good. However, can you please rebase with `master/` as there
have been some changes to `graphson.py`. Also, if there is anything that needs
to be added to `gremlin-variants.asciidoc`
[
https://issues.apache.org/jira/browse/TINKERPOP-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552763#comment-15552763
]
ASF GitHub Bot commented on TINKERPOP-1158:
---
Github user okram commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552628#comment-15552628
]
ASF GitHub Bot commented on TINKERPOP-1458:
---
Github user spmallette commented on a diff in
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/449
All tests pass with `docker/build.sh -t -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aholmberg commented on the issue:
https://github.com/apache/tinkerpop/pull/448
I'm ambivalent on that. I just noticed unittest was present, and the bare
assertions were not very informative. I can take that commit out if you think
it's not worth it now.
---
If your
[
https://issues.apache.org/jira/browse/TINKERPOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1436.
---
Resolution: Duplicate
Assignee: stephen mallette
> GraphSON 2.0
[
https://issues.apache.org/jira/browse/TINKERPOP-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552772#comment-15552772
]
ASF GitHub Bot commented on TINKERPOP-1488:
---
Github user okram commented on the issue:
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/449
@spmallette -- good call. I added back `finalization.LazyBarrierStrategy`
and @Deprecated it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/TINKERPOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552610#comment-15552610
]
ASF GitHub Bot commented on TINKERPOP-1455:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82243790
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffectsTest.java
---
@@ -0,0 +1,116 @@
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82239737
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffectsTest.java
---
@@ -0,0 +1,116 @@
Github user vrkrishn commented on the issue:
https://github.com/apache/tinkerpop/pull/440
Would it be possible to push this change then and add the other
functionality as a different ticket?
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/TINKERPOP-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552454#comment-15552454
]
ASF GitHub Bot commented on TINKERPOP-1044:
---
Github user vrkrishn commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552512#comment-15552512
]
Ted Wilmes commented on TINKERPOP-1433:
---
Yes, I need to do this and then incorporate a few other
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/449
The code and tests look good to me. `mvn clean install` also ran without
issue.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82311244
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -39,12 +40,14 @@
[
https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552165#comment-15552165
]
ASF GitHub Bot commented on TINKERPOP-1458:
---
Github user spmallette commented on a diff in
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82211073
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -54,22 +57,30 @@ public
[
https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552175#comment-15552175
]
ASF GitHub Bot commented on TINKERPOP-1458:
---
Github user spmallette commented on a diff in
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82210649
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -89,9 +100,8 @@ public
[
https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552160#comment-15552160
]
ASF GitHub Bot commented on TINKERPOP-1458:
---
Github user spmallette commented on a diff in
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/440
We intend to freeze the code base for release of 3.2.3 (and 3.1.5) in a
couple of days. If you'd like to see this merged in time for 3.2.3, we'd need
to have your changes pretty soon for
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82210120
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -89,9 +100,8 @@ public
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82212090
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
---
@@ -814,18 +829,88 @@ public void
[
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551680#comment-15551680
]
ASF GitHub Bot commented on TINKERPOP-1489:
---
Github user jorgebay commented on a diff in the
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/450#discussion_r82168010
--- Diff: gremlin-javascript/pom.xml ---
@@ -0,0 +1,132 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
[
https://issues.apache.org/jira/browse/TINKERPOP-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552322#comment-15552322
]
stephen mallette commented on TINKERPOP-1433:
-
Didn't notice this issue before today -
42 matches
Mail list logo
