[
https://issues.apache.org/jira/browse/TINKERPOP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez closed TINKERPOP-1764.
-
Resolution: Fixed
Assignee: Marko A. Rodriguez
Fix Version/s:
[
https://issues.apache.org/jira/browse/TINKERPOP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154503#comment-16154503
]
ASF GitHub Bot commented on TINKERPOP-1764:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/702
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez closed TINKERPOP-1760.
-
Resolution: Fixed
Fix Version/s: 3.2.7
> OLAP compilation failing
[
https://issues.apache.org/jira/browse/TINKERPOP-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez closed TINKERPOP-1762.
-
Resolution: Fixed
Fix Version/s: 3.2.7
> Make MatchStep analyze
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/701
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154446#comment-16154446
]
ASF GitHub Bot commented on TINKERPOP-1762:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TINKERPOP-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154017#comment-16154017
]
ASF GitHub Bot commented on TINKERPOP-1756:
---
Github user dkuppitz commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153976#comment-16153976
]
ASF GitHub Bot commented on TINKERPOP-1759:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/699
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153973#comment-16153973
]
ASF GitHub Bot commented on TINKERPOP-1762:
---
Github user dkuppitz commented on the issue:
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/701
VOTE: +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153972#comment-16153972
]
ASF GitHub Bot commented on TINKERPOP-1759:
---
Github user robertdale commented on the issue:
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/699
VOTE +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153961#comment-16153961
]
ASF GitHub Bot commented on TINKERPOP-1764:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/702
Nice upgrade docs - VOTE +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153956#comment-16153956
]
ASF GitHub Bot commented on TINKERPOP-1489:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I rebased this today and added the nashorn scriptengine implementation for
`GremlinScriptEngine`. I'd like to get us running tests with js the way we do
with python since it's jsr223
[
https://issues.apache.org/jira/browse/TINKERPOP-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153943#comment-16153943
]
ASF GitHub Bot commented on TINKERPOP-1692:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/680
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
Ok, at present there is only one SimpleModule, the default. I can make
it v2 or v3 but not both.
Lets say I make the SimpleModule support V2.
Then when calling IoEdgeTest for
{"graphson-v3", true, true,
(Function) g ->
I guess I'm trying to understand why it matters for purpose of the test. If
you mix/match versions I can't think of why the test would care one way or
the other. does sqlg serialize its id to a JSON Map?
On Tue, Sep 5, 2017 at 11:19 AM, pieter gmail
wrote:
> I looked at
I looked at TinkerGraph's implementation. In fact I copied it.
TinkerGraph does not have any special id serialization. In fact both its
TinkerIoRegistryV3d0 andTinkerIoRegistryV2d0 registry uses TinkerModuleV2d0.
In IoCustomTest tests you call
You have registries for each version as well and default to v3. Please see
TinkerGraph:
https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java#L198
If the user wants to override that then that's their
Afraid I still don't quite get it. How do I register the different
SimpleModules depending on the version.
Currently it starts in SqlgGraph,
@Override
public I io(final Io.Builder builder) {
return (I) builder.graph(this).onMapper(mapper ->
[
https://issues.apache.org/jira/browse/TINKERPOP-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153616#comment-16153616
]
ASF GitHub Bot commented on TINKERPOP-1759:
---
Github user robertdale commented on a diff in
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/699#discussion_r136983503
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_Traverser.java
---
@@ -62,10 +62,12 @@ public void
The 0.2.0-incubating release of Apache S2Graph has TinkerPop support.
They've just updated their documentation to include this information:
https://github.com/apache/incubator-s2graph#tinkerpop-support
I think they meet our index listing policy at this point and we can get
them added to the home
I think you should just create a new SimpleModule for each version - don't
try to put them in the same SqlgSimpleModule. It's a naming convention that
users will have to follow rather than something explicitly enforced through
code.
On Sun, Sep 3, 2017 at 3:20 PM, pieter gmail
29 matches
Mail list logo