[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319401#comment-16319401
 ] 

ASF GitHub Bot commented on TINKERPOP-1858:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
Is it just the wrong expected exception in the test?


> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
> Environment: All
>Reporter: Keith Lohnes
>  Labels: easyfix, regression
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of 
> instantiating the specified AuthenticationHandler from the configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
Is it just the wrong expected exception in the test?


---

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319390#comment-16319390
 ] 

ASF GitHub Bot commented on TINKERPOP-1858:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
Failed docker...
```
docker/build.sh -i -t

[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
13.448 s <<< FAILURE! - in 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest
[ERROR] 
shouldBreakOnInvalidAuthenticationHandler(org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest)
  Time elapsed: 2.63 s  <<< ERROR!
java.lang.Exception: Unexpected exception, 
expected but 
was
at 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest.shouldBreakOnInvalidAuthenticationHandler(HttpChannelizerIntegrateTest.java:47)
```


> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
> Environment: All
>Reporter: Keith Lohnes
>  Labels: easyfix, regression
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of 
> instantiating the specified AuthenticationHandler from the configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
Failed docker...
```
docker/build.sh -i -t

[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
13.448 s <<< FAILURE! - in 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest
[ERROR] 
shouldBreakOnInvalidAuthenticationHandler(org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest)
  Time elapsed: 2.63 s  <<< ERROR!
java.lang.Exception: Unexpected exception, 
expected but 
was
at 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest.shouldBreakOnInvalidAuthenticationHandler(HttpChannelizerIntegrateTest.java:47)
```


---

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
@dkuppitz or @robertdale could you guys give this a try? maybe it's just me 
for some reason?


---

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319324#comment-16319324
 ] 

ASF GitHub Bot commented on TINKERPOP-1858:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
@dkuppitz or @robertdale could you guys give this a try? maybe it's just me 
for some reason?


> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
> Environment: All
>Reporter: Keith Lohnes
>  Labels: easyfix, regression
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of 
> instantiating the specified AuthenticationHandler from the configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319323#comment-16319323
 ] 

ASF GitHub Bot commented on TINKERPOP-1489:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/695
  
gremlin-javascript seems to build ok for me locally, but not on docker. 
claims it needs a maven upgrade to 3.1.0 for the npm plugin to work. do you see 
the same thing @jorgebay ?


> Provide a Javascript Gremlin Language Variant
> -
>
> Key: TINKERPOP-1489
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1489
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: javascript
>Affects Versions: 3.2.5
>Reporter: Jorge Bay
>
> It would be nice to have a Javascript Gremlin Language Variant that could 
> work with any ES5 runtime, specially the ones that support 
> [CommonJs|http://requirejs.org/docs/commonjs.html], like Node.js.
> Nashorn, the engine shipped with JDK 8+, does not implement CommonJs but 
> provides [additional 
> extensions|https://wiki.openjdk.java.net/display/Nashorn/Nashorn+extensions] 
> making modular JavaScript possible. Nashorn should be supported in order to 
> run glv tests under the same infrastructure (JDK8).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/695
  
gremlin-javascript seems to build ok for me locally, but not on docker. 
claims it needs a maven upgrade to 3.1.0 for the npm plugin to work. do you see 
the same thing @jorgebay ?


---

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319206#comment-16319206
 ] 

ASF GitHub Bot commented on TINKERPOP-1858:
---

Github user krlohnes commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
@spmallette I rebased on top of upstream/master and ran 

`mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`

And it was successful

```
[WARNING] Tests run: 204, Failures: 0, Errors: 0, Skipped: 14
[INFO]
[INFO]
[INFO] --- revapi-maven-plugin:0.8.0:check (default) @ gremlin-server ---
[INFO]
[INFO] --- maven-failsafe-plugin:2.20:verify (verify-integration-test) @ 
gremlin-server ---
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 17:58 min
[INFO] Finished at: 2018-01-09T12:05:54-05:00
[INFO] Final Memory: 56M/681M
[INFO] 

```

Running on OSX and jdk 1.8u152 


> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
> Environment: All
>Reporter: Keith Lohnes
>  Labels: easyfix, regression
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of 
> instantiating the specified AuthenticationHandler from the configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

[krlohnes]

Github user krlohnes commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
@spmallette I rebased on top of upstream/master and ran 

`mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`

And it was successful

```
[WARNING] Tests run: 204, Failures: 0, Errors: 0, Skipped: 14
[INFO]
[INFO]
[INFO] --- revapi-maven-plugin:0.8.0:check (default) @ gremlin-server ---
[INFO]
[INFO] --- maven-failsafe-plugin:2.20:verify (verify-integration-test) @ 
gremlin-server ---
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 17:58 min
[INFO] Finished at: 2018-01-09T12:05:54-05:00
[INFO] Final Memory: 56M/681M
[INFO] 

```

Running on OSX and jdk 1.8u152 


---

[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers

[Daniel Kuppitz (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318728#comment-16318728
 ] 

Daniel Kuppitz commented on TINKERPOP-1867:
---

Hmm, at some point we allowed reducing barriers in {{repeat()}}, but seems it's 
disallowed again in both main branches. However, allowing it produced the same 
problem - empty traversers. The interesting thing about the test you've 
mentioned is that it breaks if you remove just one of union's child traversals.

> union() can produce extra traversers 
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Hard to say where this bug is coming from but basically the most simple 
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used 
> in this context.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318667#comment-16318667
 ] 

ASF GitHub Bot commented on TINKERPOP-1858:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
when i do:

```text
$ mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false
```

i get this failure consistently:

```text
[ERROR] Errors: 
[ERROR]   
HttpChannelizerIntegrateTest.shouldBreakOnInvalidAuthenticationHandler »  
Unex...
[INFO] 
[ERROR] Tests run: 204, Failures: 0, Errors: 1, Skipped: 14
[INFO] 
[INFO] 
[INFO] --- revapi-maven-plugin:0.8.0:check (default) @ gremlin-server ---
[INFO] 
[INFO] --- maven-failsafe-plugin:2.20:verify (verify-integration-test) @ 
gremlin-server ---
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 16:52 min
[INFO] Finished at: 2018-01-09T11:09:03-05:00
[INFO] Final Memory: 49M/725M
[INFO] 

```

from the test output it says:

```text

---
Test set: 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest

---
Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.773 s 
<<< FAILURE! - in 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest

shouldBreakOnInvalidAuthenticationHandler(org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest)
  Time elapsed: 2.46 s  <<< ERROR!
java.lang.Exception: Unexpected exception, 
expected but 
was
at 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest.shouldBreakOnInvalidAuthenticationHandler(HttpChannelizerIntegrateTest.java:47)
```



> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
> Environment: All
>Reporter: Keith Lohnes
>  Labels: easyfix, regression
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of 
> instantiating the specified AuthenticationHandler from the configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
when i do:

```text
$ mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false
```

i get this failure consistently:

```text
[ERROR] Errors: 
[ERROR]   
HttpChannelizerIntegrateTest.shouldBreakOnInvalidAuthenticationHandler »  
Unex...
[INFO] 
[ERROR] Tests run: 204, Failures: 0, Errors: 1, Skipped: 14
[INFO] 
[INFO] 
[INFO] --- revapi-maven-plugin:0.8.0:check (default) @ gremlin-server ---
[INFO] 
[INFO] --- maven-failsafe-plugin:2.20:verify (verify-integration-test) @ 
gremlin-server ---
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 16:52 min
[INFO] Finished at: 2018-01-09T11:09:03-05:00
[INFO] Final Memory: 49M/725M
[INFO] 

```

from the test output it says:

```text

---
Test set: 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest

---
Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.773 s 
<<< FAILURE! - in 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest

shouldBreakOnInvalidAuthenticationHandler(org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest)
  Time elapsed: 2.46 s  <<< ERROR!
java.lang.Exception: Unexpected exception, 
expected but 
was
at 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizerIntegrateTest.shouldBreakOnInvalidAuthenticationHandler(HttpChannelizerIntegrateTest.java:47)
```



---

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

[Harsh Thakkar]

Hi Stephen,

It does make sense to me. The work is going on slow but steady. Let's wait and 
see how other devs feel about this, as you said.

Cheers,
Harsh
On 2018-01-09 16:31, Stephen Mallette  wrote: 
> I've had some thoughts on this thread since December. Since sparql-gremlin
> has a pretty long to-do list and there is likely a lot of discussion
> required on this list prior to it being ready for merge to a release
> branch, it seems like we might treat this as a normal feature under
> development. I think we should just merge it to a development branch in the
> TinkerPop repository and then collaborate on it from there. We've taken
> similar approaches with other "long term" pull requests which has allowed
> the code to develop as it would typically would. I'm thinking that's a
> better approach than a "big-bang" pull request.
> 
> Harsh, if that's ok with you, feel free to issue your PR against master and
> I'll get it setup against a development branch on our end (no rush, please
> give it a few days to see if everyone is ok with that approach).
> 
> On Mon, Dec 18, 2017 at 5:16 PM, Stephen Mallette 
> wrote:
> 
> > > Should I also remove the northwind file?
> >
> > I think I'd prefer to see all of our sparql examples use the existing toy
> > graphs - better not to add more options - so I'd remove it as well. If
> > anyone disagrees, I don't really feel too strongly about not including it,
> > but it would be good to hear some reasoning as to why the existing datasets
> > that we already package are insufficient for users to learn with.
> >
> > >  will need some help (quite possibly) with getting things right as far
> > as the DSL pattern for the gremlin language variants is concerned.
> >
> > We can help point you in the right direction when you get stuck or need to
> > clarify things. If you get really stuck, we can move to step 2 and have you
> > issue a PR sooner than later and we'll just merge what you have to a
> > development branch so others can collaborate with you on it more easily.
> > Let's see how things develop.
> >
> > > Also, since you are very well versed in the test suite, I would also
> > request some assistance for the same when we are there :) as it is our
> > first time pushing a work to the production level. So bear with us :)
> >
> > no worries. i will need to think on the testing approach. my thinking will
> > be focused on what i would call integration tests i.e. tests that evaluate
> > sparql-gremlin across the entire stack. I don't imagine that you need my
> > input to write some unit tests to validate the workings of your current
> > code though.
> >
> > > One question, though there is not a strict deadline, when is the 3.3.2
> > release planned?
> >
> > We have no timeline on 3.3.2 at this point (we are just in the process of
> > releasing 3.3.1 so it will be a while before we see 3.3.2). I think the
> > merging of gremlin-javascript will likely trigger that release, i would
> > guess no earlier than February 2018 if all goes right with that. I also
> > don't mean to make it sound like sparql-gremlin needs to be part of that
> > release, so if it's not ready then, it's not ready and it releases with
> > 3.3.3. You'll find that with TinkerPop, we tend to release when software is
> > "ready" and not by setting long range time deadlines for ourselves. So,
> > don't worry about when we release sparql-gremlin too much. Let's stay
> > focused on just getting the code right.
> >
> > Thanks for your understanding.
> >
> >
> >
> >
> > On Mon, Dec 18, 2017 at 5:01 PM, Harsh Thakkar  wrote:
> >
> >> Hello Stephen,
> >>
> >> Alright, I will remove the bsbm file from the repository and I refer to
> >> it in the docs (with some examples) sharing a link to download from the
> >> website if that is acceptable. No worries.
> >> Should I also remove the northwind file?
> >>
> >>
> >> Your expectations are reasonable, it was just that I wasn't very clear
> >> about what needs to be done. Now it is pretty much clear. It will take some
> >> time for me to wrap my head around the specifics of the tinkerpop codebase
> >> in order to satisfy the 3 requirements. I will need some help (quite
> >> possibly) with getting things right as far as the DSL pattern for the
> >> gremlin language variants is concerned. I am already reading the dev-docs
> >> on this, from here:
> >> http://tinkerpop.apache.org/docs/current/reference/#dsl
> >>
> >> Also, since you are very well versed in the test suite, I would also
> >> request some assistance for the same when we are there :) as it is our
> >> first time pushing a work to the production level. So bear with us :)
> >>
> >> I agree with you on not having any API shifts, this does certainly not
> >> give a good impression, also its a lot of effort down the drain. Quality
> >> must be ensured.
> >>
> >> One question, though there is not a strict deadline, when is the 3.3.2
> >> release planned?
> 

[jira] [Commented] (TINKERPOP-1860) valueMap(True) result in error in gremlin-python

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318618#comment-16318618
 ] 

ASF GitHub Bot commented on TINKERPOP-1860:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/774

TINKERPOP-1860 valueMap(true) support/testing

https://issues.apache.org/jira/browse/TINKERPOP-1860

This is the PR for master that is kin to #773 - it required additional 
changes to support GraphSON 3.0 as 3.0 is capable of returning complex objects 
for keys.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1860-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #774


commit 0b94b5072a297ab883d66804c48d8a224012a90f
Author: Stephen Mallette 
Date:   2017-12-29T13:02:55Z

TINKERPOP-1860 Added tests for valueMap(true) variations

Note that with GraphSON 2.0 we get back string representations of T.id and 
T.label. That may change for GraphSON 3.0 on the 3.3.x line of code.

commit 13f1adbd4a012f413adaa584530a78c258e2d92d
Author: Stephen Mallette 
Date:   2018-01-08T13:07:21Z

Merge branch 'TINKERPOP-1860' into TINKERPOP-1860-master

Conflicts:

gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyValueMapTest.groovy

gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ValueMapTest.java

commit 6f1b8be8ea28908de60ee4df4c201d15b755ab4a
Author: Stephen Mallette 
Date:   2018-01-08T14:19:00Z

TINKERPOP-1860 Added deserializer for T in gremlin-python

This allowed valueMap(true) to start working.

commit b7ed09907a1c47b4c7fee49d4d75da1aa5c71efc
Author: Jorge Bay Gondra 
Date:   2018-01-08T17:17:27Z

Gremlin.Net support traversal tokens in the test suite

commit bd1466b51d715e4badacd7cc7a56d5d3e53112d9
Author: Jorge Bay Gondra 
Date:   2018-01-08T17:59:12Z

Ignore g_V_valueMapXtrueX and g_V_valueMapXtrue_name_ageX on Gremlin.Net




> valueMap(True) result in error in gremlin-python
> 
>
> Key: TINKERPOP-1860
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1860
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.3.0
> Environment: Windows 10
> jvm 1.8, python 3.5
> tinkerpop 3.3.0
>Reporter: yokota masanori
>Priority: Minor
>
> I use [True] value as a argument of valueMap() step.  And it result in error 
> as below.
> (This error didn't occur in Groovy Query and return list of Value Map with id 
> and label)
> // Python 
> graph = Graph()
> g = 
> graph.traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
> g.V().valueMap(True).toList()
> =>
> TypeError 
> > 1 g.V().valueMap(True).toList()
>  ...
>  ~\site-packages\gremlin_python\structure\io\graphsonV3d0.py in 
> objectify(cls, l, reader)
> 453 x = 0
> 454 while x < len(l):
> --> 455 new_dict[reader.toObject(l[x])] = reader.toObject(l[x 
> + 1])
> 456 x = x + 2
> 457 return new_dict
> TypeError: unhashable type: 'dict'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #774: TINKERPOP-1860 valueMap(true) support/testing

[spmallette]

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/774

TINKERPOP-1860 valueMap(true) support/testing

https://issues.apache.org/jira/browse/TINKERPOP-1860

This is the PR for master that is kin to #773 - it required additional 
changes to support GraphSON 3.0 as 3.0 is capable of returning complex objects 
for keys.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1860-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #774


commit 0b94b5072a297ab883d66804c48d8a224012a90f
Author: Stephen Mallette 
Date:   2017-12-29T13:02:55Z

TINKERPOP-1860 Added tests for valueMap(true) variations

Note that with GraphSON 2.0 we get back string representations of T.id and 
T.label. That may change for GraphSON 3.0 on the 3.3.x line of code.

commit 13f1adbd4a012f413adaa584530a78c258e2d92d
Author: Stephen Mallette 
Date:   2018-01-08T13:07:21Z

Merge branch 'TINKERPOP-1860' into TINKERPOP-1860-master

Conflicts:

gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyValueMapTest.groovy

gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ValueMapTest.java

commit 6f1b8be8ea28908de60ee4df4c201d15b755ab4a
Author: Stephen Mallette 
Date:   2018-01-08T14:19:00Z

TINKERPOP-1860 Added deserializer for T in gremlin-python

This allowed valueMap(true) to start working.

commit b7ed09907a1c47b4c7fee49d4d75da1aa5c71efc
Author: Jorge Bay Gondra 
Date:   2018-01-08T17:17:27Z

Gremlin.Net support traversal tokens in the test suite

commit bd1466b51d715e4badacd7cc7a56d5d3e53112d9
Author: Jorge Bay Gondra 
Date:   2018-01-08T17:59:12Z

Ignore g_V_valueMapXtrueX and g_V_valueMapXtrue_name_ageX on Gremlin.Net




---

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

[Stephen Mallette]

I've had some thoughts on this thread since December. Since sparql-gremlin
has a pretty long to-do list and there is likely a lot of discussion
required on this list prior to it being ready for merge to a release
branch, it seems like we might treat this as a normal feature under
development. I think we should just merge it to a development branch in the
TinkerPop repository and then collaborate on it from there. We've taken
similar approaches with other "long term" pull requests which has allowed
the code to develop as it would typically would. I'm thinking that's a
better approach than a "big-bang" pull request.

Harsh, if that's ok with you, feel free to issue your PR against master and
I'll get it setup against a development branch on our end (no rush, please
give it a few days to see if everyone is ok with that approach).

On Mon, Dec 18, 2017 at 5:16 PM, Stephen Mallette 
wrote:

> > Should I also remove the northwind file?
>
> I think I'd prefer to see all of our sparql examples use the existing toy
> graphs - better not to add more options - so I'd remove it as well. If
> anyone disagrees, I don't really feel too strongly about not including it,
> but it would be good to hear some reasoning as to why the existing datasets
> that we already package are insufficient for users to learn with.
>
> >  will need some help (quite possibly) with getting things right as far
> as the DSL pattern for the gremlin language variants is concerned.
>
> We can help point you in the right direction when you get stuck or need to
> clarify things. If you get really stuck, we can move to step 2 and have you
> issue a PR sooner than later and we'll just merge what you have to a
> development branch so others can collaborate with you on it more easily.
> Let's see how things develop.
>
> > Also, since you are very well versed in the test suite, I would also
> request some assistance for the same when we are there :) as it is our
> first time pushing a work to the production level. So bear with us :)
>
> no worries. i will need to think on the testing approach. my thinking will
> be focused on what i would call integration tests i.e. tests that evaluate
> sparql-gremlin across the entire stack. I don't imagine that you need my
> input to write some unit tests to validate the workings of your current
> code though.
>
> > One question, though there is not a strict deadline, when is the 3.3.2
> release planned?
>
> We have no timeline on 3.3.2 at this point (we are just in the process of
> releasing 3.3.1 so it will be a while before we see 3.3.2). I think the
> merging of gremlin-javascript will likely trigger that release, i would
> guess no earlier than February 2018 if all goes right with that. I also
> don't mean to make it sound like sparql-gremlin needs to be part of that
> release, so if it's not ready then, it's not ready and it releases with
> 3.3.3. You'll find that with TinkerPop, we tend to release when software is
> "ready" and not by setting long range time deadlines for ourselves. So,
> don't worry about when we release sparql-gremlin too much. Let's stay
> focused on just getting the code right.
>
> Thanks for your understanding.
>
>
>
>
> On Mon, Dec 18, 2017 at 5:01 PM, Harsh Thakkar  wrote:
>
>> Hello Stephen,
>>
>> Alright, I will remove the bsbm file from the repository and I refer to
>> it in the docs (with some examples) sharing a link to download from the
>> website if that is acceptable. No worries.
>> Should I also remove the northwind file?
>>
>>
>> Your expectations are reasonable, it was just that I wasn't very clear
>> about what needs to be done. Now it is pretty much clear. It will take some
>> time for me to wrap my head around the specifics of the tinkerpop codebase
>> in order to satisfy the 3 requirements. I will need some help (quite
>> possibly) with getting things right as far as the DSL pattern for the
>> gremlin language variants is concerned. I am already reading the dev-docs
>> on this, from here:
>> http://tinkerpop.apache.org/docs/current/reference/#dsl
>>
>> Also, since you are very well versed in the test suite, I would also
>> request some assistance for the same when we are there :) as it is our
>> first time pushing a work to the production level. So bear with us :)
>>
>> I agree with you on not having any API shifts, this does certainly not
>> give a good impression, also its a lot of effort down the drain. Quality
>> must be ensured.
>>
>> One question, though there is not a strict deadline, when is the 3.3.2
>> release planned?
>>
>> Cheers,
>> Harsh
>>
>>
>> On 2017-12-18 20:48, Stephen Mallette  wrote:
>> > A quick note about (4) - Having some sample data for user convenience is
>> > good. Files like that though should not be "resources", but should be
>> added
>> > here:
>> >
>> > https://github.com/harsh9t/tinkerpop/tree/master/data
>> >
>> > Placing those files there will allow them to be included in the 

[jira] [Commented] (TINKERPOP-1858) HttpChannelizer regression: Does not create specified AuthenticationHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318518#comment-16318518
 ] 

ASF GitHub Bot commented on TINKERPOP-1858:
---

Github user krlohnes commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
@spmallette I'm not seeing any integration test failures.

```
[INFO]
[INFO] --- maven-failsafe-plugin:2.20:verify (verify-integration-test) @ 
gremlin-server ---
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 18:16 min
[INFO] Finished at: 2018-01-08T14:50:13-05:00
[INFO] Final Memory: 40M/428M
[INFO] 

```


> HttpChannelizer regression: Does not create specified AuthenticationHandler
> ---
>
> Key: TINKERPOP-1858
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1858
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
> Environment: All
>Reporter: Keith Lohnes
>  Labels: easyfix, regression
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> HttpChannelizer creates a HttpBasicAuthenticationHandler instead of 
> instantiating the specified AuthenticationHandler from the configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #767: TINKERPOP-1858: HttpChannelizer Regression: Does not c...

[krlohnes]

Github user krlohnes commented on the issue:

https://github.com/apache/tinkerpop/pull/767
  
@spmallette I'm not seeing any integration test failures.

```
[INFO]
[INFO] --- maven-failsafe-plugin:2.20:verify (verify-integration-test) @ 
gremlin-server ---
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 18:16 min
[INFO] Finished at: 2018-01-08T14:50:13-05:00
[INFO] Final Memory: 40M/428M
[INFO] 

```


---

[jira] [Comment Edited] (TINKERPOP-1867) union() can produce extra traversers

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318400#comment-16318400
 ] 

stephen mallette edited comment on TINKERPOP-1867 at 1/9/18 1:36 PM:
-

I don't get the full picture from TINKERPOP-1629. The issue is still open and I 
don't see any code tied to it - does that mean nothing changed (or did he CTR 
some changes in)? Also, do you understand what part of the reducing barrier 
causes the extra traverser to show up in the output (i'm still trying to 
understand that more fully)?

Also, this problem was found as a result of a standard TinkerPop test behaving 
differently for TinkerGraph than it did for another graph implementation - 
specifically this test:

https://github.com/apache/tinkerpop/blob/2f1a9d09c4d41ad35e9c6fabdeec3c0db1a37e34/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/UnionTest.java#L193

Any clue on why it would behave differently for different graphs?


was (Author: spmallette):
I don't get the full picture from TINKERPOP-1629. The issue is still open and I 
don't see any code tied to it - does that mean nothing changed (or did he CTR 
some changes in)? Also, do you understand what part of the reducing barrier 
causes the extra traverser to show up in the output (i'm still trying to 
understand that more fully)? 

> union() can produce extra traversers 
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Hard to say where this bug is coming from but basically the most simple 
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used 
> in this context.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318400#comment-16318400
 ] 

stephen mallette commented on TINKERPOP-1867:
-

I don't get the full picture from TINKERPOP-1629. The issue is still open and I 
don't see any code tied to it - does that mean nothing changed (or did he CTR 
some changes in)? Also, do you understand what part of the reducing barrier 
causes the extra traverser to show up in the output (i'm still trying to 
understand that more fully)? 

> union() can produce extra traversers 
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Hard to say where this bug is coming from but basically the most simple 
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used 
> in this context.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1860) valueMap(True) result in error in gremlin-python

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318368#comment-16318368
 ] 

ASF GitHub Bot commented on TINKERPOP-1860:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/773
  
VOTE +1



> valueMap(True) result in error in gremlin-python
> 
>
> Key: TINKERPOP-1860
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1860
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.3.0
> Environment: Windows 10
> jvm 1.8, python 3.5
> tinkerpop 3.3.0
>Reporter: yokota masanori
>Priority: Minor
>
> I use [True] value as a argument of valueMap() step.  And it result in error 
> as below.
> (This error didn't occur in Groovy Query and return list of Value Map with id 
> and label)
> // Python 
> graph = Graph()
> g = 
> graph.traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
> g.V().valueMap(True).toList()
> =>
> TypeError 
> > 1 g.V().valueMap(True).toList()
>  ...
>  ~\site-packages\gremlin_python\structure\io\graphsonV3d0.py in 
> objectify(cls, l, reader)
> 453 x = 0
> 454 while x < len(l):
> --> 455 new_dict[reader.toObject(l[x])] = reader.toObject(l[x 
> + 1])
> 456 x = x + 2
> 457 return new_dict
> TypeError: unhashable type: 'dict'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop issue #773: TINKERPOP-1860 Added tests for valueMap(true) variatio...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/773
  
VOTE +1



---

[jira] [Commented] (TINKERPOP-1860) valueMap(True) result in error in gremlin-python

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318324#comment-16318324
 ] 

ASF GitHub Bot commented on TINKERPOP-1860:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/773

TINKERPOP-1860 Added tests for valueMap(true) variations

https://issues.apache.org/jira/browse/TINKERPOP-1860

Somewhat surprised we didn't have tests for this variation of `valueMap()`. 

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1860

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #773


commit caede9c8ca5cad07b947a53b38a9cc145500f6bf
Author: Stephen Mallette 
Date:   2017-12-29T13:02:55Z

TINKERPOP-1860 Added tests for valueMap(true) variations

Note that with GraphSON 2.0 we get back string representations of T.id and 
T.label. That may change for GraphSON 3.0 on the 3.3.x line of code.




> valueMap(True) result in error in gremlin-python
> 
>
> Key: TINKERPOP-1860
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1860
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.3.0
> Environment: Windows 10
> jvm 1.8, python 3.5
> tinkerpop 3.3.0
>Reporter: yokota masanori
>Priority: Minor
>
> I use [True] value as a argument of valueMap() step.  And it result in error 
> as below.
> (This error didn't occur in Groovy Query and return list of Value Map with id 
> and label)
> // Python 
> graph = Graph()
> g = 
> graph.traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
> g.V().valueMap(True).toList()
> =>
> TypeError 
> > 1 g.V().valueMap(True).toList()
>  ...
>  ~\site-packages\gremlin_python\structure\io\graphsonV3d0.py in 
> objectify(cls, l, reader)
> 453 x = 0
> 454 while x < len(l):
> --> 455 new_dict[reader.toObject(l[x])] = reader.toObject(l[x 
> + 1])
> 456 x = x + 2
> 457 return new_dict
> TypeError: unhashable type: 'dict'



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] tinkerpop pull request #773: TINKERPOP-1860 Added tests for valueMap(true) v...

[spmallette]

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/773

TINKERPOP-1860 Added tests for valueMap(true) variations

https://issues.apache.org/jira/browse/TINKERPOP-1860

Somewhat surprised we didn't have tests for this variation of `valueMap()`. 

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1860

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #773


commit caede9c8ca5cad07b947a53b38a9cc145500f6bf
Author: Stephen Mallette 
Date:   2017-12-29T13:02:55Z

TINKERPOP-1860 Added tests for valueMap(true) variations

Note that with GraphSON 2.0 we get back string representations of T.id and 
T.label. That may change for GraphSON 3.0 on the 3.3.x line of code.




---