Re: GRAPHSON 3.0 serializing, IO Ref, and parent map exception

It makes sense that we shouldn't carry it forward. That wasn't what I was getting to though. My initial plea was that since moving from GraphSON 1.0 to 3.0 can introduce some breaking changes I was asking if this should be documented somewhere (update notes for example). I've since decided against

Re: GRAPHSON 3.0 serializing, IO Ref, and parent map exception

the "1" is no longer a thing (i.e. the toString() of a complex object) because GraphSON 3.0 allows complex keys. That "1" was a hack in prior versions of GraphSON to get around that problem. We shouldn't be trying to carry that forward. Does that make sense? On Mon, Apr 16, 2018 at 4:17 PM, Dylan

Re: [DISCUSS] Depth First Repeat step

Keith, I have to admit that I didn't really follow this general body of work closely, which include this pull request, the earlier one from Michael Pollmeier, the JIRA and I think some discussion somewhere on one of the mailing lists. As best I have gathered from what I did follow, I feel like

[jira] [Closed] (TINKERPOP-1938) Can we install plugin without firing gremlin console ?

[ https://issues.apache.org/jira/browse/TINKERPOP-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1938. --- Resolution: Invalid Fix Version/s: (was: 3.4.0) In the future, please

[jira] [Updated] (TINKERPOP-1938) Can we install plugin without firing gremlin console ?

[ https://issues.apache.org/jira/browse/TINKERPOP-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1938: Issue Type: Improvement (was: Task) > Can we install plugin without firing

Re: GRAPHSON 3.0 serializing, IO Ref, and parent map exception

Actually, let me change that up a bit. I would expect the Map to be part of Tree, not encapsulate it. So something like : "data":{ "@type":"g:List", "@value":[{ "@type":"g:Tree", "@value":[{ "@type":"g:Map", "@value":{ "1", {

Re: GRAPHSON 3.0 serializing, IO Ref, and parent map exception

I'm going to leverage this email a bit more for the following point. I noticed that the actual format of Tree has changed with GRAPHSON 3.0. We're now handling Lists whereas it used to be Maps. This seems to be a breaking change when using GRAPHSON 3.0. Given:

[jira] [Assigned] (TINKERPOP-1628) Implement TraversalSelectStep

[ https://issues.apache.org/jira/browse/TINKERPOP-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz reassigned TINKERPOP-1628: - Assignee: Daniel Kuppitz > Implement TraversalSelectStep >

[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search

[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439812#comment-16439812 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/838 > I'll take a swing at the js and .net stuff and see how that plays out for now. i meant to mention this in my last post but forgotjust a suggestion but you might want to wait a

[jira] [Commented] (TINKERPOP-1936) Performance enhancement to Bytecode deserialization

[ https://issues.apache.org/jira/browse/TINKERPOP-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439783#comment-16439783 ] ASF GitHub Bot commented on TINKERPOP-1936: --- GitHub user spmallette opened a pull request:

[GitHub] tinkerpop pull request #839: TINKERPOP-1936 Improved performance of Bytecode...

GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/839 TINKERPOP-1936 Improved performance of Bytecode deserialization. https://issues.apache.org/jira/browse/TINKERPOP-1936 GraphSON deserialization of `Bytecode` was using generic `List`

[jira] [Closed] (TINKERPOP-1937) Pass bytecode through ScriptEngine if Bindings are present

[ https://issues.apache.org/jira/browse/TINKERPOP-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1937. --- Resolution: Won't Do Fix Version/s: (was: 3.2.9)

Re: [DISCUSS] Depth First Repeat step

Hi, I have not properly followed the previous thread. However I thought is going to be a way to set the default behavior as apposed to needing to use barrier() Is this the case or not? For Sqlg at least it is possible to optimize BFS much more effectively than DFS so it will be nice to have

Re: GRAPHSON 3.0 serializing, IO Ref, and parent map exception

Ok that makes a lot of sense. I’ll change the the way the driver operates to reflect that and I’ll just have the RequestMessage serialize down to a native json map. Cheers! On Mon 16 Apr 2018 at 07:36, Stephen Mallette wrote: > The IO examples show that it works as you

Re: [DISCUSS] Depth First Repeat step

+1 for DFS. If the query relies on BFS, you can always do .repeat(barrier())... ^ This holds true as long as there's no significant difference in the cpu+memory consumption and overall performance of the two approaches. BFS has its advantages when it comes to bulking; an arbitrary number of

[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor

[ https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439528#comment-16439528 ] ASF GitHub Bot commented on TINKERPOP-1903: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop issue #833: TINKERPOP-1903 Migrated Credential DSL to annotation p...

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/833 VOTE: +1 ---

[DISCUSS] Depth First Repeat step

As part of #838 there’s some discussion around whether or not to make DFS the default for the repeat step. On the one hand, everything else in OLTP is depth first. On the other hand, there’s likely existing traversals that depend on the breadth first

Re: [DISCUSS] Use error-prone java compiler

I think the summary I provided on this thread back on April 3rd still seems to stand. Unless there are any final words, I think we should refer back to that for purpose of understanding where this thread went. On Mon, Apr 9, 2018 at 10:40 AM, Daniel Kuppitz wrote: > I totally

[jira] [Commented] (TINKERPOP-1903) Credentials DSL should use the Java annotation processor

[ https://issues.apache.org/jira/browse/TINKERPOP-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439363#comment-16439363 ] ASF GitHub Bot commented on TINKERPOP-1903: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #833: TINKERPOP-1903 Migrated Credential DSL to annotation p...

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/833 I implemented all your suggestions @dkuppitz - thanks ---

[jira] [Closed] (TINKERPOP-1705) Remove deprecated rebindings option

[ https://issues.apache.org/jira/browse/TINKERPOP-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1705. --- Resolution: Done > Remove deprecated rebindings option >

[jira] [Commented] (TINKERPOP-1705) Remove deprecated rebindings option

[ https://issues.apache.org/jira/browse/TINKERPOP-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439341#comment-16439341 ] ASF GitHub Bot commented on TINKERPOP-1705: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #835: TINKERPOP-1705 Removed rebindings API from java...

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/835 ---

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439340#comment-16439340 ] ASF GitHub Bot commented on TINKERPOP-1143: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #830: TINKERPOP-1143 Moved TraversalEngine to gremlin...

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/830 ---

[jira] [Closed] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1143. --- Resolution: Done > Remove deprecated TraversalSource.Builder and TraversalEngine.

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439334#comment-16439334 ] ASF GitHub Bot commented on TINKERPOP-1410: --- Github user asfgit closed the pull request at:

[jira] [Closed] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1410. --- Resolution: Done > mvn install -Dmaven.test.skip=true doesn't work on a clean

[GitHub] tinkerpop pull request #831: TINKERPOP-1410 Removed test artifact of hadoop-...

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/831 ---

[jira] [Closed] (TINKERPOP-1934) Bump to latest version of httpclient

[ https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1934. --- Resolution: Done > Bump to latest version of httpclient >

[jira] [Commented] (TINKERPOP-1934) Bump to latest version of httpclient

[ https://issues.apache.org/jira/browse/TINKERPOP-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439331#comment-16439331 ] ASF GitHub Bot commented on TINKERPOP-1934: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #832: TINKERPOP-1934 Bumped httpclient to 4.5.5

Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/832 ---

Re: GRAPHSON 3.0 serializing, IO Ref, and parent map exception

The IO examples show that it works as you say: http://tinkerpop.apache.org/docs/current/dev/io/#_requestmessage_3 I'd agree that it isn't really consistent though the "type" really isn't a g:Map i don't think - it's really a RequestMessage, but we don't have a specific type for that. Gremlin

[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search

[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439283#comment-16439283 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/838 Sorry, but I haven't had time to dig into this into any great detail. Hopefully, sometime this week. Here's some quick comments based on the discussion: > I actually think we should