Github user dalaro commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
Thanks for the comments and for running the tests.
@okram:
1. I also dislike HadoopPools and would prefer to remove it, but I don't
know how to do it correctly, even
Github user dalaro commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
Additional notes from Marko:
> okay, so as long as there is never a need for MyRegistrar, then can you
please update your PR accordingly?
> Finally, call it GryoReg
Github user dalaro commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
I saw the `shouldHandleMonthDay` test failure on CI and pushed a fix. I
carelessly broke the read leg of that serializer while doing some tedious,
boilerplate-y method signature changes
Github user dalaro commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
These questions involved a lot of back-and-forth that would have been slow
to resolve on github comments, so and I discussed the failures and the code on
a hangout earlier today
Github user dalaro commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
The problem is that GryoSerializer doesn't actually work. This is not the
first time it has shown behavior on Spark or scala runtime classes which
diverges from the behavior of Spark's
Github user dalaro commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
@spmallette You're right about overrides being the problem.
The last thing I did before opening this PR was to rebase on latest master,
when I encountered conflicts solely
Github user dalaro commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
Just a reminder: we are voting on branch
https://github.com/apache/incubator-tinkerpop/tree/TINKERPOP-1321. That
subsumes the PR and adds a combination of fixes from Marko and me
GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/372
DSP-1397 Fix StarGraph addEdge for self-edges
StarGraph has directionally-specific classes for its edges:
* StarInEdge
* StarOutEdge
StarIn(/Out)Edges belong only
GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/377
TINKERPOP-1397 StarGraph filtering with self edges
See:
* old PR #372
* JIRA issue https://issues.apache.org/jira/browse/TINKERPOP-1397
You can merge this pull request into a Git
GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/378
TINKERPOP-1397 Fix StarGraph.addEdge
See:
* old PR #372
* JIRA issue https://issues.apache.org/jira/browse/TINKERPOP-1397
As far as I can tell, GraphFilter did not exist
Github user dalaro closed the pull request at:
https://github.com/apache/tinkerpop/pull/372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/372
I'm closing this not because the conversation is settled and everything's
done, but because this PR is superseded by #377. We can keep discussing here
if you like. That's probably easier than
Github user dalaro commented on the pull request:
https://github.com/apache/tinkerpop/commit/f9706a38fbe546c0a7e5b038a6b99303d21aec01#commitcomment-18144496
@okram i don't understand the failure this caused, but the change seems
innocuous to me... no objections
---
If your project
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/372
Thanks for the replies.
@spmallette I will investigate whether this behavior also exists on 3.1 and
retarget if so. I think this will involve making a standalone test instead of
just
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/462
I force-pushed this branch with a fix (`emptyIterator -> emptyList`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/462
I made a version of this change for TINKERPOP-1389 as #466. That one's
optional, but I thought merging this into TINKERPOP-1389 might help ensure this
fix does not get lost in the eventual
GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/462
TINKERPOP-1525 Avoid starting VP worker iterations that never end
SparkExecutor.executeVertexProgramIteration was written in such a way
that an empty RDD partition would cause it to invoke
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/462
Marko's right, I wrote and tested this against TINKERPOP-1389 (before the
latest rebase), then cherry-picked against current master without retesting.
Sorry about that. He's also right about
GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/497
Limit JVM system props passed around in Spark jobs
Prior to this commit, SGC indiscriminately set the entire job config
as JVM system properties on Spark executors. It didn't account
GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/616
TINKERPOP-1680 Add string performance options to StarGraph
By default, StarGraph invokes intern() on vertex label and property
key strings. It also toString()s vertex and edge IDs
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/616
@spmallette maybe -- basis of the PR branch is
b755788c6fe7b902a3e81f3c2f11eb5a8b02c4be (May 11). I'll rebase on latest tp32
and force-push the PR branch.
---
If your project is set up
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/616
I force-pushed this PR's branch. The new basis is
4f7b8595bbcd691649e63e49deb9ed0adcaa81e7 (May 28).
---
If your project is set up for it, you can reply to this email and have your
reply appear
22 matches
Mail list logo
