Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
@dalaro you had some really nice vision on this one.
Just an organizational point - I feel like the "kryoshim" package should
live inside of the "gryo"
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/326
TINKERPOP-1322 Added ConfigurationCustomizerCompiler
https://issues.apache.org/jira/browse/TINKERPOP-1322
This `CustomizerCompiler` implementation makes it possible to set
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/333#discussion_r66296879
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java
---
@@ -721,14 +732,18 @@ public static void
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/330
@pluradj any reason you have this in your fork? do you mind creating a
TinkerPop repo branch and merging to that then re-issuing the PR from there?
---
If your project is set up
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/328
@pluradj assuming @twilmes is voting +1 here pending the spelling fix, you
will have your positive VOTE if you include a +1 yourself.
---
If your project is set up for it, you can
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Note that your PR is failing for Travis:
https://travis-ci.org/apache/incubator-tinkerpop/builds/135940598#L6936
Any idea what's wrong?
---
If your project is set
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/333
Travis still seems to be having a problem. You can see the "red X" on the
Travis job in github - just click the "Details" link next to it to see the
pr
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/314
Replaced by #327 - going to close this one from our end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/331
I posted a note about this here:
https://groups.google.com/d/msg/gremlin-users/56CI2PTWueg/0Hj915GyEQAJ
with more explicit instructions. Your code change looks
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
> Marko setup SparkHadoopGraphProvider to randomly choose either the old
serialization code or the new stuff in
e700363#diff-afffc6796745845d46e6f60ea3a992f9R91. IMHO that sho
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
Yeah - i know - it's there, but it's proliferating and becoming more and
more OK which i think is "bad". i'll bring it up as a separate issue.
---
If your project
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/325
I've confirmed that this test:
```text
GremlinResultSetIntegrateTest.shouldHandleVertexResultWithLiteSerialization:174
? Execution
```
is only failing after
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/330
ok - it wasn't a big deal - i could have just merged your stuff into a
local branch and tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/317
ok - finally was able to test in full. the work @dkuppitz did in his gist
is good. now we have:
http://tinkerpop.apache.org/docs/current/reference/
@lewismc
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/322
TINKERPOP-1196 Fix for Result.one() which could have blocked indefinitely.
https://issues.apache.org/jira/browse/TINKERPOP-1196
Result.one() sometimes would hang under rare
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/319#issuecomment-222113819
Tests hung for some reason during gremlin server integration testing with
`docker/build.sh -t -n -i`, but i then re-ran just those tests and everything
Github user spmallette commented on the issue:
https://github.com/apache/incubator-tinkerpop/pull/314
Actually, before we merge this after the next positive vote...
1. can you please squash the commits?
2. any reason we shouldn't merge this to tp31 and then master
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/324
The travis build failure doesn't seem to have anything to do with this
change. My initial test of this on 3.2.1-SNAPSHOT docs worked when "current"
did not exist thu
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/317
just to update what's happening here - i tried to test, but we have doc
generation failures on master atm. there is discussion in the tinkerpop hipchat
on what could be wrong
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/336#discussion_r67157460
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java
---
@@ -131,7 +131,7 @@ public void
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/335#discussion_r67159933
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/FeatureSupportTest.java
---
@@ -587,7 +587,7 @@ public void
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/315
@analytically did you happen to see my previous comment about
rebasing/fixing conflicts on this PR so that we can begin code review/testing
on our end? is that something you have some time
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/335
VOTE +1 - pending update to upgrade docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/336#discussion_r67174102
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java
---
@@ -131,7 +131,7 @@ public void
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/340
@leifurhauks do you know why travis is not happy? the build took some
errors it seems. Can you please look into that as you push your next change?
---
If your project is set up for it, you
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/342
TINKERPOP-1063 TinkerGraph Performance
https://issues.apache.org/jira/browse/TINKERPOP-1063
Got rid of `Stream` usage in TinkerGraph vertex/edge iteration. Tests all
pass with `mvn
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/336
I didn't re-test this but both travis builds are good and the code looks
right. Just a side note - @pluradj I didn't review this but note that we have a
bit of an ugly reality where
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/336
`gremlin-core` just have tests that need the some of the same exact
functions that are in `gremlin-test`, but the dependencies are such that
`gremlin-core` can't use the `TestHelper
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/206#issuecomment-221395541
@dkuppitz This PR kinda died - is it worth keeping it open?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/206#issuecomment-221401320
cool - please close up the JIRA issue too if the intention is to never do
this at all.
---
If your project is set up for it, you can reply
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/317#issuecomment-221404811
weird - i never noticed that you replied to my post in jira @lewismc - i'll
just say that i basically agree with what you wrote there. we can push off
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/195#issuecomment-221402006
Had a talk with @rjbriody - this PR can be closed as its stale at this
point, but the JIRA ticket should stay open.
---
If your project is set up
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/362
This is a nice body of fixes @robertdale - thanks for this. I suppose a
good number of these fixes would be good patches to the tp31 branch. Could
this PR be re-targetted at tp31 without too
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/364
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/362
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user spmallette commented on the pull request:
https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18489820
In
gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy:
In
gremlin
Github user spmallette commented on the pull request:
https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18490043
In
gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy:
In
gremlin
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/369
new PR was on #370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/377
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/346
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/348
This is most excellent - thanks!
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/355
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/356
Note that it's not sufficient in this case to only run gremlin server
integration tests. You should probably run the whole suite. When i run that
with docker via `docker/build.sh -t -i -n` i
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/315
@analytically we're trying to finish reviewing PRs for the upcoming release
of 3.2.1 and 3.1.3 - did you happen to see my note above?
---
If your project is set up for it, you can reply
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
I think we should try to merge this PR at this point (though we need one
more +1 - @PommeVerte do you have a moment to do a final review?). There are a
few little tweaks here and there, but I
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/356
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
This change is largely to help the consumption of GraphSON by non-JVM
languages. Since I'm largely familiar with the behaviors of java based parsers
and such, i'm not a good judge of that so i
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/352
nice find @robertdale - i pushed a fix that removed that assert. that whole
test case is deprecated anyway, so i'm not too worried about it.
@ramzioueslati care to pull the branch
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/375
hey @joshsh - wowtotally missed all those. this would have all bit me
on release day so thanks for that.
can i ask that you please retarget your pull request for the tp31 branch
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/376
Thanks for re-targeting @joshsh - you definitely saved me some troubles on
release day - merged via CTR
---
If your project is set up for it, you can reply to this email and have your
reply
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/373
Rebased and force pushed to resolve conflicts on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/367
Rebased and force pushed to resolve merge conflicts on tp31. merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/367
TINKERPOP-1350 was never quite fixed in 3.1.3.
Unfortunately, more testing revealed that the fix for the problem was only
masked by the changes in 3.1.3.
Changed response encoding
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/368
merged via CTR - thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/346
no need to start over - maybe not an issue. i'll see what happens when i
merge. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/346
You could just use `git rebase` to update your branch rather than `git
merge` - in that way the commit history doesn't get weird.
---
If your project is set up for it, you can reply
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/342
@dkuppitz I'd forgotten to implement that change you suggested on this one
- all done now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/346
@robertdale when we get the final vote for this PR to be merged, i expect
to merge it to tp31 and then master as I'd like the 3.1.x line of code to get
this fix. i only mention this because i
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
yeah - we tend to bump heads on master a little bit on the CHANGELOG - not
a big deal - i can resolve that conflict when the time comes.
---
If your project is set up for it, you can reply
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/352
@robertdale i think i fixed the problem. i've been hunting that issue
forever, but have never been able to witness it with any kind of consistent
nature to unravel the problem. i guess my
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/352
wow - now this one is failing:
```text
GremlinDriverIntegrateTest.shouldBeThreadSafeToUseOneClient:994
```
only fails when run in maven - works in intellij on its own
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69272477
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69287612
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69279953
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/352
Just pushed what I think is the final fixes for this issue. Note that this
branch also contains the fix for
https://issues.apache.org/jira/browse/TINKERPOP-1351
Please feel
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69308786
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/352
nice @robertdale - thanks for taking the time to review. always a big help
when folks look over the PRs and provide feedback.
---
If your project is set up for it, you can reply to this email
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Note that travis isn't happy - tests are failing:
```text
Failed tests:
GraphSONMessageSerializerV2d0Test.shouldSerializeToJsonIteratorNullElement:147
expected:<
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68931920
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONIo.java
---
@@ -22,11 +22,7 @@
import
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
I thought that java integer would be implied. I believe that if we wrote a
java short for example it would type to a "Short" then you would know what kind
of number it is.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r69315539
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
imo, I think that if we document GraphSON this way, there should not be too
much confusion as to how the type system works.
---
If your project is set up for it, you can reply to this email
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
If i understand right: Serializing integer without a type tag would result
in integer. You would have to specify "Long" as the type for it to be
interpreted as a Lo
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
> 1. A type is not a class. Call types 'type' or '@type' (not clear the @
is necessary since it's in the metadata payload anyway); Not @class. (Otherwise
be consistent and rename all the T
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Just for reference:
https://groups.google.com/d/msg/gremlin-users/R7qQbJXWcH8/wK9ZuWADAwAJ
---
If your project is set up for it, you can reply to this email and have your
reply
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/352
uh - i wasn't aware of any kerberos setup required. does that happen
consistently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68940083
--- Diff:
tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/IoDataGenerationTest.java
---
@@ -275,4 +290,78 @@ else
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68936696
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ser/GraphSONMessageSerializerV2d0Test.java
---
@@ -0,0 +1,474
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/351#discussion_r68934451
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONMapper.java
---
@@ -60,47 +61,78 @@
private
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/380
TINKERPOP-1402 Added IoBuilder.onMapper() method.
https://issues.apache.org/jira/browse/TINKERPOP-1402
Deprecated IoBuilder.registry() in the process of doing that. This should
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/379
Build failure in travis is due to rat checks - new
websocket_remote_connection.py needs apache license header
---
If your project is set up for it, you can reply to this email and have your
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/534
sorry - i was good with whatever @mike-tr-adamson was down for. he
originally brought in the sasl stuff for tinkerpop, so i was glad he could take
a moment to review and comment
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/548
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/543
This was a pretty simple change - I merged via CTR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/544
wow - can't believe we had the package wrong. can you please edit the pull
request and retarget it to the `tp32` branch?
---
If your project is set up for it, you can reply to this email
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/541
For some reason I thought it was necessary still, but as I think about it
this morning it doesn't seem to be the case - removed.
---
If your project is set up for it, you can reply
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/536#discussion_r97580891
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
---
@@ -105,7 +106,13
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/552
I don't know why that was like that. Don't think we had any reason to
include tests that i can think of. Could you please re-target the pull request
at the tp32 branch?
---
If your project
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/548
I'm pretty sure @okram was affirming that `VertexStep`, `EdgeVertexStep`
and `PropertiesStep` should implement `AutoCloseable` (I don't think that there
are others) rather than a blanket
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/551
did a quick build with `mvn clean install` and everything passes. if
@davebshow is cool with this at this point after the his request change, then
VOTE +1
---
If your project is set up
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/551
I'll go ahead and get this merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/534
Well - looks like they are still broken. My favorite situation - they fail
with maven but pass in intellij. I suppose that has something to do with your
explanation regarding the classpath
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/550
Thanks for this. Could you please edit your pull request at the tp32 branch
so that we can apply this changed to 3.2.4?
---
If your project is set up for it, you can reply to this email
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/551
excellent - thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/548
tests all pass with docker so that's good.
@okram would you prefer to not see this change made to `FlatMapStep` and
instead see it implemented specifically in steps that interact
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/548
ha - "makes sense" that the way it is now is ok or "makes sense" as with
the change i proposed? :smile:
---
If your project is set up for it, you can reply to this email
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/534
ooo - well noted @robertdale - i'm fine with getting that added to
`TraversalOpProcessor` at a later date, but it shouldn't be forgotten. maybe
i'll just add that in when i go to merge
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/534
ok @vtslab i won't do the work on merge then. i'm fine with letting it
happen with the gremlin-python work.
---
If your project is set up for it, you can reply to this email and have your
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/554#discussion_r102272018
--- Diff: CHANGELOG.asciidoc ---
@@ -29,6 +29,11 @@ TinkerPop 3.2.5 (Release Date: NOT OFFICIALLY RELEASED
YET)
* Refactor `SparkContext` handler
1 - 100 of 1182 matches
Mail list logo
