[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-17 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 Thanks @spmallette I'll hold off on any more changes until things are worked out with that DISCUSS thread ---

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-16 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/838 > I'll take a swing at the js and .net stuff and see how that plays out for now. i meant to mention this in my last post but forgotjust a suggestion but you might want to wait a

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-16 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/838 Sorry, but I haven't had time to dig into this into any great detail. Hopefully, sometime this week. Here's some quick comments based on the discussion: > I actually think we should

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-15 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 @mpollmeier I was running `mvn clean install` locally, and had the same issue with that test stalling out. A few builds before this had different errors in Travis, not just stalling out, so it

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-13 Thread mpollmeier
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/838 If I run `mvn clean test` I also get heaps of compilation errors, but that's the same with master for me. E.g. ``` [ERROR] symbol: class JsonGenerator [ERROR] location: class

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-13 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/838 Look at the Serializers in `./gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/` ---

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-13 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 I'm definitely still missing something around serialization. All of the traversals that are failing in the gryo side of things work in the console. I'm fairly unfamiliar with that part of the

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...

2018-04-13 Thread krlohnes
Github user krlohnes commented on the issue: https://github.com/apache/tinkerpop/pull/838 I figured out the errors that I was getting with serialization. I think I just missed registering `SearchAlgo` in a spots. I have some legitimate test failures now I think, which makes fixing