svn commit: r388091 - /tomcat/connectors/trunk/jni/native/src/poll.c

2006-03-22 Thread mturk
Author: mturk Date: Wed Mar 22 23:56:28 2006 New Revision: 388091 URL: http://svn.apache.org/viewcvs?rev=388091&view=rev Log: Use array region routines instead copying entire poller result set array. It can save few CPU cycles. Modified: tomcat/connectors/trunk/jni/native/src/poll.c Modified

svn commit: r388090 - in /tomcat/connectors/trunk/jni/native/os/win32: ntpipe.c registry.c system.c

2006-03-22 Thread mturk
Author: mturk Date: Wed Mar 22 23:53:24 2006 New Revision: 388090 URL: http://svn.apache.org/viewcvs?rev=388090&view=rev Log: Fix compile time warning if _WIN32_WINNT is defined in command line. Modified: tomcat/connectors/trunk/jni/native/os/win32/ntpipe.c tomcat/connectors/trunk/jni/nat

svn commit: r388027 - in /tomcat/container/tc5.5.x/modules: groupcom/src/share/org/apache/catalina/tribes/tipis/ ha/src/share/org/apache/catalina/ha/session/

2006-03-22 Thread fhanik
Author: fhanik Date: Wed Mar 22 20:20:42 2006 New Revision: 388027 URL: http://svn.apache.org/viewcvs?rev=388027&view=rev Log: slowly getting somewhere Modified: tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java tomcat/contai

svn commit: r388020 - in /tomcat/container/tc5.5.x/modules: groupcom/src/share/org/apache/catalina/tribes/ groupcom/src/share/org/apache/catalina/tribes/group/ groupcom/src/share/org/apache/catalina/t

2006-03-22 Thread fhanik
Author: fhanik Date: Wed Mar 22 19:59:38 2006 New Revision: 388020 URL: http://svn.apache.org/viewcvs?rev=388020&view=rev Log: more complete state of the replicated map Modified: tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/Member.java tomcat/container/

DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39061] - Cannot undeploy application due to javax.crypto.Cipher

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: could we add a way to disable APR attempts?

2006-03-22 Thread Filip Hanik - Dev Lists
lemme try, Yoav Shapira wrote: I thought we could already disable it by just using a non-APR connector class name? Yoav On 3/22/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: when loading a up a JNI profiler, the code freaks out, and the server is unable to start. If I could disabl

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Yoav Shapira
Yeah, new patch looks good. I'd add a logging statement to the simple stack trace so that people looking at the log can have a hint if this error actually occurs. Yoav On 3/22/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > patch looks good to me, +1, > if no objections arise, then I ca

Re: could we add a way to disable APR attempts?

2006-03-22 Thread Yoav Shapira
I thought we could already disable it by just using a non-APR connector class name? Yoav On 3/22/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > when loading a up a JNI profiler, the code freaks out, and the server is > unable to start. > If I could disable APR in the connector string in

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Filip Hanik - Dev Lists
patch looks good to me, +1, if no objections arise, then I can submit, we'll wait until end of week. Filip http://issues.apache.org/bugzilla/attachment.cgi?id=17944 Haroon Rafique wrote: On Today at 2:47pm, HR=>Haroon Rafique <[EMAIL PROTECTED]> wrote: HR> HR> Patch 17943 submitted on bugz

could we add a way to disable APR attempts?

2006-03-22 Thread Filip Hanik - Dev Lists
when loading a up a JNI profiler, the code freaks out, and the server is unable to start. If I could disable APR in the connector string in the server.xml, I could work around this through configurations. Filip Exception in thread "main" java.lang.reflect.InvocationTargetException at su

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 2:47pm, HR=>Haroon Rafique <[EMAIL PROTECTED]> wrote: HR> HR> Patch 17943 submitted on bugzilla 36847. That should read Patch 17944. My mistake. -- Haroon Rafique <[EMAIL PROTECTED]> - To unsubscribe, e-mail: [EMAI

DO NOT REPLY [Bug 36847] - [Patch] ZipException when using "tag" in deploy ant task

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 1:07pm, FHDL=>Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: FHDL> FHDL> exactly, this or a better fix: do this check inside the copy method. FHDL> FHDL> BASE vs HOME was just an example of a scenario that you didn't think FHDL> about, there are many more. so a patch should not

DO NOT REPLY [Bug 36847] - [Patch] ZipException when using "tag" in deploy ant task

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Filip Hanik - Dev Lists
Haroon Rafique wrote: Replace: copy(localWar, new File(getAppBase(), basename + ".war")); with: File secondCopy = new File(getAppBase(), basename + ".war"); if( !localWar.getCanonicalPath().equals(secondCopy.getCanonicalPath()) ) { copy(localWar, secondCopy); } exactly, this or a be

DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Yoav Shapira
Hola, > As you can clearly see, BASE and HOME are different (and before you ask, > neither one of them is a symlink :-)) > > So, I modified ManagerServlet to show some debug output before the 1st > copy, inserted a Thread.sleep() in the middle and some more debug output > before the 2nd copy. Here

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 12:11pm, YS=>Yoav Shapira <[EMAIL PROTECTED]> wrote: YS> [..snip..] YS> YS> If you want to submit a more precise patch, i.e. one that checks for YS> the tag usage and then only circumvents copies if the two files are YS> indeed the same exact path (taking symlinks and catalina_base

DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 12:11pm, YS=>Yoav Shapira <[EMAIL PROTECTED]> wrote: YS> [..snip..] YS> YS> You can call it paranoia if you wish, but I prefer caution. I'm not YS> about to go remove a line code in an important component that we know YS> is used in several paths through the code (corresponding to

DO NOT REPLY [Bug 36847] - [Patch] ZipException when using "tag" in deploy ant task

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Yoav Shapira
Hola, > False information??? you guys are pretty paranoid. I explained clearly > that /www/tomcat is a symlink to /www/apache-tomcat-5.5.16. You can call it paranoia if you wish, but I prefer caution. I'm not about to go remove a line code in an important component that we know is used in severa

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 10:45am, FHDL=>Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: FHDL> There are scenarios where CATALINA_BASE is different from FHDL> CATALINA_HOME, and not different as in symlinked, different as in FHDL> two different directories. FHDL> Thanks, now I'm beginning to understand t

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Filip Hanik - Dev Lists
that doesn't change the flaw of the patch, if there are scenarios where the paths indeed are different, then you need to answer the following questions: 1. What are those scenarios 2. And is the code correct in those scenarios otherwise, I would change your patch to just fix the copy method, t

svn commit: r387887 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

2006-03-22 Thread remm
Author: remm Date: Wed Mar 22 08:36:13 2006 New Revision: 387887 URL: http://svn.apache.org/viewcvs?rev=387887&view=rev Log: - Woops, fix sizes being used. Modified: tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/connectors/trunk/util/java/or

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 10:15am, YS=>Yoav Shapira <[EMAIL PROTECTED]> wrote: YS> Hola, YS> YS> Hi, YS> YS> [..snip..] YS> YS> How would this be different in the case where CATALINA_BASE is not the YS> same as CATALINA_HOME? YS> I don't know. My guess would be that CATALINA_BASE would contain the up

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 9:29am, FHDL=>Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: FHDL> Haroon Rafique wrote: FHDL> >/www/apache-tomcat-5.5.16/webapps/sws.war FHDL> >/www/tomcat/webapps/sws.war FHDL> FHDL> this would turn my vote into -1, based on false information provided FHDL> earlier. FHDL> That s

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Filip Hanik - Dev Lists
Haroon Rafique wrote: /www/apache-tomcat-5.5.16/webapps/sws.war /www/tomcat/webapps/sws.war this would turn my vote into -1, based on false information provided earlier. That should be explanation enough. Haroon, you'd need to provide a more solid test case, if the paths indeed are differen

DO NOT REPLY [Bug 39061] New: - Cannot undeploy application due to javax.crypto.Cipher

2006-03-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Yoav Shapira
Hola, > Gotta be careful here. When I said the 2 paths are same, I generalized a > little bit. The two paths are almost the same. They are: > > /www/apache-tomcat-5.5.16/webapps/sws.war > /www/tomcat/webapps/sws.war > > One of them involves a symlink. They are the same as long as you consider > t

svn commit: r387872 - in /tomcat/container/tc5.5.x/modules: groupcom/src/share/org/apache/catalina/tribes/io/ groupcom/src/share/org/apache/catalina/tribes/tipis/ ha/src/share/org/apache/catalina/ha/s

2006-03-22 Thread fhanik
Author: fhanik Date: Wed Mar 22 07:14:44 2006 New Revision: 387872 URL: http://svn.apache.org/viewcvs?rev=387872&view=rev Log: ok, we finally got control of it, fully working now Modified: tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/io/ReplicationStream.jav

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Haroon Rafique
On Today at 11:06am, RM=>Reinhard Moosauer <[EMAIL PROTECTED]> wrote: RM> Hi Filip, Haroon, RM> RM> as far as I understand, the problem is a copy operation which copies one file RM> on itself. RM> Haroon showed that this is happing in his case. RM> Unfortunately, it it not proved that this is h

svn commit: r387838 - in /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net: AprEndpoint.java res/LocalStrings.properties

2006-03-22 Thread remm
Author: remm Date: Wed Mar 22 03:30:42 2006 New Revision: 387838 URL: http://svn.apache.org/viewcvs?rev=387838&view=rev Log: - New defaults, which should be more production friendly. - New (cleaner) way of allocating pollers (note: the 62 size is there because it was an older Win32 limitation i

svn commit: r387833 - /tomcat/connectors/trunk/jk/java/org/apache/coyote/ajp/Constants.java

2006-03-22 Thread remm
Author: remm Date: Wed Mar 22 03:21:43 2006 New Revision: 387833 URL: http://svn.apache.org/viewcvs?rev=387833&view=rev Log: - Unless I missed something, I think it's better to use -1 here rather than 0. Modified: tomcat/connectors/trunk/jk/java/org/apache/coyote/ajp/Constants.java Modified:

svn commit: r387832 - in /tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11: Http11AprProtocol.java Http11BaseProtocol.java

2006-03-22 Thread remm
Author: remm Date: Wed Mar 22 03:20:25 2006 New Revision: 387832 URL: http://svn.apache.org/viewcvs?rev=387832&view=rev Log: - Modify the read default to 8KB (thanks IE). Modified: tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProtocol.java tomcat/connectors/

Re: yet another tomcat goes stable and I still have to make a custom package

2006-03-22 Thread Reinhard Moosauer
Hi Filip, Haroon, as far as I understand, the problem is a copy operation which copies one file on itself. Haroon showed that this is happing in his case. Unfortunately, it it not proved that this is happening in all cases. Furthermore, the removal of the second copy operation could still cause