Re: svn commit: r389946 [3/5] - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java

2006-03-30 Thread Rainer Jung
Hi Remy, I saw you taking over classes from commons modeler into tc 6. Just yesterday William Barker commited a very small and non-risky patch I submitted two years ago to bugzilla against Registry.convertValue(): http://issues.apache.org/bugzilla/show_bug.cgi?id=31608 The method has

svn commit: r390055 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/modeler/Registry.java

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 02:00:57 2006 New Revision: 390055 URL: http://svn.apache.org/viewcvs?rev=390055view=rev Log: - Add missing patch (I didn't update from sources before merging). Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/modeler/Registry.java Modified:

DO NOT REPLY [Bug 39149] - Missing files in Tomcat 5.5.16 distribution

2006-03-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39149. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

svn commit: r390120 - /tomcat/tc6.0.x/trunk/.classpath

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 05:27:59 2006 New Revision: 390120 URL: http://svn.apache.org/viewcvs?rev=390120view=rev Log: - Remove modeler. - Fix CRLF. Modified: tomcat/tc6.0.x/trunk/.classpath Modified: tomcat/tc6.0.x/trunk/.classpath URL:

svn commit: r390124 - /tomcat/tc6.0.x/trunk/.classpath

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 05:32:04 2006 New Revision: 390124 URL: http://svn.apache.org/viewcvs?rev=390124view=rev Log: - Move output so that Eclipse doesn't pollute the useful classes folder with his junk. Modified: tomcat/tc6.0.x/trunk/.classpath Modified:

Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Remy Maucherat
Costin Manolache wrote: You could easily remove them from your tree. Do you have any valid reason to no longer have the files ? I remember for 4.x people felt they were usefull. I'm not sure 'I can't ignore them easily' or 'I don't need them' is a real -1 reason. ( and by 'I'll remove them from

DO NOT REPLY [Bug 39149] - Missing files in Tomcat 5.5.16 distribution

2006-03-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39149. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

svn commit: r390144 - /tomcat/connectors/trunk/jni/native/src/network.c

2006-03-30 Thread mturk
Author: mturk Date: Thu Mar 30 06:25:42 2006 New Revision: 390144 URL: http://svn.apache.org/viewcvs?rev=390144view=rev Log: Fix sprintf formating warnings. Modified: tomcat/connectors/trunk/jni/native/src/network.c Modified: tomcat/connectors/trunk/jni/native/src/network.c URL:

svn commit: r390147 - /tomcat/connectors/trunk/jni/native/src/network.c

2006-03-30 Thread mturk
Author: mturk Date: Thu Mar 30 06:32:04 2006 New Revision: 390147 URL: http://svn.apache.org/viewcvs?rev=390147view=rev Log: Copy/paste error. Remove extra format. Modified: tomcat/connectors/trunk/jni/native/src/network.c Modified: tomcat/connectors/trunk/jni/native/src/network.c URL:

svn commit: r390155 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsDigesterSource.java

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 07:08:31 2006 New Revision: 390155 URL: http://svn.apache.org/viewcvs?rev=390155view=rev Log: - Clean up a bit. - For some reason, trying to recycle a static digester doesn't improve performance. Modified:

svn commit: r390157 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/modeler/Registry.java

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 07:10:13 2006 New Revision: 390157 URL: http://svn.apache.org/viewcvs?rev=390157view=rev Log: - Standardize on the digester (which is apparently a bit faster than using DOM). This way, digester now handles all XML parsing in Catalina. Modified:

DO NOT REPLY [Bug 39149] - Missing files in Tomcat 5.5.16 distribution

2006-03-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39149. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Costin Manolache
On 3/30/06, Remy Maucherat [EMAIL PROTECTED] wrote: Costin Manolache wrote: You could easily remove them from your tree. Do you have any valid reason to no longer have the files ? I remember for 4.x people felt they were usefull. I'm not sure 'I can't ignore them easily' or 'I don't need

Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Remy Maucherat
Costin Manolache wrote: I was going to ask - when did our policy changed to use windows line endings ??? I was a bit annoyed to see windows ending as well, it looks bad on unix and mac. There's a config in svn for that, I think, and for some reason it's not the default. Rémy

Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Costin Manolache
I don't know about svn - but the repository itself should be in unix format, or at least that used to be the convention. I'm not the tab and line ending police - but it would be good to be consistent, it's really ugly to have files with both windows and unix line ending. Costin On 3/30/06, Remy

Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Rahul Akolkar
On 3/30/06, Remy Maucherat [EMAIL PROTECTED] wrote: Costin Manolache wrote: I was going to ask - when did our policy changed to use windows line endings ??? I was a bit annoyed to see windows ending as well, it looks bad on unix and mac. There's a config in svn for that, I think, and

Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Rahul Akolkar
On 3/30/06, Rahul Akolkar [EMAIL PROTECTED] wrote: On 3/30/06, Remy Maucherat [EMAIL PROTECTED] wrote: Costin Manolache wrote: I was going to ask - when did our policy changed to use windows line endings ??? I was a bit annoyed to see windows ending as well, it looks bad on unix

svn commit: r390187 - /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 09:40:57 2006 New Revision: 390187 URL: http://svn.apache.org/viewcvs?rev=390187view=rev Log: - Revert fix for 38113, which doesn't seem to be a bug, and appears to be causing regressions. Modified:

svn commit: r390188 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 09:41:19 2006 New Revision: 390188 URL: http://svn.apache.org/viewcvs?rev=390188view=rev Log: - Revert fix for 38113, which doesn't seem to be a bug, and appears to be causing regressions. Modified:

svn commit: r390189 - /tomcat/tc6.0.x/trunk/build.xml

2006-03-30 Thread remm
Author: remm Date: Thu Mar 30 09:42:06 2006 New Revision: 390189 URL: http://svn.apache.org/viewcvs?rev=390189view=rev Log: - Copy the XML descriptors. Modified: tomcat/tc6.0.x/trunk/build.xml Modified: tomcat/tc6.0.x/trunk/build.xml URL:

DO NOT REPLY [Bug 39130] - Hostname contains ? even if no query string exists

2006-03-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39130. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.