svn commit: r675466 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-07-10 Thread jfclere
Author: jfclere Date: Thu Jul 10 00:38:18 2008 New Revision: 675466 URL: http://svn.apache.org/viewvc?rev=675466view=rev Log: My votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: svn commit: r675340 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2008-07-10 Thread Remy Maucherat
On Wed, 2008-07-09 at 20:50 +, [EMAIL PROTECTED] wrote: Author: markt Date: Wed Jul 9 13:50:18 2008 New Revision: 675340 URL: http://svn.apache.org/viewvc?rev=675340view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285 Should look for annotations all the way up

Vicious Bug in the JSP code?

2008-07-10 Thread Quintin Beukes
Hey, Can someone please advise me on this one. I am at a total loss as to what is going on here. Since we search engine's deployed our output to be a JSP page, random pages are failing. I would literally refresh the page, and it works every time, and then suddenly, WAM. Also, not the same error

Fwd: Vicious Bug in the JSP code?

2008-07-10 Thread Quintin Beukes
Hey, Here is another one. There is 2 more that I don't see now. The 2 in the first e-mail are very common. Though I can't reproduce it on my local server. To give an idea, the loadTemplate() method does nothing more than call setAttribute(JMTemplate, this), and the do the forward(req,resp).

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Quintin Beukes
I figured it might be related to the Nio protocol I did, so I changed it to HTTP/1.1. What a surprise!! It all comes down after the JSP is invoked, so my perception is that it's related to a bug in the JSP code. Jasper? Any advice would be greatly appreciated, and I'm willing to fix it myself if

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Konstantin Kolinko
It looks like you are keeping a reference to some object (like the Request or Response, or OutputStream) and reusing it, while you should not access it outside the scope of request processing. I cannot go into details now, but all these messages and stack traces look familiar. Such questions are

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Filip Hanik - Dev Lists
here are some steps you can take 1. Start asking on the tomcat user list, most likely you have some funky flow in your app, for example, you can't do requestdispatcher.forward if you've already written data (like JSPs do behind the scenes when you use them 2. try to work out a reproducible

Re: svn commit: r675340 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2008-07-10 Thread Mark Thomas
Remy Maucherat wrote: On Wed, 2008-07-09 at 20:50 +, [EMAIL PROTECTED] wrote: Author: markt Date: Wed Jul 9 13:50:18 2008 New Revision: 675340 URL: http://svn.apache.org/viewvc?rev=675340view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285 Should look for annotations

svn commit: r675650 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 10:01:23 2008 New Revision: 675650 URL: http://svn.apache.org/viewvc?rev=675650view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42678 Only ignore docBase it it really is a subdir of appBase Patch provided by juergen Modified:

DO NOT REPLY [Bug 42678] docBase ignored even if its not a subdir of appBase

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42678 --- Comment #2 from Mark Thomas [EMAIL PROTECTED] 2008-07-10 10:04:53 PST --- The patch has been applied to trunk and proposed for 6.0.x. Sorry it took so long to get to this. -- Configure bugmail:

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Quintin Beukes
Hey, That was one of my thoughts as well, as I do keep those references, but only to make it easy when passing on, and I do this inside a synchronization block on the keeper object, at the end of which (inside a finally) I release them. Eitherway, here is some more proof that it is tomcat: I am

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Quintin Beukes
Hey, Just to clear up some of the methods that receive the request or response inside the doGet(). Firstly, WebClient.getString() public static String getString(HttpServletRequest req, String key, String theDefault) { String s = req.getParameter(key); return (s == null) ?

svn commit: r675664 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 11:20:18 2008 New Revision: 675664 URL: http://svn.apache.org/viewvc?rev=675664view=rev Log: Revert previous patch prior to applying a better one Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java Modified:

svn commit: r675667 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 11:34:22 2008 New Revision: 675667 URL: http://svn.apache.org/viewvc?rev=675667view=rev Log: Go back to the original patch. The better one didn't pan out. Sorry for the noise. Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

Re: svn commit: r675340 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2008-07-10 Thread Mark Thomas
Mark Thomas wrote: Remy Maucherat wrote: On Wed, 2008-07-09 at 20:50 +, [EMAIL PROTECTED] wrote: Author: markt Date: Wed Jul 9 13:50:18 2008 New Revision: 675340 URL: http://svn.apache.org/viewvc?rev=675340view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285 Should

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Mark Thomas
Quintin Beukes wrote: Eitherway, here is some more proof that it is tomcat: Experience suggests that the root cause will be in the application rather than in Tomcat. This issue is best debugged via the users list. In the unlikely event that the debugging shows that this is a Tomcat bug,

svn commit: r675687 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 12:15:14 2008 New Revision: 675687 URL: http://svn.apache.org/viewvc?rev=675687view=rev Log: Propose fix for 42678 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Quintin Beukes
Hey, My own experience and insight also suggests an application error. Though I spent hours trying to find one, which I couldn't (which in itself is rare for myself). I have one more question suitable for this list though. When tomcat creates an instance of ServletRequest, ie

svn commit: r675726 - /tomcat/trunk/java/org/apache/el/parser/ELParser.jjt

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 13:53:24 2008 New Revision: 675726 URL: http://svn.apache.org/viewvc?rev=675726view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42565 el ternary expression without space before colon now works Patch provided by Lucas Galfaso This is just the jjt

DO NOT REPLY [Bug 42565] jsp / expression language ternary expression without space before colon stopped working

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42565 --- Comment #13 from Mark Thomas [EMAIL PROTECTED] 2008-07-10 14:00:15 PST --- Many thanks for the patch. It has been applied to trunk and proposed for 6.0.x -- Configure bugmail:

DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 Dan Armbrust [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED]

svn commit: r675739 - in /tomcat/trunk/java/org/apache/el/parser: ELParser.java ELParserConstants.java ELParserTokenManager.java

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 14:05:35 2008 New Revision: 675739 URL: http://svn.apache.org/viewvc?rev=675739view=rev Log: Auto-generated changes as a result of http://svn.apache.org/viewvc?rev=675726view=rev Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java

svn commit: r675751 - /tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 14:11:16 2008 New Revision: 675751 URL: http://svn.apache.org/viewvc?rev=675751view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42722 Possible NPE in CGIServlet.java Patch provided by Nils Hammar Modified:

svn commit: r675758 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 14:13:36 2008 New Revision: 675758 URL: http://svn.apache.org/viewvc?rev=675758view=rev Log: Couple more proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 --- Comment #28 from Mark Thomas [EMAIL PROTECTED] 2008-07-10 14:20:15 PST --- If you must rant, go do it on the Sun bug tracker. If you want to do something productive, create an enhancement request in JIRA for commons daemon to

DO NOT REPLY [Bug 42722] Potential NullPointerException in org.apache. catalina.servlets.CGIServlet

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42722 --- Comment #1 from Mark Thomas [EMAIL PROTECTED] 2008-07-10 14:21:00 PST --- Thanks for the patch. A version of it has been applied to trunk and proposed for 6.0.x -- Configure bugmail:

DO NOT REPLY [Bug 42722] Potential NullPointerException in org.apache. catalina.servlets.CGIServlet

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42722 Will Rowe [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 42722] Potential NullPointerException in org.apache. catalina.servlets.CGIServlet

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42722 Mark Thomas [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED

DO NOT REPLY [Bug 42722] Potential NullPointerException in org.apache. catalina.servlets.CGIServlet

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42722 --- Comment #4 from Will Rowe [EMAIL PROTECTED] 2008-07-10 14:48:23 PST --- Glad this was reopened, and entirely unsure of what bugzilla or firefox just did to me :) Thanks again Nils for this fix -- Configure bugmail:

DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6

2008-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 --- Comment #29 from Will Rowe [EMAIL PROTECTED] 2008-07-10 14:49:37 PST --- As Mark points out, this is a JAVA bug. It's contingent on the Sun Java installer to provide msvcr71. This is *NOT* a system library (msvcrt.dll is). In

svn commit: r675788 - in /tomcat: container/tc5.5.x/webapps/docs/config/project.xml container/tc5.5.x/webapps/docs/config/systemprops.xml container/tc5.5.x/webapps/docs/tomcat-docs.xsl current/tc5.5.x

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 15:27:41 2008 New Revision: 675788 URL: http://svn.apache.org/viewvc?rev=675788view=rev Log: Apply a pure doc patch. (I need this for another patch I am working on). Added: tomcat/container/tc5.5.x/webapps/docs/config/systemprops.xml (with props) Modified:

svn commit: r675796 - /tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 16:00:31 2008 New Revision: 675796 URL: http://svn.apache.org/viewvc?rev=675796view=rev Log: Startup fails with security enabled Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Modified:

svn commit: r675800 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-07-10 Thread markt
Author: markt Date: Thu Jul 10 16:02:54 2008 New Revision: 675800 URL: http://svn.apache.org/viewvc?rev=675800view=rev Log: Propose fix for running under security manager Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: