svn commit: r1099374 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 08:48:26 2011 New Revision: 1099374 URL: http://svn.apache.org/viewvc?rev=1099374view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51136 Provide methods that enable the name of a Context on Context creation when using Tomcat in an embedded

DO NOT REPLY [Bug 51136] Allow to set the context name through Tomcat's embeded class before adding it to the host

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51136 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 51147] Deploy from Manager fail in 403

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 Alexis Hassler alexis.hass...@sewatech.fr changed: What|Removed |Added Status|RESOLVED

DO NOT REPLY [Bug 51124] ArrayIndexOutOfBoundsException after setting org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 --- Comment #1 from Ramiro ram...@conductiva.com 2011-05-04 09:39:28 UTC --- Created attachment 26956 -- https://issues.apache.org/bugzilla/attachment.cgi?id=26956 patch for BodyContentImpl class of trunk We are reproducing this problem

DO NOT REPLY [Bug 51124] ArrayIndexOutOfBoundsException after setting org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 Ramiro ram...@conductiva.com changed: What|Removed |Added CC|

DO NOT REPLY [Bug 51147] Deploy from Manager fail in 403

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 --- Comment #3 from Alexis Hassler alexis.hass...@sewatech.fr 2011-05-04 09:51:50 UTC --- Created attachment 26957 -- https://issues.apache.org/bugzilla/attachment.cgi?id=26957 Proposed patch -- Configure bugmail:

svn commit: r1099394 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 10:14:19 2011 New Revision: 1099394 URL: http://svn.apache.org/viewvc?rev=1099394view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51135 Fix auto-detection of JAVA_HOME for 64-bit Windows platforms that only have a 32-bit JVM installed.

DO NOT REPLY [Bug 51135] [Windows installer] Autoselect 32-bit JRE on 64-bit systems if 64-bit one is not available

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51135 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: svn commit: r1099394 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml

2011-05-04 Thread Konstantin Kolinko
2011/5/4 ma...@apache.org: Author: markt Date: Wed May  4 10:14:19 2011 New Revision: 1099394 URL: http://svn.apache.org/viewvc?rev=1099394view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51135 Fix auto-detection of JAVA_HOME for 64-bit Windows platforms that only have

Re: svn commit: r1099394 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml

2011-05-04 Thread Mark Thomas
On 04/05/2011 11:30, Konstantin Kolinko wrote: 2011/5/4 ma...@apache.org: Author: markt Date: Wed May 4 10:14:19 2011 New Revision: 1099394 URL: http://svn.apache.org/viewvc?rev=1099394view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51135 Fix auto-detection of

svn commit: r1099400 - /tomcat/trunk/res/tomcat.nsi

2011-05-04 Thread markt
Author: markt Date: Wed May 4 10:35:58 2011 New Revision: 1099400 URL: http://svn.apache.org/viewvc?rev=1099400view=rev Log: Blet and braces - make sure $1 is Modified: tomcat/trunk/res/tomcat.nsi Modified: tomcat/trunk/res/tomcat.nsi URL:

DO NOT REPLY [Bug 51120] Nullpointer exception in CoyoteAdapter when the Client disconnects the socket abruptly.

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51120 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: BIO performance issues

2011-05-04 Thread Konstantin Kolinko
2011/5/4 Mark Thomas ma...@apache.org: Time: 2s Activity: Group B clients connect and are added to the queue          100 threads are allocated to process the B connections          The B connections are processed and returned to the queue          100 threads are allocated to process the B

DO NOT REPLY [Bug 51106] Error page handling serves most general exeptions first

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51106 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1099415 - /tomcat/tc6.0.x/trunk/webapps/docs/realm-howto.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 11:18:09 2011 New Revision: 1099415 URL: http://svn.apache.org/viewvc?rev=1099415view=rev Log: Docs so CTR Use new role name. Align with Tomcat 7 docs. Modified: tomcat/tc6.0.x/trunk/webapps/docs/realm-howto.xml Modified:

[Tomcat Wiki] Update of PoweredBy by KrzysztofGil

2011-05-04 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The PoweredBy page has been changed by KrzysztofGil. http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=329rev2=330 --

DO NOT REPLY [Bug 51147] Deploy from Manager fail in 403

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 --- Comment #4 from Mark Thomas ma...@apache.org 2011-05-04 11:30:27 UTC --- The role name is a red herring. The Realm doc wasn't updated. The correct role is manager-gui. The docs have been corrected although the original issue (deploy

DO NOT REPLY [Bug 51147] Deploy from Manager fail in 403

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 --- Comment #5 from Mark Thomas ma...@apache.org 2011-05-04 11:34:12 UTC --- I have confirmed both the issue and that the patch fixes it. The problem is that when a form is use with GET and the action URL contains request parameters user

svn commit: r1099418 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-05-04 Thread markt
Author: markt Date: Wed May 4 11:34:25 2011 New Revision: 1099418 URL: http://svn.apache.org/viewvc?rev=1099418view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

[Tomcat Wiki] Update of PoweredBy by KonstantinKolinko

2011-05-04 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The PoweredBy page has been changed by KonstantinKolinko. The comment on this change is: Restore list formatting after r330, remove obsolete links..

Re: BIO performance issues

2011-05-04 Thread Mark Thomas
On 04/05/2011 12:04, Konstantin Kolinko wrote: I do not quite get what happens in 6s. My first understanding from reading the scenario was that the threads at 2s are busy because we need them to process keep-alive connections. Then I see that at 6s keep-alive connections are in the Queue.

DO NOT REPLY [Bug 51147] Deploy from Manager fail in 403

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 --- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com 2011-05-04 12:29:17 UTC --- (In reply to comment #5) The problem is that when a form is use with GET and the action URL contains request parameters user agents may (FF4 does)

svn commit: r1099432 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-05-04 Thread kkolinko
Author: kkolinko Date: Wed May 4 12:44:53 2011 New Revision: 1099432 URL: http://svn.apache.org/viewvc?rev=1099432view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: BIO performance issues

2011-05-04 Thread Konstantin Kolinko
2011/5/4 Mark Thomas ma...@apache.org: On 04/05/2011 12:04, Konstantin Kolinko wrote: I do not quite get what happens in 6s. My first understanding from reading the scenario was that the threads at 2s are busy because we need them to process keep-alive connections. Then I see that at 6s

DO NOT REPLY [Bug 51124] ArrayIndexOutOfBoundsException after setting org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 Rainer Jung rainer.j...@kippdata.de changed: What|Removed |Added Status|NEW |RESOLVED

Re: BIO performance issues

2011-05-04 Thread Mark Thomas
On 04/05/2011 14:03, Konstantin Kolinko wrote: 2011/5/4 Mark Thomas ma...@apache.org: On 04/05/2011 12:04, Konstantin Kolinko wrote: I do not quite get what happens in 6s. My first understanding from reading the scenario was that the threads at 2s are busy because we need them to process

DO NOT REPLY [Bug 51141] Struts 1 bean exception in JSP after upgrading from Tomcat 6.0.28

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51141 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com 2011-05-04 13:11:06 UTC --- Can you provide a simple web application that demonstrates the issue? -- Configure bugmail:

DO NOT REPLY [Bug 51124] ArrayIndexOutOfBoundsException after setting org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 Juergen juergen.schm...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: BIO performance issues

2011-05-04 Thread Tim Funk
Solution B and disabling keepalive when a threshold is reached looks to be the way to go. If people have issue with that, that's why the other connectors exist. -Tim On Tue, May 3, 2011 at 4:02 PM, Mark Thomas ma...@apache.org wrote: SNIP Solution B -- Return to the Tomcat 6

Re: BIO performance issues

2011-05-04 Thread Rainer Jung
I hope the following is not too long and confusing ... On 03.05.2011 22:02, Mark Thomas wrote: Scenario This ended up being very long, so I moved it to the end. The exact pattern of delays will vary depending on timeouts, request frequency etc. but the scenario shows an example of how

Re: BIO performance issues

2011-05-04 Thread Mark Thomas
On 04/05/2011 15:20, Rainer Jung wrote: I hope the following is not too long and confusing ... Not at all. On 03.05.2011 22:02, Mark Thomas wrote: Solution A -- NIO is designed to handle this using a poller. That isn't available to BIO so I attempted to simulate it. That generated

Re: BIO performance issues

2011-05-04 Thread Filip Hanik - Dev Lists
On 5/3/2011 2:02 PM, Mark Thomas wrote: All, Summary --- While trying to align the documentation for maxConnections with the actual implementation a couple of performance issue have been identified with the BIO connector. All bar one of these have been fixed. A fix needs to be agreed for

DO NOT REPLY [Bug 48817] Skip validation query and use JDBC API for validation

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817 --- Comment #26 from Filip Hanik fha...@apache.org 2011-05-04 15:19:09 UTC --- (In reply to comment #25) Created attachment 26955 [details] Updated [again] example implementation for Jdbc4 Validator Minor tweak to reflect on the

DO NOT REPLY [Bug 48817] Skip validation query and use JDBC API for validation

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817 --- Comment #27 from Filip Hanik fha...@apache.org 2011-05-04 15:20:13 UTC --- Please stop posting new code to this bug. This bug has been closed and marked fixed as per the original bug. Open a new bug for new bugs/features/enhancements

Re: BIO performance issues

2011-05-04 Thread Mark Thomas
On 04/05/2011 16:17, Filip Hanik - Dev Lists wrote: On 5/3/2011 2:02 PM, Mark Thomas wrote: In a similar fashion, we can also craft a test run that will yield a substantial improvement over the old implementation in throughput. So there is a test case to prove every scenario. Could you

Re: BIO performance issues

2011-05-04 Thread Filip Hanik - Dev Lists
On 5/4/2011 9:54 AM, Mark Thomas wrote: On 04/05/2011 16:17, Filip Hanik - Dev Lists wrote: On 5/3/2011 2:02 PM, Mark Thomas wrote: In a similar fashion, we can also craft a test run that will yield a substantial improvement over the old implementation in throughput. So there is a test case to

DO NOT REPLY [Bug 51106] Error page handling serves most general exeptions first

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51106 --- Comment #3 from the4yeast the4ye...@gmail.com 2011-05-04 16:41:20 UTC --- Ok, agreed. After careful investigate of the spec, I need to agree with that. However, that's just illogical to me. My bad. Solved it otherwise anyway. --

svn commit: r1099528 - /tomcat/trunk/webapps/docs/config/ajp.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 17:22:22 2011 New Revision: 1099528 URL: http://svn.apache.org/viewvc?rev=1099528view=rev Log: Note that there is a minimum value for packetSize Modified: tomcat/trunk/webapps/docs/config/ajp.xml Modified: tomcat/trunk/webapps/docs/config/ajp.xml URL:

DO NOT REPLY [Bug 51142] Offer possible resolution of StringIndexOutOfBoundsException in Request.updateCounters when AJP packetSize is too small.

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51142 Mark Thomas ma...@apache.org changed: What|Removed |Added OS/Version||All --- Comment #1

svn commit: r1099553 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 18:19:10 2011 New Revision: 1099553 URL: http://svn.apache.org/viewvc?rev=1099553view=rev Log: Make access logging more robust for 400 responses. Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

svn commit: r1099556 - in /tomcat/trunk: java/org/apache/coyote/ajp/AjpAprProcessor.java java/org/apache/coyote/ajp/AjpProcessor.java java/org/apache/coyote/ajp/LocalStrings.properties webapps/docs/ch

2011-05-04 Thread markt
Author: markt Date: Wed May 4 18:32:05 2011 New Revision: 1099556 URL: http://svn.apache.org/viewvc?rev=1099556view=rev Log: Improve handling of too large packets in AJP connectors - Explicitly check the packet size rather than waiting to see if it fails - Provide a better debug message when it

DO NOT REPLY [Bug 51142] Offer possible resolution of StringIndexOutOfBoundsException in Request.updateCounters when AJP packetSize is too small.

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51142 --- Comment #2 from Mark Thomas ma...@apache.org 2011-05-04 18:33:34 UTC --- You might want to look at r1099556 which improves the handling of this case for Tomcat 7. -- Configure bugmail:

DO NOT REPLY [Bug 51142] Offer possible resolution of StringIndexOutOfBoundsException in Request.updateCounters when AJP packetSize is too small.

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51142 --- Comment #3 from asfbugzill...@eghm.net 2011-05-04 19:31:17 UTC --- Thank-you. You saw that the exception is happening during req.updateCounters in process?

svn commit: r1099575 - in /tomcat/trunk: java/org/apache/jasper/runtime/BodyContentImpl.java webapps/docs/changelog.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 19:53:54 2011 New Revision: 1099575 URL: http://svn.apache.org/viewvc?rev=1099575view=rev Log: Re-factor to try and determine if the root cause of https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 is an OOME or something else. Modified:

DO NOT REPLY [Bug 51124] ArrayIndexOutOfBoundsException after setting org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 --- Comment #4 from Mark Thomas ma...@apache.org 2011-05-04 19:53:39 UTC --- Hmm. Looking at case 2 above, I don't see any way for that to happen unless bufferSize cb.length. As far as I can see, these are always changed in sync. That

svn commit: r1099586 - in /tomcat/trunk: java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java webapps/docs/changelog.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 20:22:08 2011 New Revision: 1099586 URL: http://svn.apache.org/viewvc?rev=1099586view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51119 Add JAAS authentication support to the JmxRemoteLifecycleListener Patch provided by Neil Laurance Modified:

svn commit: r1099588 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-05-04 Thread markt
Author: markt Date: Wed May 4 20:23:24 2011 New Revision: 1099588 URL: http://svn.apache.org/viewvc?rev=1099588view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1099603 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-05-04 Thread kkolinko
Author: kkolinko Date: Wed May 4 20:45:27 2011 New Revision: 1099603 URL: http://svn.apache.org/viewvc?rev=1099603view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1099615 - in /tomcat/trunk: java/org/apache/catalina/authenticator/LocalStrings.properties java/org/apache/catalina/authenticator/SpnegoAuthenticator.java webapps/docs/changelog.xml

2011-05-04 Thread markt
Author: markt Date: Wed May 4 21:47:09 2011 New Revision: 1099615 URL: http://svn.apache.org/viewvc?rev=1099615view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51099 Get loginConfigName working with non-default values Patch by fhanik (plus some minor code clean-up) Modified:

DO NOT REPLY [Bug 51099] SPNEGO loginConfigName does not work

2011-05-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51099 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED