Bug report for Tomcat 7 [2011/06/05]

2011-06-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2011/06/05]

2011-06-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2011/06/05]

2011-06-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2011/06/05]

2011-06-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 5 [2011/06/05]

2011-06-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2011/06/05]

2011-06-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2011/06/05]

2011-06-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

svn commit: r1132217 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 09:02:48 2011 New Revision: 1132217 URL: http://svn.apache.org/viewvc?rev=1132217view=rev Log: Start to align the parseHost method across the Http11 processors Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

svn commit: r1132356 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 09:43:55 2011 New Revision: 1132356 URL: http://svn.apache.org/viewvc?rev=1132356view=rev Log: Fully align parseHost - remove unnecessary code from BIO - improve comment for all Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

svn commit: r1132360 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 10:03:50 2011 New Revision: 1132360 URL: http://svn.apache.org/viewvc?rev=1132360view=rev Log: Removed ssl attribute from NIO and APR to align with BIO Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

svn commit: r1132361 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 10:04:18 2011 New Revision: 1132361 URL: http://svn.apache.org/viewvc?rev=1132361view=rev Log: Align ssl test in parseHost in BIO and NIO APR Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Modified:

svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 10:06:49 2011 New Revision: 1132362 URL: http://svn.apache.org/viewvc?rev=1132362view=rev Log: Pull up parseHost Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

svn commit: r1132364 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 10:14:15 2011 New Revision: 1132364 URL: http://svn.apache.org/viewvc?rev=1132364view=rev Log: Reformat - no functional change. Just to aid comparison Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

svn commit: r1132367 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 10:21:25 2011 New Revision: 1132367 URL: http://svn.apache.org/viewvc?rev=1132367view=rev Log: Correctly handle range requests when using sendfile and the APR/native HTTP connector. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

svn commit: r1132375 - /tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 12:08:36 2011 New Revision: 1132375 URL: http://svn.apache.org/viewvc?rev=1132375view=rev Log: Remove duplicated code Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java Modified:

svn commit: r1132381 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProtocol.java Http11NioProtocol.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 12:20:42 2011 New Revision: 1132381 URL: http://svn.apache.org/viewvc?rev=1132381view=rev Log: Consistent visibility with BIO Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java

svn commit: r1132383 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProtocol.java Http11NioProtocol.java Http11Protocol.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 12:33:29 2011 New Revision: 1132383 URL: http://svn.apache.org/viewvc?rev=1132383view=rev Log: Align some of the code between the connection handlers. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java

svn commit: r1132385 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java AbstractProtocolHandler.java ajp/AbstractAjpProtocol.java http11/AbstractHttp11Protocol.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 12:36:25 2011 New Revision: 1132385 URL: http://svn.apache.org/viewvc?rev=1132385view=rev Log: Rename for consistency Added: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java - copied, changed from r1131258,

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Rainer Jung
Hi Mark, On 05.06.2011 12:06, ma...@apache.org wrote: Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=1132362r1=1132361r2=1132362view=diff

svn commit: r1132397 - in /tomcat/trunk/java/org/apache/coyote: AbstractProcessor.java ajp/AbstractAjpProcessor.java http11/AbstractHttp11Processor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 13:16:02 2011 New Revision: 1132397 URL: http://svn.apache.org/viewvc?rev=1132397view=rev Log: Pull up the request and response objects since they are common between AJP and HTTP Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Mark Thomas
On 05/06/2011 14:09, Rainer Jung wrote: On 05.06.2011 12:06, ma...@apache.org wrote: Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java URL:

svn commit: r1132404 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 13:40:57 2011 New Revision: 1132404 URL: http://svn.apache.org/viewvc?rev=1132404view=rev Log: Create an AbstactConnectionHandler and pull up the common JMX code from the AJP and HTTP connectors Modified:

svn commit: r1132433 - /tomcat/trunk/java/org/apache/tomcat/util/scan/Jar.java

2011-06-05 Thread rjung
Author: rjung Date: Sun Jun 5 15:11:34 2011 New Revision: 1132433 URL: http://svn.apache.org/viewvc?rev=1132433view=rev Log: Fix Javadoc. Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/Jar.java Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/Jar.java URL:

svn commit: r1132451 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java ajp/AjpAprProtocol.java ajp/AjpNioProtocol.java ajp/AjpProtocol.java http11/Http11AprProtocol.java http11/Http11Ni

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 16:32:31 2011 New Revision: 1132451 URL: http://svn.apache.org/viewvc?rev=1132451view=rev Log: Create a new RecycledProcessors inner class and use it in the Processor implementations rather than redefining the same thing 6 times. Modified:

Re: [VOTE] Release Apache Tomcat 7.0.15

2011-06-05 Thread Rainer Jung
Not a vote yet: I get a test failure: Testcase: testWelcomeFileStrict took 0.005 sec Caused an ERROR Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. junit.framework.AssertionFailedError: Forked Java VM exited abnormally.

Re: [VOTE] Release Apache Tomcat 7.0.15

2011-06-05 Thread Rainer Jung
Not a vote yet: I get a test failure: Testcase: testWelcomeFileStrict took 0.005 sec Caused an ERROR Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. junit.framework.AssertionFailedError: Forked Java VM exited abnormally.

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Rainer Jung
+for (int i = valueL - 1; i colonPos; i--) { +int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including a-f, A-F) are allowed in port numbers? I know you only moved that code, but it reminded me of an observation I made long ago

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Mark Thomas
On 05/06/2011 17:47, Rainer Jung wrote: +for (int i = valueL - 1; i colonPos; i--) { +int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including a-f, A-F) are allowed in port numbers? I know you only moved that code, but it reminded

svn commit: r1132487 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 20:26:37 2011 New Revision: 1132487 URL: http://svn.apache.org/viewvc?rev=1132487view=rev Log: Parse port as base10, not hex Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java tomcat/trunk/webapps/docs/changelog.xml Modified:

DO NOT REPLY [Bug 51326] New: [Patch] allow session_path and session_cookie as extension attribute

2011-06-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51326 Bug #: 51326 Summary: [Patch] allow session_path and session_cookie as extension attribute Product: Tomcat Connectors Version: unspecified Platform: All

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Konstantin Kolinko
2011/6/6 Mark Thomas ma...@apache.org: On 05/06/2011 17:47, Rainer Jung wrote: +            for (int i = valueL - 1; i colonPos; i--) { +                int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including a-f, A-F) are allowed in port numbers? Probably