Re: SPDY support

2012-02-14 Thread Costin Manolache
Uploaded another take. This time I'm just adding https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java which is just a Handler - like AjpConnectionHandler, Http11ConnectionHandler. I believe this is as close to Endpoint intent as it can be - given this is

svn commit: r1244302 - in /tomcat/trunk: build.xml java/org/apache/tomcat/buildutil/CheckEol.java

2012-02-14 Thread kkolinko
Author: kkolinko Date: Wed Feb 15 01:39:55 2012 New Revision: 1244302 URL: http://svn.apache.org/viewvc?rev=1244302&view=rev Log: Implement check for correct end-of-line characters in the source files. I plan to add it as a separate task in Gump. Running it on Windows currently shows 11 problem fi

JNDIRealm performance

2012-02-14 Thread Konstantin Kolinko
Hi! I wonder whether anyone experienced problems with performance of JNDIRealm. In essence it opens a single connection (this.context) which is not thread-safe. Thus it has to synchronize itself whenever it performs an LDAP query. There is TODO comment, "Support connection pooling", but there i

Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 21:03, Costin Manolache wrote: > BTW - one thing that may simplify the existing code is replacing > SocketWrapper with a simple SocketWrapper, and having JIO and APR > define their own SocketWrapper - like NIO does. Worth adding to the 8.0.x TODO list. > It would also save a lot of

Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 20:47, Costin Manolache wrote: > On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > >> On 14/02/2012 08:29, Costin Manolache wrote: >>> Ok, took a bit to get the Apr polling to work and add some minimal tests. >>> >>> Please take another look - in particular to >>> >> https://git

DO NOT REPLY [Bug 52666] EL should coerce String to Integer in equals operation

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52666 David Rees changed: What|Removed |Added CC||dree...@gmail.com -- Configure bugma

DO NOT REPLY [Bug 52669] Annotation processing for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scenarios

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 --- Comment #4 from violet...@apache.org 2012-02-14 21:43:03 UTC --- Created attachment 28336 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28336 test web app -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.

DO NOT REPLY [Bug 52669] Annotation processing for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scenarios

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 --- Comment #3 from violet...@apache.org 2012-02-14 21:41:35 UTC --- Created attachment 28335 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28335 screenshot3 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.c

DO NOT REPLY [Bug 52669] Annotation processing for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scenarios

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 --- Comment #2 from violet...@apache.org 2012-02-14 21:41:01 UTC --- Created attachment 28334 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28334 screenshot2 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.c

DO NOT REPLY [Bug 52669] Annotation processing for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scenarios

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 --- Comment #1 from violet...@apache.org 2012-02-14 21:40:29 UTC --- Created attachment 28333 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28333 screenshot1 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.c

DO NOT REPLY [Bug 52669] New: Annotation processing for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scenarios

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 Bug #: 52669 Summary: Annotation processing for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scena

Re: SPDY support

2012-02-14 Thread Costin Manolache
BTW - one thing that may simplify the existing code is replacing SocketWrapper with a simple SocketWrapper, and having JIO and APR define their own SocketWrapper - like NIO does. It would also save a lot of Long->long->Long boxing. I'll try replacing Protocol/Processor with Handler, see how it lo

DO NOT REPLY [Bug 52627] Segmentation fault in org.apache.tomcat.jni.File.infoGet() native method

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52627 Ilya Maykov changed: What|Removed |Added Platform|Macintosh |All -- Configure bugmail: https://i

Re: SPDY support

2012-02-14 Thread Costin Manolache
On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > On 14/02/2012 08:29, Costin Manolache wrote: > > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > > > Please take another look - in particular to > > > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/t

svn commit: r1244187 - in /tomcat/site/trunk: docs/sitemap-main.xml docs/sitemap.xml xdocs/sitemap-main.xml xdocs/sitemap.xml

2012-02-14 Thread kkolinko
Author: kkolinko Date: Tue Feb 14 19:40:17 2012 New Revision: 1244187 URL: http://svn.apache.org/viewvc?rev=1244187&view=rev Log: Site-map: 1. Add explicit encoding header to sitemap.xml. The FAQ says that the encoding must be UTF-8. 2. Do not use priority values that are less than the default va

DO NOT REPLY [Bug 52500] Improve client certificate authentication

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52500 --- Comment #24 from Christopher Schultz 2012-02-14 17:49:48 UTC --- Michael, > >I'm not sure why either of these are necessary. > >I think that UserNameRetriever (maybe a better name > >would be X509UserNameRetriever now that I think ab

Re: Tomcat web site UI update

2012-02-14 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/02/2012 16:21, Christopher Schultz wrote: > Mark, > > On 2/13/12 5:28 PM, Mark Thomas wrote: >> On 13/02/2012 20:11, Christopher Schultz wrote: >>> >>> IIRC, Pid did a bunch of work toward that end and it was >>> ultimately vetoed >> >> Refer

Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 08:29, Costin Manolache wrote: > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > Please take another look - in particular to > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > The spdy implementation seem

Re: svn commit: r1243508 - in /tomcat/site/trunk: docs/tools.html xdocs/tools.xml

2012-02-14 Thread Christopher Schultz
Sebb, On 2/14/12 6:56 AM, sebb wrote: > However, the US seems to use license for both noun and verb. License, defense, etc. We're lazy that way. One of the first things we did was to write a new dictionary and remove the "u"s from words like colour. -chris signature.asc Description: OpenPGP d

Re: Custom rules for commons-digester

2012-02-14 Thread Christopher Schultz
Mark, On 2/13/12 5:35 PM, Mark Thomas wrote: > On 13/02/2012 22:01, Christopher Schultz wrote: >> Fair enough, but server.xml is processed only once on startup. > > They also process context.xml files and web.xml files. These are the classes I was looking at, which all seem to be related to serv

Re: Tomcat web site UI update

2012-02-14 Thread Christopher Schultz
Mark, On 2/13/12 5:28 PM, Mark Thomas wrote: > On 13/02/2012 20:11, Christopher Schultz wrote: >> >> IIRC, Pid did a bunch of work toward that end and it was >> ultimately vetoed > > Reference please. That is not my recollection at all. Markmail remembers: http://markmail.org/message/og235cbvrd

Re: SPDY support

2012-02-14 Thread Yoav Shapira
On Tue, Feb 14, 2012 at 3:29 AM, Costin Manolache wrote: > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > Please take another look - in particular to > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > The spdy implemen

DO NOT REPLY [Bug 52666] New: EL should coerce String to Integer in equals operation

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52666 Bug #: 52666 Summary: EL should coerce String to Integer in equals operation Product: Tomcat 7 Version: 7.0.25 Platform: PC OS/Version: Windows XP Status: NEW

Re: svn commit: r1243508 - in /tomcat/site/trunk: docs/tools.html xdocs/tools.xml

2012-02-14 Thread sebb
On 13 February 2012 13:50, wrote: > Author: kkolinko > Date: Mon Feb 13 13:50:43 2012 > New Revision: 1243508 > > URL: http://svn.apache.org/viewvc?rev=1243508&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52652 > Correct typos in tools.html > > s/licence/license/ seems

Re: SPDY support

2012-02-14 Thread Costin Manolache
Ok, took a bit to get the Apr polling to work and add some minimal tests. Please take another look - in particular to https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java The spdy implementation seems to work with chrome, and the client seems to work with

svn commit: r1243813 - /tomcat/tc7.0.x/trunk/modules/

2012-02-14 Thread markt
Author: markt Date: Tue Feb 14 08:01:46 2012 New Revision: 1243813 URL: http://svn.apache.org/viewvc?rev=1243813&view=rev Log: Update to pick up validation fixes and missing AL2 header Modified: tomcat/tc7.0.x/trunk/modules/ (props changed) Propchange: tomcat/tc7.0.x/trunk/modules/ ---

DO NOT REPLY [Bug 52500] Improve client certificate authentication

2012-02-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52500 --- Comment #23 from Michael 2012-02-14 08:00:19 UTC --- Dear Christopher, Thank you for the fast reply! >That looks great. Thanks! >I'm not sure why either of these are necessary. >I think that UserNameRetriever (maybe a better name

svn commit: r1243812 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/interceptor/ test/java/org/apache/tomcat/jdbc/bugs/ test/java/org/apache/tomcat/jdbc/pool/intercept

2012-02-14 Thread markt
Author: markt Date: Tue Feb 14 07:59:54 2012 New Revision: 1243812 URL: http://svn.apache.org/viewvc?rev=1243812&view=rev Log: Fix validation errors and an Eclipse warning.= Add missing AL2 header Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/