> From: Mark Thomas [mailto:ma...@apache.org]
> Subject: Re: svn commit: r1434905 -
> /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
> I did see a "no unnecessary brackets" rule that I think Chuck would love.
My favorite hate is multi-line if statements without braces. Can't count the
numb
On 17/01/2013 22:49, Christopher Schultz wrote:
> On 1/17/13 4:28 PM, Mark Thomas wrote:
>> I have Checkstyle configured in Eclipse and it nags me if it
>> finds any trailing whitespace (usually from other commits after
>> an svn up).
>
> I'll work on getting that configured, too.
You might
Mark,
On 1/17/13 4:28 PM, Mark Thomas wrote:
> On 17/01/2013 21:07, Christopher Schultz wrote:
>> Mark,
>>
>> On 1/17/13 3:41 PM, ma...@apache.org wrote:
>>> Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision:
>>> 1434905
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev Log:
Author: markt
Date: Thu Jan 17 22:23:08 2013
New Revision: 1434938
URL: http://svn.apache.org/viewvc?rev=1434938&view=rev
Log:
WebSocket
Add the plumbing to obtain references to the WebSocketContainer
Includes a test case to make sure there are no mempry leaks
Added:
tomcat/trunk/test/javax/w
https://issues.apache.org/bugzilla/show_bug.cgi?id=54448
--- Comment #1 from Violeta Georgieva ---
Created attachment 29865
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29865&action=edit
patch proposal + test
--
You are receiving this mail because:
You are the assignee for the bug
https://issues.apache.org/bugzilla/show_bug.cgi?id=54448
Bug ID: 54448
Summary: Field of primitive type, annotated with @Resource is
not recognized as env entry
Product: Tomcat 7
Version: 7.0.35
Hardware: PC
Sta
Author: markt
Date: Thu Jan 17 21:43:17 2013
New Revision: 1434927
URL: http://svn.apache.org/viewvc?rev=1434927&view=rev
Log:
Consistent naming
Added:
tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
- copied, changed from r1434921,
tomcat/trunk/java/org/apache/
On 17/01/2013 21:07, Christopher Schultz wrote:
> Mark,
>
> On 1/17/13 3:41 PM, ma...@apache.org wrote:
>> Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision:
>> 1434905
>>
>> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev Log:
>> Trailing whitespace police
>
> Do you have any id
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Subject: Re: svn commit: r1434905 -
> /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
> Do you have any idea how to get Eclipse to stop adding that crap? It's
> obviously impossible to see and running find-and-replace for trai
Author: markt
Date: Thu Jan 17 21:22:21 2013
New Revision: 1434920
URL: http://svn.apache.org/viewvc?rev=1434920&view=rev
Log:
Move POJO related classes to separate package
Added:
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/Constants.java (with
props)
tomcat/trunk/java/org/apach
Mark,
On 1/17/13 3:41 PM, ma...@apache.org wrote:
> Author: markt
> Date: Thu Jan 17 20:41:19 2013
> New Revision: 1434905
>
> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev
> Log:
> Trailing whitespace police
Do you have any idea how to get Eclipse to stop adding that crap? It's
obvious
Author: schultz
Date: Thu Jan 17 21:03:55 2013
New Revision: 1434914
URL: http://svn.apache.org/viewvc?rev=1434914&view=rev
Log:
Recording historical merges from trunk.
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
Propchange: tomcat/tc6.0.x/trunk/
---
On 17/01/2013 20:47, Christopher Schultz wrote:
> All,
>
> Due to my own negligence with merging in the past, tc6.0.x/trunk
> is missing some specific mergeinfo. While preparing a back-port
> today, I noticed that there was some old, uncommitted mergeinfo:
>
> Merged /tomcat/trunk:r1041892,104398
https://issues.apache.org/bugzilla/show_bug.cgi?id=53481
--- Comment #7 from Christopher Schultz ---
Fixed in Tomcat 6.0.x. Will be in Tomcat 6.0.37.
--
You are receiving this mail because:
You are the assignee for the bug.
-
All,
Due to my own negligence with merging in the past, tc6.0.x/trunk is
missing some specific mergeinfo. While preparing a back-port today, I
noticed that there was some old, uncommitted mergeinfo:
Merged /tomcat/trunk:r1041892,1043983,1049264
Those commits were from a while back. Shall I commi
Author: markt
Date: Thu Jan 17 20:41:59 2013
New Revision: 1434908
URL: http://svn.apache.org/viewvc?rev=1434908&view=rev
Log:
Remove old file
Removed:
tomcat/trunk/test/org/apache/tomcat/websocket/TestUriTemplate.java
-
To
Author: schultz
Date: Thu Jan 17 20:41:44 2013
New Revision: 1434907
URL: http://svn.apache.org/viewvc?rev=1434907&view=rev
Log:
Back-ported fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=53481
Enable SSLHonorCipherOrder for APR connector.
Modified:
tomcat/tc6.0.x/trunk/ (prop
Author: markt
Date: Thu Jan 17 20:41:19 2013
New Revision: 1434905
URL: http://svn.apache.org/viewvc?rev=1434905&view=rev
Log:
Trailing whitespace police
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
Modified: tomcat/trunk/java/org/apache/tomcat/jni/SSL.java
URL:
http://svn.apa
Author: markt
Date: Thu Jan 17 20:41:02 2013
New Revision: 1434904
URL: http://svn.apache.org/viewvc?rev=1434904&view=rev
Log:
Align test classes with name changes
Added:
tomcat/trunk/test/org/apache/tomcat/websocket/TestPojoUriTemplate.java
- copied, changed from r1434902,
tomcat/trun
Author: markt
Date: Thu Jan 17 20:22:20 2013
New Revision: 1434895
URL: http://svn.apache.org/viewvc?rev=1434895&view=rev
Log:
In case there is more refactoring
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Cons
Author: markt
Date: Thu Jan 17 20:21:02 2013
New Revision: 1434894
URL: http://svn.apache.org/viewvc?rev=1434894&view=rev
Log:
Create new package for holding POJO plumbing classes
Added:
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/
tomcat/trunk/java/org/apache/tomcat/websocket/pojo
Author: markt
Date: Thu Jan 17 20:19:14 2013
New Revision: 1434890
URL: http://svn.apache.org/viewvc?rev=1434890&view=rev
Log:
Rename
Added:
tomcat/trunk/java/org/apache/tomcat/websocket/PojoPathParam.java
- copied, changed from r1434878,
tomcat/trunk/java/org/apache/tomcat/websocket/P
https://issues.apache.org/bugzilla/show_bug.cgi?id=54324
Christopher Schultz changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Author: schultz
Date: Thu Jan 17 20:15:30 2013
New Revision: 1434889
URL: http://svn.apache.org/viewvc?rev=1434889&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev
Author: schultz
Date: Thu Jan 17 20:13:27 2013
New Revision: 1434887
URL: http://svn.apache.org/viewvc?rev=1434887&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54324
Allow APR connector to disable TLS compression if OpenSSL supports it.
Modified:
tomcat/tc7.0.x/trunk
Author: schultz
Date: Thu Jan 17 20:08:24 2013
New Revision: 1434884
URL: http://svn.apache.org/viewvc?rev=1434884&view=rev
Log:
Fixed mergeinfo
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
Propchange: tomcat/tc7.0.x/trunk/
---
Author: schultz
Date: Thu Jan 17 20:03:00 2013
New Revision: 1434882
URL: http://svn.apache.org/viewvc?rev=1434882&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54324
Allow APR connector to disable TLS compression if OpenSSL supports it.
Modified:
tomcat/trunk/java/or
Author: markt
Date: Thu Jan 17 19:24:53 2013
New Revision: 1434872
URL: http://svn.apache.org/viewvc?rev=1434872&view=rev
Log:
Fix copy/paste error
Modified:
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/xdocs/index.xml
Modified: tomcat/site/trunk/docs/index.html
URL:
http://svn.a
https://issues.apache.org/bugzilla/show_bug.cgi?id=5
Eric changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--- Comment #2 from Eric ---
(In re
https://issues.apache.org/bugzilla/show_bug.cgi?id=5
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=5
Bug ID: 5
Summary: JULI Tomcat 6 settings for FileHandler.limit is
ignored.
Product: Tomcat 6
Version: unspecified
Hardware: All
OS: All
Author: markt
Date: Thu Jan 17 16:22:21 2013
New Revision: 1434759
URL: http://svn.apache.org/viewvc?rev=1434759&view=rev
Log:
FindBugs warnings all resolved :)
Modified:
tomcat/trunk/TOMCAT-NEXT.txt
Modified: tomcat/trunk/TOMCAT-NEXT.txt
URL:
http://svn.apache.org/viewvc/tomcat/trunk/TOMCA
Author: markt
Date: Thu Jan 17 16:20:51 2013
New Revision: 1434758
URL: http://svn.apache.org/viewvc?rev=1434758&view=rev
Log:
One final FindBugs false positive
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
Author: markt
Date: Thu Jan 17 16:19:15 2013
New Revision: 1434757
URL: http://svn.apache.org/viewvc?rev=1434757&view=rev
Log:
Make sure changes to result are visible to all threads currently calling get()
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/Con
Author: remm
Date: Thu Jan 17 16:12:58 2013
New Revision: 1434752
URL: http://svn.apache.org/viewvc?rev=1434752&view=rev
Log:
Improvements as suggested.
Modified:
tomcat/sandbox/rewrite/trunk/rewrite.xml
tomcat/sandbox/rewrite/trunk/src/main/java/org/apache/catalina/valves/rewrite/Rewrit
Author: markt
Date: Thu Jan 17 16:01:37 2013
New Revision: 1434749
URL: http://svn.apache.org/viewvc?rev=1434749&view=rev
Log:
Fix FindBugs warning: Incorrect lazy initialization of static field
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/Sl
Author: markt
Date: Thu Jan 17 15:59:13 2013
New Revision: 1434746
URL: http://svn.apache.org/viewvc?rev=1434746&view=rev
Log:
Silence a valid FindBugs warning about a problem we have chosen to accept
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/f
Author: markt
Date: Thu Jan 17 15:48:25 2013
New Revision: 1434740
URL: http://svn.apache.org/viewvc?rev=1434740&view=rev
Log:
FindBugs false positive. It may not be immediately clear why this is a false
positive so add a comment to explain it.
Modified:
tomcat/trunk/java/org/apache/tomcat/u
Author: markt
Date: Thu Jan 17 15:41:40 2013
New Revision: 1434735
URL: http://svn.apache.org/viewvc?rev=1434735&view=rev
Log:
FindBugs - avoid NPEs
Modified:
tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
Modified: tomcat/trunk/test/org/apache/coyote/http11/upgrade/Test
Author: markt
Date: Thu Jan 17 15:38:40 2013
New Revision: 1434731
URL: http://svn.apache.org/viewvc?rev=1434731&view=rev
Log:
More FindBugs false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
htt
Author: markt
Date: Thu Jan 17 15:31:08 2013
New Revision: 1434725
URL: http://svn.apache.org/viewvc?rev=1434725&view=rev
Log:
socket can't be null here
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.
Author: markt
Date: Thu Jan 17 15:26:58 2013
New Revision: 1434723
URL: http://svn.apache.org/viewvc?rev=1434723&view=rev
Log:
Remove unnecessary sync identified by FindBugs
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/FastHttpDateFormat.java
Modified: tomcat/trunk/java/org/apache
Author: markt
Date: Thu Jan 17 15:25:59 2013
New Revision: 1434722
URL: http://svn.apache.org/viewvc?rev=1434722&view=rev
Log:
Suppress a couple of false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
UR
Author: markt
Date: Thu Jan 17 15:25:18 2013
New Revision: 1434719
URL: http://svn.apache.org/viewvc?rev=1434719&view=rev
Log:
Remove unnecessary sync identified by FindBugs
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/FastHttpDateFormat.java
Modified: tomcat/trunk/java/org/apache
Author: markt
Date: Thu Jan 17 15:02:19 2013
New Revision: 1434704
URL: http://svn.apache.org/viewvc?rev=1434704&view=rev
Log:
Fix remaining Autobahn test failures with APR/native.
Once a close message has been received do not process any more messages from
that connection.
Modified:
tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=54438
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Thu Jan 17 14:33:29 2013
New Revision: 1434688
URL: http://svn.apache.org/viewvc?rev=1434688&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54438
Fix a regression in the fix for BZ 52953 that triggered a NPE when digested
passwords were used and an authen
Author: markt
Date: Thu Jan 17 14:30:39 2013
New Revision: 1434685
URL: http://svn.apache.org/viewvc?rev=1434685&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54438
Fix a regression in the fix for BZ 52953 that triggered an NPE when digested
passwords were used and an authe
https://issues.apache.org/bugzilla/show_bug.cgi?id=51833
--- Comment #5 from Mark Thomas ---
Yes, this is in the change log. If you have any further questions on this
change, they belong on the users mailing list.
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://issues.apache.org/bugzilla/show_bug.cgi?id=51833
--- Comment #4 from ranom...@gmail.com ---
Sorry, but this change was registered in release notes and/or change log of
6.0.33 version?
--
You are receiving this mail because:
You are the assignee for the bug.
-
Author: markt
Date: Thu Jan 17 13:26:32 2013
New Revision: 1434663
URL: http://svn.apache.org/viewvc?rev=1434663&view=rev
Log:
Add the release date
Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/
https://issues.apache.org/bugzilla/show_bug.cgi?id=54440
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Thu Jan 17 13:21:00 2013
New Revision: 1434661
URL: http://svn.apache.org/viewvc?rev=1434661&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54440
Fix a regression caused by the changes for
https://issues.apache.org/bugzilla/show_bug.cgi?id=54240 that brok
Author: markt
Date: Thu Jan 17 13:17:42 2013
New Revision: 1434660
URL: http://svn.apache.org/viewvc?rev=1434660&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54440
Fix a regression caused by the changes for
https://issues.apache.org/bugzilla/show_bug.cgi?id=54240 that brok
https://issues.apache.org/bugzilla/show_bug.cgi?id=54439
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=54440
Sean Owen changed:
What|Removed |Added
OS||All
--- Comment #2 from Sean Owen ---
Author: markt
Date: Thu Jan 17 09:12:56 2013
New Revision: 1434598
URL: http://svn.apache.org/viewvc?rev=1434598&view=rev
Log:
Remove unused attributes
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
https://issues.apache.org/bugzilla/show_bug.cgi?id=54440
--- Comment #1 from Sheldon Shao ---
Created attachment 29860
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29860&action=edit
Patch for this issue
The root cause is that there is no ClassLoader was set in JspCServletContext.
J
58 matches
Mail list logo