svn commit: r1672434 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 17:58:40 2015 New Revision: 1672434 URL: http://svn.apache.org/r1672434 Log: SNI Refactoring. I'm doing this in small steps as I tried to do it a single go and got something wrong that broke secure connections. Modified:

[Bug 57801] Tomcat catalina.sh fails to start after machine is reboot because there is another process have the same PID as Tomcat before reboot

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57801 Rainer Jung rainer.j...@kippdata.de changed: What|Removed |Added Product|Tomcat 8|Tomcat 6

buildbot success in ASF Buildbot on tomcat-trunk

2015-04-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1116 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1672284 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 10:29:52 2015 New Revision: 1672284 URL: http://svn.apache.org/r1672284 Log: More hints about process using the PID. Modified: tomcat/trunk/bin/catalina.sh Modified: tomcat/trunk/bin/catalina.sh URL:

buildbot failure in ASF Buildbot on tomcat-7-trunk

2015-04-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/616 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot success in ASF Buildbot on tomcat-trunk

2015-04-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1120 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 56438] If jar scan does not find context config or TLD config, log a message

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #3 from VIN reachme.va...@gmail.com --- Created attachment 32639 -- https://bz.apache.org/bugzilla/attachment.cgi?id=32639action=edit Fix for Tomcat7 TldConfig and ContextConfig scan Attached patch contains below fixes: 1) If any

svn commit: r1672286 - in /tomcat/tc7.0.x/trunk: ./ bin/catalina.sh

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 10:32:21 2015 New Revision: 1672286 URL: http://svn.apache.org/r1672286 Log: More hints about process using the PID. Backport of r1672284 from trunk resp. r1672285 from tc8. Modified: tomcat/tc7.0.x/trunk/ (props changed)

[Bug 57799] MessageCreationException: Couldn't create SOAP message with Nio2 connector protocol

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57799 --- Comment #3 from Remy Maucherat r...@apache.org --- As part of the investigation I fixed some issues (r1672297) which will be backported to Tomcat 8, but I don't see any way for the read pending flag to have a bad state. Without some test,

svn commit: r1672287 - /tomcat/tc6.0.x/trunk/STATUS.txt

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 10:34:27 2015 New Revision: 1672287 URL: http://svn.apache.org/r1672287 Log: Add further improvement to proposal. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1672297 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

2015-04-09 Thread remm
Author: remm Date: Thu Apr 9 11:45:56 2015 New Revision: 1672297 URL: http://svn.apache.org/r1672297 Log: Investigating 57799 I found some issues in the SSL impl: - Possibly incomplete writes. - After some errors (which shouldn't happen however), the pending flag could still be set. - A bad

Re: [GUMP@vmgump]: Project tomcat-tc8.0.x (in module tomcat-8.0.x) failed

2015-04-09 Thread Rainer Jung
Am 09.04.2015 um 02:57 schrieb Bill Barker: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x has an issue affecting

buildbot exception in ASF Buildbot on tomcat-trunk

2015-04-09 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1118 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1672312 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/ http11/filters/ spdy/

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 12:33:37 2015 New Revision: 1672312 URL: http://svn.apache.org/r1672312 Log: Remove unused parameter passed around a whole bunch of code. Discovered while fixing Java 8 Javadoc issues with InputBuffer when I wondered what the Request parameter was for. Answer: in

svn commit: r1672329 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractJsseEndpoint.java Nio2Endpoint.java NioEndpoint.java

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 13:05:23 2015 New Revision: 1672329 URL: http://svn.apache.org/r1672329 Log: Insert an additional class into the Endpoint class structure for JSSE specific stuff common to NIO and NIO2. The is primarily intended for SNI. Added:

Re: Reg: Bug 56438

2015-04-09 Thread Pravallika Peddi
Hi Mark, I can add the Boolean variable at ContextConfig class level so that all pluggability scans can access it and set the value accordingly. Almost all web-inf/lib/class scans are internally calling “processAnnotationsStream()” method of ContextConfig.java. So in this method I can change

[Bug 56438] If jar scan does not find context config or TLD config, log a message

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #4 from Justin Cranford justincranf...@hotmail.com --- The patch sounds great. Three small suggestions to make it just a little better: 1) Can you add a debug message to show positive matches? Logging negative matches is very

Re: Reg: Bug 56438

2015-04-09 Thread Mark Thomas
On 08/04/2015 11:20, Pravallika Peddi wrote: Hi Mark, Highlighted code is the Fix to add summary message to *Tomcat7.0*: Patches should be in diff -u format and are best attached to bug reports. Mark In org.apache.catalina.startup.TldConfig.java à a) Return a Boolean

[Bug 57108] Implement multiple sslcontext SNI (server name indication) dispatch

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57108 --- Comment #12 from Mark Thomas ma...@apache.org --- Keeping the config at the connector level is probably the way to go. There are weird and wonderful configuration possibilities like one Connector on one interface with one set of certs for

Fix submitted for bug 56438

2015-04-09 Thread Pravallika Peddi
Hi Mark, I have submitted a fix for 56438 bug for Tomcat7. Can you help review it and let me know? Thanks in advance. Regards, Pravallika(VIN)

buildbot success in ASF Buildbot on tomcat-7-trunk

2015-04-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/617 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: Reg: Bug 56438

2015-04-09 Thread Mark Thomas
On 08/04/2015 14:07, Pravallika Peddi wrote: Hi Mark, *Fix for Pluggability Scan in Tomcat 7.0: * You have only addressed fragment scanning. You have not addressed the other scans such as class scanning which are part of the pluggability scanning process. I agree adding a flag to track if a

Re: svn commit: r1672272 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread Rainer Jung
Am 09.04.2015 um 11:57 schrieb Konstantin Kolinko: 2015-04-09 12:24 GMT+03:00 rj...@apache.org: Author: rjung Date: Thu Apr 9 09:24:49 2015 New Revision: 1672272 URL: http://svn.apache.org/r1672272 Log: BZ57801: Give a hint on what to do. This might happen, if a system reboot happens,

[Bug 57801] New: Tomcat catalina.sh fails to start after machine is reboot because there is another process have the same PID as Tomcat before reboot

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57801 Bug ID: 57801 Summary: Tomcat catalina.sh fails to start after machine is reboot because there is another process have the same PID as Tomcat before reboot Product:

Re: svn commit: r1672272 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread Konstantin Kolinko
2015-04-09 13:26 GMT+03:00 Rainer Jung rainer.j...@kippdata.de: Am 09.04.2015 um 11:57 schrieb Konstantin Kolinko: 2015-04-09 12:24 GMT+03:00 rj...@apache.org: Author: rjung Date: Thu Apr 9 09:24:49 2015 New Revision: 1672272 URL: http://svn.apache.org/r1672272 Log: BZ57801: Give a

[Bug 57801] Tomcat catalina.sh fails to start after machine is reboot because there is another process have the same PID as Tomcat before reboot

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57801 Rainer Jung rainer.j...@kippdata.de changed: What|Removed |Added Severity|normal |enhancement

svn commit: r1672274 - in /tomcat/tc7.0.x/trunk: ./ bin/catalina.sh webapps/docs/changelog.xml

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 09:33:29 2015 New Revision: 1672274 URL: http://svn.apache.org/r1672274 Log: BZ57801: Give a hint on what to do. This might happen, if a system reboot happens, Tomcat is not shut down properly and another process reuses the PID after the reboot, before Tomcat is

svn commit: r1672492 - in /tomcat/trunk/java/org/apache/tomcat/util/net: LocalStrings.properties SNIExtractor.java SecureNioChannel.java

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 21:15:11 2015 New Revision: 1672492 URL: http://svn.apache.org/r1672492 Log: SNI refactoring for NIO. Peek at the data but currently parsing the data is stubbed to report no hostname found. Added: tomcat/trunk/java/org/apache/tomcat/util/net/SNIExtractor.java

[Bug 56438] If jar scan does not find context config or TLD config, log a message

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #5 from Mark Thomas ma...@apache.org --- (In reply to VIN from comment #3) Please review my patch and let me know in case of any problems. Part 1 looks generally OK. You need to use 4 spaces rather than tabs and I agree with the

svn commit: r1672437 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioEndpoint.java SecureNioChannel.java

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 18:17:24 2015 New Revision: 1672437 URL: http://svn.apache.org/r1672437 Log: SNI Refactoring. I'm doing this in small steps as I tried to do it a single go and got something wrong that broke secure connections. Modified:

svn commit: r1672273 - in /tomcat/tc8.0.x/trunk: ./ bin/catalina.sh webapps/docs/changelog.xml

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 09:30:52 2015 New Revision: 1672273 URL: http://svn.apache.org/r1672273 Log: BZ57801: Give a hint on what to do. This might happen, if a system reboot happens, Tomcat is not shut down properly and another process reuses the PID after the reboot, before Tomcat is

svn commit: r1672285 - in /tomcat/tc8.0.x/trunk: ./ bin/catalina.sh

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 10:31:09 2015 New Revision: 1672285 URL: http://svn.apache.org/r1672285 Log: More hints about process using the PID. Backport of r1672284 from trunk. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/bin/catalina.sh Propchange:

Re: svn commit: r1672272 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread Konstantin Kolinko
2015-04-09 12:24 GMT+03:00 rj...@apache.org: Author: rjung Date: Thu Apr 9 09:24:49 2015 New Revision: 1672272 URL: http://svn.apache.org/r1672272 Log: BZ57801: Give a hint on what to do. This might happen, if a system reboot happens, Tomcat is not shut down properly and another

svn commit: r1672276 - /tomcat/tc6.0.x/trunk/STATUS.txt

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 09:40:35 2015 New Revision: 1672276 URL: http://svn.apache.org/r1672276 Log: Propose. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1672272 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread rjung
Author: rjung Date: Thu Apr 9 09:24:49 2015 New Revision: 1672272 URL: http://svn.apache.org/r1672272 Log: BZ57801: Give a hint on what to do. This might happen, if a system reboot happens, Tomcat is not shut down properly and another process reuses the PID after the reboot, before Tomcat is

svn commit: r1672393 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Channel.java NioChannel.java SecureNio2Channel.java SecureNioChannel.java

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 15:16:42 2015 New Revision: 1672393 URL: http://svn.apache.org/r1672393 Log: Some initial plumbing for SNI. While Java 8 supports SNI, if you want different certs for different hosts then you have to manually parse the incoming TLS bytes to look for the SNI

svn commit: r1672452 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioEndpoint.java SecureNioChannel.java SocketBufferHandler.java

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 18:58:39 2015 New Revision: 1672452 URL: http://svn.apache.org/r1672452 Log: More SNI refactoring. Should be ready to start peeking at the input stream now. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

svn commit: r1672342 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractJsseEndpoint.java Nio2Endpoint.java NioEndpoint.java

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 13:23:53 2015 New Revision: 1672342 URL: http://svn.apache.org/r1672342 Log: Pull up the common JSSE code. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractJsseEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

buildbot failure in ASF Buildbot on tomcat-trunk

2015-04-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1119 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: HTTP/2 progress report

2015-04-09 Thread Rémy Maucherat
2015-04-08 23:56 GMT+02:00 Mark Thomas ma...@apache.org: As of r1672190 we now have the following: - ALPN support in tc-native trunk - The ability to register upgrade protocol implementations that will: - be included in the ALPN negotiation - cause processing to be passed to a protocol

[Bug 57801] Tomcat catalina.sh fails to start after machine is reboot because there is another process have the same PID as Tomcat before reboot

2015-04-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57801 --- Comment #3 from Rainer Jung rainer.j...@kippdata.de --- Also added ps output for the process with the PID in r1672284 (trunk), r1672285 (tc8) and r1672286 (tc7). -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1672325 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/ http11/filters/

2015-04-09 Thread markt
Author: markt Date: Thu Apr 9 12:54:41 2015 New Revision: 1672325 URL: http://svn.apache.org/r1672325 Log: Javadoc fixes for InputBuffer Modified: tomcat/trunk/java/org/apache/coyote/InputBuffer.java tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

Re: Reg: Bug 56438

2015-04-09 Thread Mark Thomas
On 09/04/2015 13:25, Pravallika Peddi wrote: Hi Mark, I can add the Boolean variable at ContextConfig class level so that all pluggability scans can access it and set the value accordingly. That is too high. It needs to be per JAR. Almost all web-inf/lib/class scans are internally