[Bug 58660] Different redirect behaviour when accessing path without a /

2016-01-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #20 from Andrii Pitukh --- I've just reproduced following case in 8.0.30 (8.0.28 is ok): Steps: 1. Download Tomcat installation 2. Open webapps/examples/WEB-INF/web.xml folder 3. Change lines:

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2016-01-22 Thread Bill Barker
-daemon-20160122-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20160122/lib -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace

svn commit: r1726306 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_31: ./ build.properties.default webapps/docs/changelog.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 20:30:24 2016 New Revision: 1726306 URL: http://svn.apache.org/viewvc?rev=1726306=rev Log: Tag 8.0.31 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_31/ (props changed) - copied from r1726304, tomcat/tc8.0.x/trunk/ Modified:

svn commit: r12007 [1/2] - in /dev/tomcat/tomcat-8/v8.0.31: ./ bin/ bin/embed/ bin/extras/ src/

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 21:00:33 2016 New Revision: 12007 Log: Upload 8.0.31 for voting Added: dev/tomcat/tomcat-8/v8.0.31/ dev/tomcat/tomcat-8/v8.0.31/KEYS (with props) dev/tomcat/tomcat-8/v8.0.31/README.html (with props) dev/tomcat/tomcat-8/v8.0.31/RELEASE-NOTES

svn commit: r12007 [2/2] - in /dev/tomcat/tomcat-8/v8.0.31: ./ bin/ bin/embed/ bin/extras/ src/

2016-01-22 Thread markt
Added: dev/tomcat/tomcat-8/v8.0.31/bin/extras/tomcat-juli-adapters.jar.sha1 == --- dev/tomcat/tomcat-8/v8.0.31/bin/extras/tomcat-juli-adapters.jar.sha1 (added) +++

[Bug 57528] Random NPE when sending multipart content

2016-01-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57528 --- Comment #6 from Christopher Schultz --- (In reply to Brent Griffin from comment #5) > My issue turned out to be that the operating system was running out of file > handles. So, it was failing to load a class

svn commit: r1726309 - in /tomcat/tc8.0.x/trunk/java/org/apache/catalina: ant/jmx/JMXAccessorQueryTask.java tribes/group/interceptors/MessageDispatchInterceptor.java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 20:41:43 2016 New Revision: 1726309 URL: http://svn.apache.org/viewvc?rev=1726309=rev Log: Javadoc Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java

Re: svn commit: r1725910 - /tomcat/trunk/webapps/docs/changelog.xml

2016-01-22 Thread Christopher Schultz
Mark, On 1/21/16 6:40 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Jan 21 11:40:47 2016 > New Revision: 1725910 > > URL: http://svn.apache.org/viewvc?rev=1725910=rev > Log: > Update changelog > > Modified: > tomcat/trunk/webapps/docs/changelog.xml > > Modified:

svn commit: r1726171 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/res/StringManager.java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:07:04 2016 New Revision: 1726171 URL: http://svn.apache.org/viewvc?rev=1726171=rev Log: Backport StringManager clean-up and improvements, particularly the ability to obtain a StringManager using a class object. Modified: tomcat/tc8.0.x/trunk/ (props

Re: [VOTE] Release Apache Tomcat 9.0.0.M2

2016-01-22 Thread Mark Thomas
On 21/01/2016 12:38, Mark Thomas wrote: > The proposed Apache Tomcat 9.0.0.M2 release is now available for voting. > > This is the second milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not started work

[VOTE] Release Apache Tomcat 8.0.31

2016-01-22 Thread Mark Thomas
The proposed Apache Tomcat 8.0.31 release is now available for voting. The main changes since 8.0.30 are: - Restore the default for mapperContextRootRedirectEnabled to true - Update the packaged version of the Tomcat Native Library to 1.2.4 to pick up the Windows binaries that are based on

svn commit: r1726333 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 22:24:32 2016 New Revision: 1726333 URL: http://svn.apache.org/viewvc?rev=1726333=rev Log: Increment version ready for 8.0.32 development cycle Modified: tomcat/tc8.0.x/trunk/build.properties.default tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default

Re: [VOTE] Release Apache Tomcat 8.0.31

2016-01-22 Thread Mark Thomas
On 22/01/2016 22:21, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.31 release is now available for voting. > > The main changes since 8.0.30 are: > > - Restore the default for mapperContextRootRedirectEnabled to true > > - Update the packaged version of the Tomcat Native Library to 1.2.4

svn commit: r1726173 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:14:16 2016 New Revision: 1726173 URL: http://svn.apache.org/viewvc?rev=1726173=rev Log: Review Javadoc for Manager hierarchy. Remove unnecessary duplication. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1726181 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/config/manager.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:31:28 2016 New Revision: 1726181 URL: http://svn.apache.org/viewvc?rev=1726181=rev Log: Make clear that the PersistenceManager is the better option is you actually *need* to persist session data across restarts. Modified: tomcat/tc8.0.x/trunk/ (props

svn commit: r1726182 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/session/StandardSession.java webapps/docs/config/manager.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:34:00 2016 New Revision: 1726182 URL: http://svn.apache.org/viewvc?rev=1726182=rev Log: Clean-up Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/StandardSession.java

svn commit: r1726195 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/tcp/ java/org/apache/ca

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:30:37 2016 New Revision: 1726195 URL: http://svn.apache.org/viewvc?rev=1726195=rev Log: Clarify behaviour of Manager.context Note: This does not impact Context.manager A Manager can only be used with a single Context and must then be destroyed when no longer

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2016-01-22 Thread Bill Barker
/daemon/dist/bin/commons-daemon-20160122-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160122.jar -Dcommons-daemon.native.src.tgz

svn commit: r1726172 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:11:28 2016 New Revision: 1726172 URL: http://svn.apache.org/viewvc?rev=1726172=rev Log: Refactoring Make the session attribute distribution / filtering more consistent across the various Manager and Session implementation. Differentiate between - whether or not

svn commit: r1726180 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaSession.java java/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:29:21 2016 New Revision: 1726180 URL: http://svn.apache.org/viewvc?rev=1726180=rev Log: Handle the case where the session attribute filtering configuration was changed while the web application was stopped. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1726198 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ java/org/apache/catalina/manager/ java/org/apache/ca

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:35:28 2016 New Revision: 1726198 URL: http://svn.apache.org/viewvc?rev=1726198=rev Log: Deprecate Manager.distributable and Manager.maxInactiveInterval since they exist in both the Context and the Manager and the Context values always take precedence.

svn commit: r1726202 - in /tomcat/trunk: java/org/apache/catalina/util/CustomObjectInputStream.java webapps/docs/changelog.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:58:14 2016 New Revision: 1726202 URL: http://svn.apache.org/viewvc?rev=1726202=rev Log: WeakHashMap isn't thread safe. Modified: tomcat/trunk/java/org/apache/catalina/util/CustomObjectInputStream.java tomcat/trunk/webapps/docs/changelog.xml Modified:

svn commit: r1726203 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/session/ java/org/apache/catalina/util/ webapps/docs/ webapps/docs/config/

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 13:02:28 2016 New Revision: 1726203 URL: http://svn.apache.org/viewvc?rev=1726203=rev Log: When using the new sessionAttributeValueClassNameFilter, apply the filter earlier rather than loading the class and then deciding to filter it out. When a SecurityManager is

Re: [RFC] Merge Tomcat 6 testing branch ()tomcat6-testing_20160106) into Tomcat 6

2016-01-22 Thread Mark Thomas
On 21/01/2016 22:15, Konstantin Kolinko wrote: > Hi! > > 1. A branch that implements testting framework for Tomcat 6 is ready for > review. > It implements client-server unit tests (Tomcat, TomcatBaseTest classes) > It implements running the tests with Apache Ant. > > The branch is here: >

svn commit: r1726177 - /tomcat/trunk/webapps/docs/changelog.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:26:26 2016 New Revision: 1726177 URL: http://svn.apache.org/viewvc?rev=1726177=rev Log: This change was reverted before the 9.0.0.M2 tag Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2016-01-22 Thread Bill Barker
/commons-daemon-20160122-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160122.jar -Dcommons

svn commit: r1726200 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/session/FileStore.java java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/StoreBase.java java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:40:28 2016 New Revision: 1726200 URL: http://svn.apache.org/viewvc?rev=1726200=rev Log: Ensure that when sessions are loaded from the Store that the correct class loader is used. In most cases it was already set but some code paths from early in the processing

svn commit: r1726175 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ webapps/docs/config/

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:20:15 2016 New Revision: 1726175 URL: http://svn.apache.org/viewvc?rev=1726175=rev Log: Pull up the sessionAttributeFilter option from the cluster managers, rename it to sessionAttributeNameFilter and make it available in all Manager implementations. Modified:

svn commit: r1726179 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/session/ClusterManagerBase.java java/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 11:27:46 2016 New Revision: 1726179 URL: http://svn.apache.org/viewvc?rev=1726179=rev Log: Update changelog Javadoc and cleanup Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1726190 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/Lifecycle.java java/org/apache/catalina/LifecycleState.java java/org/apache/catalina/util/LifecycleBase.java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:23:44 2016 New Revision: 1726190 URL: http://svn.apache.org/viewvc?rev=1726190=rev Log: Deprecate lifecycle states that were never used and could never be used. Add new Lifecycle.SingleUse marker interface as a replacement for MUST_DESTROY Document how to use

svn commit: r1726191 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/util/LifecycleBase.java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:25:00 2016 New Revision: 1726191 URL: http://svn.apache.org/viewvc?rev=1726191=rev Log: Fix test failures Automatically calling stop() after start() failed triggered multiple failures to revert that part of the refactoring in r1725599 Modified:

svn commit: r1726196 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ webapps/docs/ webapps/docs/config/

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:33:49 2016 New Revision: 1726196 URL: http://svn.apache.org/viewvc?rev=1726196=rev Log: Expand the session attribute filtering options - new option to filter based on implementation class of value - new option to log a warning message if an attribute is filtered

svn commit: r1726197 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/session/ClusterManagerBase.java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:34:21 2016 New Revision: 1726197 URL: http://svn.apache.org/viewvc?rev=1726197=rev Log: Remove deprecated attribute (sessionAttributeFilter) from clone. Has been replaced by sessionAttributeNameFilter Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1726199 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/util/LifecycleBase.java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 12:38:41 2016 New Revision: 1726199 URL: http://svn.apache.org/viewvc?rev=1726199=rev Log: Further fix to regression in Lifecycle refactoring Trigger a call to stop() if a component puts itself into the FAILED state during start(). Modified:

buildbot failure in ASF Buildbot on tomcat-8-trunk

2016-01-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/415 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58660] Different redirect behaviour when accessing path without a /

2016-01-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #21 from Mark Thomas --- That behaviour is expected in 8.0.30. The ChatServlet isn't written to handle reuqests to the root of the context that don't have a trailing slash. Whether it should or not is open to

Re: [RFC] Merge Tomcat 6 testing branch ()tomcat6-testing_20160106) into Tomcat 6

2016-01-22 Thread Konstantin Kolinko
2016-01-22 16:08 GMT+03:00 Mark Thomas : > On 21/01/2016 22:15, Konstantin Kolinko wrote: >> Hi! >> >> 1. A branch that implements testting framework for Tomcat 6 is ready for >> review. >> It implements client-server unit tests (Tomcat, TomcatBaseTest classes) >> It implements

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2016-01-22 Thread Bill Barker
-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160122.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

2016-01-22 Thread Bill Barker
-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160122.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x

svn commit: r1726226 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java

2016-01-22 Thread markt
Author: markt Date: Fri Jan 22 15:07:34 2016 New Revision: 1726226 URL: http://svn.apache.org/viewvc?rev=1726226=rev Log: Follow-up to r1726198 This rather critical change was hiding in a later commit that removed the deprecate code. Modified:

[Bug 58660] Different redirect behaviour when accessing path without a /

2016-01-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 Andrii Pitukh changed: What|Removed |Added Resolution|FIXED |---

[Bug 58660] Different redirect behaviour when accessing path without a /

2016-01-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2016-01-22 Thread Bill Barker
-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160122.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x

buildbot success in ASF Buildbot on tomcat-8-trunk

2016-01-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/418 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The