[Bug 58999] StringIndexOutOfBoundsException WebAppClassLoaderBase.filter()

2016-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58999 --- Comment #5 from Violeta Georgieva --- (In reply to Rainer Jung from comment #4) > Thanks to the OP for analysing the problem and to Violeta for the patch. > > Please have a look at r1730101, which fixes the > StringIndexOutOfBoundsExceptio

Re: svn commit: r1730101 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappClassLoaderBase.java test/org/apache/catalina/loader/TestWebappClassLoader.java

2016-02-12 Thread Violeta Georgieva
2016-02-13 0:40 GMT+02:00 Rainer Jung : > > Hi Violeta, > > build breakage fixed in r1730137. > > I adjusted the test to better reflect what's implemented currently: > > - deny if name is something below the denied package. We don't care for the package names themselves without anything added. > -

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2016-02-12 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community integration

Re: svn commit: r1730101 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappClassLoaderBase.java test/org/apache/catalina/loader/TestWebappClassLoader.java

2016-02-12 Thread Rainer Jung
Hi Violeta, build breakage fixed in r1730137. I adjusted the test to better reflect what's implemented currently: - deny if name is something below the denied package. We don't care for the package names themselves without anything added. - permit exclude rules work the same way, only permit f

svn commit: r1730137 - /tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoader.java

2016-02-12 Thread rjung
Author: rjung Date: Fri Feb 12 22:37:01 2016 New Revision: 1730137 URL: http://svn.apache.org/viewvc?rev=1730137&view=rev Log: Fix test compilation. Thanks Violeta. (never do last minute changes) Split test in 3 sections: - general prefix/suffix combinations, all combinations permitted - permit

Re: svn commit: r1730101 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappClassLoaderBase.java test/org/apache/catalina/loader/TestWebappClassLoader.java

2016-02-12 Thread Violeta Georgieva
Hi, 2016-02-12 22:35 GMT+02:00 : > > Author: rjung > Date: Fri Feb 12 20:35:26 2016 > New Revision: 1730101 > > URL: http://svn.apache.org/viewvc?rev=1730101&view=rev > Log: > BZ 58999: Fix class and resource name > filtering in WebappClassLoader. > > It throws a StringIndexOutOfBoundsException >

[Bug 58999] StringIndexOutOfBoundsException WebAppClassLoaderBase.filter()

2016-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58999 --- Comment #4 from Rainer Jung --- Thanks to the OP for analysing the problem and to Violeta for the patch. Please have a look at r1730101, which fixes the StringIndexOutOfBoundsException. The onyl problem I saw was the charAt(), because ind

buildbot failure in on tomcat-trunk

2016-02-12 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/1048 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1730102 - /tomcat/trunk/webapps/docs/changelog.xml

2016-02-12 Thread rjung
Author: rjung Date: Fri Feb 12 20:40:06 2016 New Revision: 1730102 URL: http://svn.apache.org/viewvc?rev=1730102&view=rev Log: Changelog update for r1730101. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc

svn commit: r1730101 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappClassLoaderBase.java test/org/apache/catalina/loader/TestWebappClassLoader.java

2016-02-12 Thread rjung
Author: rjung Date: Fri Feb 12 20:35:26 2016 New Revision: 1730101 URL: http://svn.apache.org/viewvc?rev=1730101&view=rev Log: BZ 58999: Fix class and resource name filtering in WebappClassLoader. It throws a StringIndexOutOfBoundsException if the name is "org" or "javax". We currently do not fi

[Bug 58244] two way SSL loses client certificate after a few requests

2016-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58244 --- Comment #11 from David Balažic --- Same with tomcat version 8.0.32 which bundles OpenSSL 1.0.2e (see below) The issue remains (with the change that now IE can not connect at all, it complains about some TLS stuff, did not look into it). V

[Bug 58999] StringIndexOutOfBoundsException WebAppClassLoaderBase.filter()

2016-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58999 --- Comment #3 from Violeta Georgieva --- (In reply to Shon Vella from comment #2) > Looked over the patch and I think the changes for org.apache.tomcat.jdbc > javax.servlet.jsp.jstl will now incorrectly detect things like > org.apache.tomcat.

[ANN] Apache Tomcat 6.0.45 available

2016-02-12 Thread Jean-Frederic Clere
The Apache Tomcat team announces the immediate availability of Apache Tomcat 6.0.45. Apache Tomcat is an open source software implementation of the Java Servlet, JavaServer Pages and Java Expression Language technologies. This release contains a number of bug fixes and improvements compared to ve

[Bug 58999] StringIndexOutOfBoundsException WebAppClassLoaderBase.filter()

2016-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58999 --- Comment #2 from Shon Vella --- Looked over the patch and I think the changes for org.apache.tomcat.jdbc javax.servlet.jsp.jstl will now incorrectly detect things like org.apache.tomcat.jdbcx and javax.servlet.jsp.jstly - Not very likely to

svn commit: r1730038 - /tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 15:06:31 2016 New Revision: 1730038 URL: http://svn.apache.org/viewvc?rev=1730038&view=rev Log: Remove unnecessary code. The socket/processor is already added to the connections map. Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Modified:

svn commit: r1730034 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 15:00:44 2016 New Revision: 1730034 URL: http://svn.apache.org/viewvc?rev=1730034&view=rev Log: Performance optimisation. For a very simple servlet this reduces processing time by ~1%. Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Modifie

Re: svn commit: r1729980 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2016-02-12 Thread Mark Thomas
On 12/02/2016 11:58, Rémy Maucherat wrote: > 2016-02-12 12:07 GMT+01:00 Mark Thomas : > >> On 12/02/2016 10:53, ma...@apache.org wrote: >>> Author: markt >>> Date: Fri Feb 12 10:53:00 2016 >>> New Revision: 1729980 >>> >>> URL: http://svn.apache.org/viewvc?rev=1729980&view=rev >>> Log: >>> Perform

svn commit: r1730017 - in /tomcat/site/trunk: docs/download-60.html xdocs/download-60.xml

2016-02-12 Thread jfclere
Author: jfclere Date: Fri Feb 12 13:01:39 2016 New Revision: 1730017 URL: http://svn.apache.org/viewvc?rev=1730017&view=rev Log: Remove Itanium 64-bit Windows platforms binaries. Modified: tomcat/site/trunk/docs/download-60.html tomcat/site/trunk/xdocs/download-60.xml Modified: tomcat/si

buildbot success in on tomcat-trunk

2016-02-12 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/1044 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1730012 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 12:28:29 2016 New Revision: 1730012 URL: http://svn.apache.org/viewvc?rev=1730012&view=rev Log: Clean-up. Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChai

svn commit: r12367 - in /release/tomcat/tomcat-6/v6.0.45: README.html bin/README.html

2016-02-12 Thread jfclere
Author: jfclere Date: Fri Feb 12 12:19:21 2016 New Revision: 12367 Log: Remove Itanium 64-bit Windows platforms binaries. Modified: release/tomcat/tomcat-6/v6.0.45/README.html release/tomcat/tomcat-6/v6.0.45/bin/README.html Modified: release/tomcat/tomcat-6/v6.0.45/README.html ==

svn commit: r1730008 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 12:17:43 2016 New Revision: 1730008 URL: http://svn.apache.org/viewvc?rev=1730008&view=rev Log: Clean-up & re-order No measurable performance improvement Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java Modified: tomcat/trunk/

svn commit: r1730007 - in /tomcat/tc6.0.x/trunk/res: welcome.bin.html welcome.main.html

2016-02-12 Thread jfclere
Author: jfclere Date: Fri Feb 12 12:17:02 2016 New Revision: 1730007 URL: http://svn.apache.org/viewvc?rev=1730007&view=rev Log: Remove Itanium 64-bit Windows platforms binaries. Modified: tomcat/tc6.0.x/trunk/res/welcome.bin.html tomcat/tc6.0.x/trunk/res/welcome.main.html Modified: tomc

Re: svn commit: r1729980 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2016-02-12 Thread Rémy Maucherat
2016-02-12 12:07 GMT+01:00 Mark Thomas : > On 12/02/2016 10:53, ma...@apache.org wrote: > > Author: markt > > Date: Fri Feb 12 10:53:00 2016 > > New Revision: 1729980 > > > > URL: http://svn.apache.org/viewvc?rev=1729980&view=rev > > Log: > > Performance optimisation. For a very simple servlet thi

buildbot failure in on tomcat-trunk

2016-02-12 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/1042 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1729997 - /tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 11:23:56 2016 New Revision: 1729997 URL: http://svn.apache.org/viewvc?rev=1729997&view=rev Log: Add missing exclude spotted by BuildBot Modified: tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt Modified: tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt URL: http://

svn commit: r1729995 - /tomcat/trunk/res/rat/rat-excludes.txt

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 11:21:31 2016 New Revision: 1729995 URL: http://svn.apache.org/viewvc?rev=1729995&view=rev Log: Add missing exclude spotted by BuildBot Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/v

svn commit: r1729994 - /tomcat/tc7.0.x/trunk/res/rat/rat-excludes.txt

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 11:20:05 2016 New Revision: 1729994 URL: http://svn.apache.org/viewvc?rev=1729994&view=rev Log: Add missing exclude spotted by BuildBot Modified: tomcat/tc7.0.x/trunk/res/rat/rat-excludes.txt Modified: tomcat/tc7.0.x/trunk/res/rat/rat-excludes.txt URL: http://

svn commit: r1729991 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 11:14:25 2016 New Revision: 1729991 URL: http://svn.apache.org/viewvc?rev=1729991&view=rev Log: Simplify Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java UR

Re: svn commit: r1729980 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2016-02-12 Thread Mark Thomas
On 12/02/2016 10:53, ma...@apache.org wrote: > Author: markt > Date: Fri Feb 12 10:53:00 2016 > New Revision: 1729980 > > URL: http://svn.apache.org/viewvc?rev=1729980&view=rev > Log: > Performance optimisation. For a very simple servlet this reduces processing > time by ~2%. For the curious, I

svn commit: r1729980 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2016-02-12 Thread markt
Author: markt Date: Fri Feb 12 10:53:00 2016 New Revision: 1729980 URL: http://svn.apache.org/viewvc?rev=1729980&view=rev Log: Performance optimisation. For a very simple servlet this reduces processing time by ~2%. Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

[Bug 58999] StringIndexOutOfBoundsException WebAppClassLoaderBase.filter()

2016-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58999 --- Comment #1 from Violeta Georgieva --- Created attachment 33549 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33549&action=edit patch Hi, I'm attaching here a patch proposal so that others can comment. I found one more problem:

svn commit: r1729953 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2016-02-12 Thread jfclere
Author: jfclere Date: Fri Feb 12 08:00:45 2016 New Revision: 1729953 URL: http://svn.apache.org/viewvc?rev=1729953&view=rev Log: Restore broken history. Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: http://