svn commit: r1750438 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 02:27:21 2016 New Revision: 1750438 URL: http://svn.apache.org/viewvc?rev=1750438=rev Log: Ensure that do not remove the abandoned connection that has been already released. Modified:

svn commit: r1750437 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 02:26:21 2016 New Revision: 1750437 URL: http://svn.apache.org/viewvc?rev=1750437=rev Log: Ensure that do not remove the abandoned connection that has been already released. Modified:

svn commit: r1750436 - in /tomcat/tc8.5.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 02:25:28 2016 New Revision: 1750436 URL: http://svn.apache.org/viewvc?rev=1750436=rev Log: Ensure that do not remove the abandoned connection that has been already released. Modified:

svn commit: r1750435 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 02:24:34 2016 New Revision: 1750435 URL: http://svn.apache.org/viewvc?rev=1750435=rev Log: Ensure that do not remove the abandoned connection that has been already released. Modified:

svn commit: r1750434 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/doc/jdbc-pool.xml webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 01:59:48 2016 New Revision: 1750434 URL: http://svn.apache.org/viewvc?rev=1750434=rev Log: Fix the description of maxAge attribute in jdbc-pool doc. This attribute works both when a connection is returned and when a connection is borrowed. Modified:

svn commit: r1750433 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/doc/jdbc-pool.xml webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 01:58:45 2016 New Revision: 1750433 URL: http://svn.apache.org/viewvc?rev=1750433=rev Log: Fix the description of maxAge attribute in jdbc-pool doc. This attribute works both when a connection is returned and when a connection is borrowed. Modified:

svn commit: r1750432 - in /tomcat/tc8.5.x/trunk: modules/jdbc-pool/doc/jdbc-pool.xml webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 01:57:58 2016 New Revision: 1750432 URL: http://svn.apache.org/viewvc?rev=1750432=rev Log: Fix the description of maxAge attribute in jdbc-pool doc. This attribute works both when a connection is returned and when a connection is borrowed. Modified:

svn commit: r1750431 - in /tomcat/trunk: modules/jdbc-pool/doc/jdbc-pool.xml webapps/docs/changelog.xml

Author: kfujino Date: Tue Jun 28 01:57:07 2016 New Revision: 1750431 URL: http://svn.apache.org/viewvc?rev=1750431=rev Log: Fix the description of maxAge attribute in jdbc-pool doc. This attribute works both when a connection is returned and when a connection is borrowed. Modified:

Re: Bug that spans tomcat and tomcat-native

On Mon, Jun 27, 2016 at 5:19 PM, Mark Thomas wrote: > On 27/06/2016 19:59, Nate Clark wrote: >> On Mon, Jun 27, 2016 at 2:13 PM, Rainer Jung wrote: > > > >>> I wouldn't care too much about portability right now. If you can prove >>> Mark's analysis by

Re: Bug that spans tomcat and tomcat-native

On 27/06/2016 19:59, Nate Clark wrote: > On Mon, Jun 27, 2016 at 2:13 PM, Rainer Jung wrote: >> I wouldn't care too much about portability right now. If you can prove >> Mark's analysis by using gettid() on Linux and checking that this fixes the >> performance issue,

[Bug 59761] "No modifications are allowed to a locked ParameterMap" - Tomcat 8.0.32 is not compatible with older versions

https://bz.apache.org/bugzilla/show_bug.cgi?id=59761 --- Comment #1 from kubak --- I think the problem is in org.apache.catalina.core.ApplicationHttpRequest, parseParameters() method. line 726: ((ParameterMap) parameters).setLocked(true); In my opinion

Re: Bug that spans tomcat and tomcat-native

On Mon, Jun 27, 2016 at 2:13 PM, Rainer Jung wrote: > Am 27.06.2016 um 18:47 schrieb Nate Clark: >> >> On Mon, Jun 27, 2016 at 12:17 PM, wrote: >>> >>> On Mon, Jun 27, 2016 at 12:04 PM, wrote: On Mon, Jun

Re: Bug that spans tomcat and tomcat-native

Am 27.06.2016 um 18:47 schrieb Nate Clark: On Mon, Jun 27, 2016 at 12:17 PM, wrote: On Mon, Jun 27, 2016 at 12:04 PM, wrote: On Mon, Jun 27, 2016 at 11:54 AM, Rainer Jung wrote: Great analysis. I was really

Re: OpenSSL without APR experiment

2016-06-27 18:27 GMT+02:00 jean-frederic clere : > On 06/27/2016 06:07 PM, Rémy Maucherat wrote: > > 2016-06-27 17:52 GMT+02:00 Mark Thomas : > > > >> Is the performance any different from NIO[2] + tc-native 1.2 + OpenSSL? > >> If I recall correctly, when I

[Bug 59764] New: Character encoding is wrong for requests which mix GET and POST parameters

https://bz.apache.org/bugzilla/show_bug.cgi?id=59764 Bug ID: 59764 Summary: Character encoding is wrong for requests which mix GET and POST parameters Product: Tomcat 8 Version: 8.0.30 Hardware: PC Status: NEW

Re: Bug that spans tomcat and tomcat-native

On Mon, Jun 27, 2016 at 12:17 PM, wrote: > On Mon, Jun 27, 2016 at 12:04 PM, wrote: >> On Mon, Jun 27, 2016 at 11:54 AM, Rainer Jung >> wrote: >>> Great analysis. I was really wondering, what could make the hash map

Re: OpenSSL without APR experiment

On 06/27/2016 06:07 PM, Rémy Maucherat wrote: > 2016-06-27 17:52 GMT+02:00 Mark Thomas : > >> Is the performance any different from NIO[2] + tc-native 1.2 + OpenSSL? >> If I recall correctly, when I asked previously you said APR/native >> generally had better performance. >> >

Re: Bug that spans tomcat and tomcat-native

On Mon, Jun 27, 2016 at 12:04 PM, wrote: > On Mon, Jun 27, 2016 at 11:54 AM, Rainer Jung wrote: >> Great analysis. I was really wondering, what could make the hash map so huge >> and hadn't thought about the hash function as the problem. >> >>

Re: Bug that spans tomcat and tomcat-native

On 27/06/2016 17:04, therealnewo...@gmail.com wrote: > On Mon, Jun 27, 2016 at 11:54 AM, Rainer Jung wrote: Thanks for the feedback. >> So we could probably work around the problem of the poor hashing function by >> passing in IDs that work for hashing (pre-hashed

Re: OpenSSL without APR experiment

2016-06-27 17:52 GMT+02:00 Mark Thomas : > Is the performance any different from NIO[2] + tc-native 1.2 + OpenSSL? > If I recall correctly, when I asked previously you said APR/native > generally had better performance. > The performance is the same as before, there's really

Re: Bug that spans tomcat and tomcat-native

On Mon, Jun 27, 2016 at 11:54 AM, Rainer Jung wrote: > Hi Mark, > > > Am 27.06.2016 um 15:11 schrieb Mark Thomas: >> >> I believe I have an explanation for what is going on that fits both the >> reported behaviour and the proposed fix. >> >> Background >> == >> >>

Re: Bug that spans tomcat and tomcat-native

On Mon, Jun 27, 2016 at 9:11 AM, Mark Thomas wrote: > I believe I have an explanation for what is going on that fits both the > reported behaviour and the proposed fix. > > Background > == > > OpenSSL tracks a list of the most recent errors for each thread in a > hash

Re: Bug that spans tomcat and tomcat-native

Hi Mark, Am 27.06.2016 um 15:11 schrieb Mark Thomas: I believe I have an explanation for what is going on that fits both the reported behaviour and the proposed fix. Background == OpenSSL tracks a list of the most recent errors for each thread in a hash map keyed on the thread

Re: OpenSSL without APR experiment

On 27/06/2016 16:27, Rémy Maucherat wrote: > Hi, > > As part of a university projects, two students from the University of > Neuchatel have worked on OpenSSL support without APR, effectively producing > a JNI wrapper for OpenSSL. > > It works well according to my testing and is pretty much as

[Bug 59761] "No modifications are allowed to a locked ParameterMap" - Tomcat 8.0.32 is not compatible with older versions

https://bz.apache.org/bugzilla/show_bug.cgi?id=59761 kubak changed: What|Removed |Added Hardware|PC |All

[Bug 59761] New: "No modifications are allowed to a locked ParameterMap" - Tomcat 8.0.32 is not compatible with older versions

https://bz.apache.org/bugzilla/show_bug.cgi?id=59761 Bug ID: 59761 Summary: "No modifications are allowed to a locked ParameterMap" - Tomcat 8.0.32 is not compatible with older versions Product: Tomcat 8 Version:

OpenSSL without APR experiment

Hi, As part of a university projects, two students from the University of Neuchatel have worked on OpenSSL support without APR, effectively producing a JNI wrapper for OpenSSL. It works well according to my testing and is pretty much as expected (the JNI interfaces are now much more limited in

Re: Bug that spans tomcat and tomcat-native

I believe I have an explanation for what is going on that fits both the reported behaviour and the proposed fix. Background == OpenSSL tracks a list of the most recent errors for each thread in a hash map keyed on the thread (int_thread_hash in err.c). Reading and writing to this hash

[Bug 57630] Illegal State Exception after start-up

https://bz.apache.org/bugzilla/show_bug.cgi?id=57630 --- Comment #2 from joeg --- (In reply to Mark Thomas from comment #1) > Bugzilla is not a support forum. This is probably just me, nonetheless, I read this as: running TC 8.0.17, no problems upgrade to latest version

[Bug 59758] New: Add http proxy username-password credentials support for ClientEndpoint using system properties

https://bz.apache.org/bugzilla/show_bug.cgi?id=59758 Bug ID: 59758 Summary: Add http proxy username-password credentials support for ClientEndpoint using system properties Product: Tomcat 8 Version: 8.0.x-trunk Hardware:

Early Access builds of JDK 8u112 b01, JDK 9 b124 are available on java.net

Hi Mark, Early Access b124 for JDK 9 is available on java.net, summary of changes are listed here . Early Access b123 (#5178) for JDK 9 with Project Jigsaw is

Re: Bug that spans tomcat and tomcat-native

Thanks. This is all really helpful. I need to spend some time digesting all of this information, reviewing the OpenSSL code and trying to figure out what might be going on. One of the things I am trying to do is to understand why the proposed patch fixes the issue and if an alternative approach

svn commit: r1750291 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Mon Jun 27 07:44:24 2016 New Revision: 1750291 URL: http://svn.apache.org/viewvc?rev=1750291=rev Log: Remove duplicate code. There is no need to release the connection here because the connection is released in subsequent process. Modified:

svn commit: r1750290 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Mon Jun 27 07:43:31 2016 New Revision: 1750290 URL: http://svn.apache.org/viewvc?rev=1750290=rev Log: Remove duplicate code. There is no need to release the connection here because the connection is released in subsequent process. Modified:

svn commit: r1750289 - in /tomcat/tc8.5.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Mon Jun 27 07:42:45 2016 New Revision: 1750289 URL: http://svn.apache.org/viewvc?rev=1750289=rev Log: Remove duplicate code. There is no need to release the connection here because the connection is released in subsequent process. Modified:

svn commit: r1750288 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

Author: kfujino Date: Mon Jun 27 07:41:41 2016 New Revision: 1750288 URL: http://svn.apache.org/viewvc?rev=1750288=rev Log: Remove duplicate code. There is no need to release the connection here because the connection is released in subsequent process. Modified:

buildbot success in on tomcat-8-trunk

The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/667 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1750284 - /tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

Author: kfujino Date: Mon Jun 27 07:08:41 2016 New Revision: 1750284 URL: http://svn.apache.org/viewvc?rev=1750284=rev Log: No-functional change. Remove comment. Null can be returned. Modified:

svn commit: r1750283 - /tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

Author: kfujino Date: Mon Jun 27 07:08:08 2016 New Revision: 1750283 URL: http://svn.apache.org/viewvc?rev=1750283=rev Log: No-functional change. Remove comment. Null can be returned. Modified:

svn commit: r1750282 - /tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

Author: kfujino Date: Mon Jun 27 07:07:36 2016 New Revision: 1750282 URL: http://svn.apache.org/viewvc?rev=1750282=rev Log: No-functional change. Remove comment. Null can be returned. Modified:

svn commit: r1750281 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

Author: kfujino Date: Mon Jun 27 07:07:07 2016 New Revision: 1750281 URL: http://svn.apache.org/viewvc?rev=1750281=rev Log: No-functional change. Remove comment. Null can be returned. Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java