[Bug 47214] Inner classes that are explicitly referenced - should not be anonymous

https://bz.apache.org/bugzilla/show_bug.cgi?id=47214 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1790476 - in /tomcat/trunk: java/org/apache/jasper/runtime/JspWriterImpl.java java/org/apache/jasper/security/SecurityClassLoad.java webapps/docs/changelog.xml

Author: markt Date: Thu Apr 6 22:06:15 2017 New Revision: 1790476 URL: http://svn.apache.org/viewvc?rev=1790476=rev Log: Remove unnecessary privileged block for getLocalizeMessage. I can't see anything in getLocalizeMessage that would trigger a security check. I checked back through the svn

svn commit: r1790465 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:56:15 2017 New Revision: 1790465 URL: http://svn.apache.org/viewvc?rev=1790465=rev Log: Remove unnecessary privileged block from setAttribute. I can't see anything in doSetAttribute that would trigger a security check. Modified:

svn commit: r1790464 - /tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

Author: markt Date: Thu Apr 6 20:55:06 2017 New Revision: 1790464 URL: http://svn.apache.org/viewvc?rev=1790464=rev Log: Remove unnecessary privileged block from removeAttribute. I can't see anything in doRemoveAttribute that would trigger a security check. Modified:

svn commit: r1790463 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:54:03 2017 New Revision: 1790463 URL: http://svn.apache.org/viewvc?rev=1790463=rev Log: Remove unnecessary privileged block from removeAttribute. I can't see anything in doRemoveAttribute that would trigger a security check. Modified:

svn commit: r1790462 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:52:59 2017 New Revision: 1790462 URL: http://svn.apache.org/viewvc?rev=1790462=rev Log: Remove unnecessary privileged block from include. I can't see anything in doInclude that would trigger a security check. Modified:

svn commit: r1790461 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:47:38 2017 New Revision: 1790461 URL: http://svn.apache.org/viewvc?rev=1790461=rev Log: Remove unnecessary privileged block from handlePageException. I can't see anything in doHandlePageException that would trigger a security check. Modified:

svn commit: r1790460 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:44:24 2017 New Revision: 1790460 URL: http://svn.apache.org/viewvc?rev=1790460=rev Log: Remove unnecessary privileged block from getAttributesScope. I can't see anything in doGetAttributeScope that would trigger a security check. Modified:

svn commit: r1790459 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:42:01 2017 New Revision: 1790459 URL: http://svn.apache.org/viewvc?rev=1790459=rev Log: Remove unnecessary privileged block from getAttributeNamesInScope. I can't see anything in doGetAttributeNamesInScope that would trigger a security check. Modified:

svn commit: r1790456 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:32:40 2017 New Revision: 1790456 URL: http://svn.apache.org/viewvc?rev=1790456=rev Log: Remove unnecessary privileged block from forward. I can't see anything in doForward that would trigger a security check. Modified:

svn commit: r1790455 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:29:13 2017 New Revision: 1790455 URL: http://svn.apache.org/viewvc?rev=1790455=rev Log: Remove unnecessary privileged block from findAttribute. I can't see anything in doFindAttribute that would trigger a security check. Modified:

svn commit: r1790454 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:27:06 2017 New Revision: 1790454 URL: http://svn.apache.org/viewvc?rev=1790454=rev Log: Remove unnecessary privileged block from getAttribute. I can't see anything in doGetAttribute that would trigger a security check. Modified:

svn commit: r1790453 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:25:01 2017 New Revision: 1790453 URL: http://svn.apache.org/viewvc?rev=1790453=rev Log: Refactor to reduce duplicate(ish) code Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

svn commit: r1790448 - /tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

Author: markt Date: Thu Apr 6 20:05:07 2017 New Revision: 1790448 URL: http://svn.apache.org/viewvc?rev=1790448=rev Log: Move null check outside privileged block to reduce duplication Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Modified:

svn commit: r1790447 - in /tomcat/trunk/java/org/apache/jasper: runtime/PageContextImpl.java security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 20:00:51 2017 New Revision: 1790447 URL: http://svn.apache.org/viewvc?rev=1790447=rev Log: Refactor to reduce duplicate(ish) code Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java

Re: Hang in TestSsl testRenegotiateWorks for NIO2 (was Re: [VOTE] Release Apache Tomcat 8.0.43)

I am not much close, but r1781988 broke it: "Ensure that executor thread pools used with connectors pre-start the configured minimum number of idle threads." The change itself is OK, but as a consequence the test is now executing with more threads in the executor: Index:

svn commit: r1790443 - in /tomcat/trunk/java/org/apache: catalina/security/SecurityClassLoad.java tomcat/util/net/NioBlockingSelector.java

Author: markt Date: Thu Apr 6 19:43:16 2017 New Revision: 1790443 URL: http://svn.apache.org/viewvc?rev=1790443=rev Log: Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=47214 Replace explicitly referenced anonymous inner classes in NioBlockingSelector.BlockPoller with named inner

svn commit: r1790437 - /tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

Author: markt Date: Thu Apr 6 18:52:00 2017 New Revision: 1790437 URL: http://svn.apache.org/viewvc?rev=1790437=rev Log: Use longer lines No functional change Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Modified:

svn commit: r1790420 - in /tomcat/trunk: java/org/apache/catalina/security/SecurityClassLoad.java java/org/apache/catalina/valves/AbstractAccessLogValve.java test/org/apache/catalina/security/TestSecu

Author: markt Date: Thu Apr 6 15:20:00 2017 New Revision: 1790420 URL: http://svn.apache.org/viewvc?rev=1790420=rev Log: Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=47214 Refactor to remove a switch statement that resulted in the generation of a synthetic class that needed to

[GitHub] tomcat issue #51: #41 Check and update session record if one already exists.

Github user alexisgayte commented on the issue: https://github.com/apache/tomcat/pull/51 I can see the point to lock the table in case of load balancing. But the previous version was deleting and inserting only. Will it not put down the perf as 90% are update? --- If your

[Bug 59871] Impossible to change datetime format in OneLineFormatter/Use sane (sortable) format

https://bz.apache.org/bugzilla/show_bug.cgi?id=59871 --- Comment #11 from Rainer Jung --- (In reply to Andrey Zykov from comment #7) > java.util.logging.ConsoleHandler.formatter = org.apache.juli.OneLineFormatter > org.apache.juli.OneLineFormatter.timeFormat =

[GitHub] tomcat issue #51: #41 Check and update session record if one already exists.

Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/51 Might this be better written as `SELECT ... FOR UPDATE` with either `updateRow` or `ResultSet.insert` if there are no results from the `SELECT`? --- If your project is set up for it, you

buildbot failure in on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/726 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 59871] Impossible to change datetime format in OneLineFormatter/Use sane (sortable) format

https://bz.apache.org/bugzilla/show_bug.cgi?id=59871 --- Comment #10 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Andrey Zykov from comment #9) > (In reply to Michael Osipov from comment #8) > > > > I had the same issue, read he Javadoc: SSS is not supported. You wan't > >

svn commit: r1790379 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/Tomcat.java java/org/apache/tomcat/util/ExceptionUtils.java webapps/

Author: markt Date: Thu Apr 6 11:03:50 2017 New Revision: 1790379 URL: http://svn.apache.org/viewvc?rev=1790379=rev Log: Pre-load the ExceptionUtils class. Since the class is used extensively in error handling, it is prudent to pre-load it to avoid any failure to load this class masking the

svn commit: r1790378 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/Tomcat.java java/org/apache/tomcat/util/ExceptionUtils.java webapps/

Author: markt Date: Thu Apr 6 11:02:57 2017 New Revision: 1790378 URL: http://svn.apache.org/viewvc?rev=1790378=rev Log: Pre-load the ExceptionUtils class. Since the class is used extensively in error handling, it is prudent to pre-load it to avoid any failure to load this class masking the

svn commit: r1790377 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/Tomcat.java java/org/apache/tomcat/util/ExceptionUtils.java webapps/

Author: markt Date: Thu Apr 6 11:02:19 2017 New Revision: 1790377 URL: http://svn.apache.org/viewvc?rev=1790377=rev Log: Pre-load the ExceptionUtils class. Since the class is used extensively in error handling, it is prudent to pre-load it to avoid any failure to load this class masking the

svn commit: r1790376 - in /tomcat/trunk: java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/Tomcat.java java/org/apache/tomcat/util/ExceptionUtils.java webapps/docs/change

Author: markt Date: Thu Apr 6 11:01:42 2017 New Revision: 1790376 URL: http://svn.apache.org/viewvc?rev=1790376=rev Log: Pre-load the ExceptionUtils class. Since the class is used extensively in error handling, it is prudent to pre-load it to avoid any failure to load this class masking the

[Bug 59871] Impossible to change datetime format in OneLineFormatter/Use sane (sortable) format

https://bz.apache.org/bugzilla/show_bug.cgi?id=59871 --- Comment #9 from Andrey Zykov --- (In reply to Michael Osipov from comment #8) > > I had the same issue, read he Javadoc: SSS is not supported. You wan't > "-MM-dd'T'HH:mm:ss". Btw, never go for Z but for ZZZ

[Bug 59871] Impossible to change datetime format in OneLineFormatter/Use sane (sortable) format

https://bz.apache.org/bugzilla/show_bug.cgi?id=59871 --- Comment #8 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Andrey Zykov from comment #7) > (In reply to Mark Thomas from comment #5) > > This is now configurable in 9.0.x (for 9.0.0.M10 onwards) and 8.5.x (for > > 8.5.5) onwards.

[Bug 59871] Impossible to change datetime format in OneLineFormatter/Use sane (sortable) format

https://bz.apache.org/bugzilla/show_bug.cgi?id=59871 --- Comment #7 from Andrey Zykov --- (In reply to Mark Thomas from comment #5) > This is now configurable in 9.0.x (for 9.0.0.M10 onwards) and 8.5.x (for > 8.5.5) onwards. Hello Mark! I'm trying to change timestamp for