[Bug 62287] ValueExpressionImpl#equals is wrong

2018-04-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62287 --- Comment #7 from Mark Struberg --- Thanks for the feedback and applying. Have been sick over the weekend, so sorry for the delay. > I would actually prefer to drop the hashCode because: Yes, you are both right. I first intended to ship a m

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-04-25 Thread koraktor
Github user koraktor commented on the issue: https://github.com/apache/tomcat/pull/108 I added another bunch of patches. One of them implementing a different approach to a cached version representation based on @ChristopherSchultz’s suggestion. Instead of creating zero-padded string

Re: Tomcat 9 Support Java Version clarification

2018-04-25 Thread Coty Sutherland
On Wed, Apr 25, 2018 at 2:14 PM, Mark Thomas wrote: > On 25/04/18 18:07, Coty Sutherland wrote: >> Hi all, >> >> There was a problem discovered on Ubuntu where they're building Tomcat >> 9 with Java 9, but users are using it with Java 8. That is causing >> issues because of changes made in Java 9.

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-04-25 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/108 I think there is a lot of merit in Chris's idea. The concept of some sort of internal pre-computed version string that addresses ordering concerns by zero padding numerical components is one that w

Re: Tomcat 9 Support Java Version clarification

2018-04-25 Thread Mark Thomas
On 25/04/18 18:07, Coty Sutherland wrote: > Hi all, > > There was a problem discovered on Ubuntu where they're building Tomcat > 9 with Java 9, but users are using it with Java 8. That is causing > issues because of changes made in Java 9. One of the Ubuntu folks is > poking around with a patch an

Tomcat 9 Support Java Version clarification

2018-04-25 Thread Coty Sutherland
Hi all, There was a problem discovered on Ubuntu where they're building Tomcat 9 with Java 9, but users are using it with Java 8. That is causing issues because of changes made in Java 9. One of the Ubuntu folks is poking around with a patch and has some details about the issue here https://pasteb

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-04-25 Thread koraktor
Github user koraktor commented on the issue: https://github.com/apache/tomcat/pull/108 @markt-asf @ChristopherSchultz Thanks for your feedback so far and for the partial merge. To be honest I didn’t think about any performance implications or side effects because I didn’

Re: svn commit: r1830087 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/parser/ webapps/docs/ webapps/docs/config/

2018-04-25 Thread Mark Thomas
On 25/04/18 16:31, ma...@apache.org wrote: > Author: markt > Date: Wed Apr 25 15:31:48 2018 > New Revision: 1830087 > > URL: http://svn.apache.org/viewvc?rev=1830087&view=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62273 > Implement configuration options to work-around specific

svn commit: r1830087 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/parser/ webapps/docs/ webapps/docs/config/

2018-04-25 Thread markt
Author: markt Date: Wed Apr 25 15:31:48 2018 New Revision: 1830087 URL: http://svn.apache.org/viewvc?rev=1830087&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62273 Implement configuration options to work-around specification non-compliant user agents (including all the major b

Re: Improvements to Cipher.java

2018-04-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 4/25/18 10:08 AM, Mark Thomas wrote: > On 25/04/18 14:39, Christopher Schultz wrote: > > > >> Any objections? > > +1 to all the above. > > Note a lot of that is public API changes so we should really > deprecate in 9.0.x and remove in

Re: Improvements to Cipher.java

2018-04-25 Thread Mark Thomas
On 25/04/18 14:39, Christopher Schultz wrote: > Any objections? +1 to all the above. Note a lot of that is public API changes so we should really deprecate in 9.0.x and remove in 10.x. Mark - To unsubscribe, e-mail: dev-unsu

Improvements to Cipher.java

2018-04-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I have a few proposals for o.a.t.u.net.openssl.ciphers.Ciphers.java: 1. Remove the isExport method. It is unused anywhere, and practically already covered by other information about the ciphers (e.g. "strength", the "EXPORT" alias, etc.). 2.

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-04-25 Thread ChristopherSchultz
Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/108 The performance of this strategy can be significantly improved by converting the "version number" into a value that can more easily be compared against other values. This can be done in se

svn commit: r1830068 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat/util/http/parser/ test/org/apache/catalina/core/

2018-04-25 Thread markt
Author: markt Date: Wed Apr 25 12:03:32 2018 New Revision: 1830068 URL: http://svn.apache.org/viewvc?rev=1830068&view=rev Log: First step in addressing https://bz.apache.org/bugzilla/show_bug.cgi?id=62273 This commit actually tightens up the parsing by validating each part of the request target i

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-04-25 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/108 I have applied the optimisation commit (thanks) but not the ordering changes. The patch changes the order for undeploy without changing the order for version mapping. This will lead to une

svn commit: r1830054 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java

2018-04-25 Thread markt
Author: markt Date: Wed Apr 25 08:25:49 2018 New Revision: 1830054 URL: http://svn.apache.org/viewvc?rev=1830054&view=rev Log: Optimise Patch provided by Sebastian Staudt Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/HostConfig.jav

svn commit: r1830052 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java

2018-04-25 Thread markt
Author: markt Date: Wed Apr 25 08:24:50 2018 New Revision: 1830052 URL: http://svn.apache.org/viewvc?rev=1830052&view=rev Log: Optimise Patch provided by Sebastian Staudt Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/HostConfig.jav

svn commit: r1830053 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java

2018-04-25 Thread markt
Author: markt Date: Wed Apr 25 08:25:11 2018 New Revision: 1830053 URL: http://svn.apache.org/viewvc?rev=1830053&view=rev Log: Optimise Patch provided by Sebastian Staudt Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/startup/HostConfig.jav

svn commit: r1830051 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2018-04-25 Thread markt
Author: markt Date: Wed Apr 25 08:24:31 2018 New Revision: 1830051 URL: http://svn.apache.org/viewvc?rev=1830051&view=rev Log: Optimise Patch provided by Sebastian Staudt Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/apache/catalina/s

svn commit: r1830050 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http11/Http11Processor.java java/org/apache/coyote/http11/LocalStrings.properties

2018-04-25 Thread markt
Author: markt Date: Wed Apr 25 08:11:26 2018 New Revision: 1830050 URL: http://svn.apache.org/viewvc?rev=1830050&view=rev Log: Better i18n in request target processing Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/Http11Processor.java