buildbot success in on tomcat-trunk

2018-08-10 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3512 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

[Bug 62611] Compress log files after rotation

2018-08-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62611 --- Comment #1 from Christopher Schultz --- Be careful; sometimes log files can be large and compressing them can take a while. I would recommend against adding more code to Tomcat that solves a problem already solved by better logging framewo

[Bug 62614] Async servlet over HTTP/2 WriteListener does not work because onWritePossible is never called back again

2018-08-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614 Dapeng Zhang changed: What|Removed |Added Summary|Async servlet over HTTP/2 |Async servlet over HTTP/2

buildbot failure in on tomcat-trunk

2018-08-10 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3511 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

[Bug 62614] Async servlet over HTTP/2 WriteListener does not work because outputstream.write is hanging even it's ready

2018-08-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614 Dapeng Zhang changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

[GitHub] tomcat pull request #117: Enhance the CATALINA_BASE documentation

2018-08-10 Thread markt-asf
Github user markt-asf commented on a diff in the pull request: https://github.com/apache/tomcat/pull/117#discussion_r209308073 --- Diff: webapps/docs/introduction.xml --- @@ -89,6 +80,122 @@ same as $CATALINA_HOME. + + Throughout the documentation, there a

[GitHub] tomcat pull request #117: Enhance the CATALINA_BASE documentation

2018-08-10 Thread markt-asf
Github user markt-asf commented on a diff in the pull request: https://github.com/apache/tomcat/pull/117#discussion_r209306777 --- Diff: webapps/docs/introduction.xml --- @@ -89,6 +80,122 @@ same as $CATALINA_HOME. + + Throughout the documentation, there a

svn commit: r1837820 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:49:08 2018 New Revision: 1837820 URL: http://svn.apache.org/viewvc?rev=1837820&view=rev Log: Remove ServletException from declaration of Tomcat.addWebapp(String,String) since it is never thrown. Patch provided by Tzafrir. Modified: tomcat/tc7.0.x/trunk/ (p

svn commit: r1837819 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:47:29 2018 New Revision: 1837819 URL: http://svn.apache.org/viewvc?rev=1837819&view=rev Log: Remove ServletException from declaration of Tomcat.addWebapp(String,String) since it is never thrown. Patch provided by Tzafrir. Modified: tomcat/tc8.5.x/trunk/ (p

[GitHub] tomcat pull request #114: Remove throws declaration of an exception which is...

2018-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/114 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1837818 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:46:39 2018 New Revision: 1837818 URL: http://svn.apache.org/viewvc?rev=1837818&view=rev Log: Remove ServletException from declaration of Tomcat.addWebapp(String,String) since it is never thrown. Patch provided by Tzafrir. This closes #114 Modified: tomcat/tr

[Bug 62614] Async servlet over HTTP/2 WriteListener does not work because outputstream.write is hanging even it's ready

2018-08-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614 --- Comment #2 from Dapeng Zhang --- My fault again, sorry about that. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev

svn commit: r1837817 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:42:55 2018 New Revision: 1837817 URL: http://svn.apache.org/viewvc?rev=1837817&view=rev Log: Typo Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java URL:

svn commit: r1837816 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/resources/ java/org/apache/catalina/filters/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ java/org

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:41:59 2018 New Revision: 1837816 URL: http://svn.apache.org/viewvc?rev=1837816&view=rev Log: Correct various spelling errors throughout the source code and documentation. Patch provided by Kazuhiro Sera. Modified: tomcat/tc7.0.x/trunk/ (props changed) t

svn commit: r1837816 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/resources/ java/org/apache/catalina/filters/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ java/org

2018-08-10 Thread markt
Propchange: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/fileupload/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Fri Aug 10 15:41:59 2018 @@ -1,4 +1,4 @@ /commons/proper/fileupload/trunk/src/main/java/org/a

svn commit: r1837815 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:40:03 2018 New Revision: 1837815 URL: http://svn.apache.org/viewvc?rev=1837815&view=rev Log: Typo Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaMa

svn commit: r1837814 - in /tomcat/tc8.5.x/trunk: ./ java/javax/servlet/resources/ java/org/apache/catalina/connector/ java/org/apache/catalina/filters/ java/org/apache/catalina/ha/session/ java/org/ap

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:30:30 2018 New Revision: 1837814 URL: http://svn.apache.org/viewvc?rev=1837814&view=rev Log: Correct various spelling errors throughout the source code and documentation. Patch provided by Kazuhiro Sera. Modified: tomcat/tc8.5.x/trunk/ (props changed) t

svn commit: r1837813 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:29:21 2018 New Revision: 1837813 URL: http://svn.apache.org/viewvc?rev=1837813&view=rev Log: (empty) Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat

svn commit: r1837812 - in /tomcat/trunk/java/org/apache: coyote/http11/filters/SavedRequestInputFilter.java tomcat/util/buf/B2CConverter.java tomcat/util/buf/ByteChunk.java tomcat/util/buf/C2BConverte

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:26:16 2018 New Revision: 1837812 URL: http://svn.apache.org/viewvc?rev=1837812&view=rev Log: More typos reported by Kazuhiro Sera. Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java tomcat/trunk/java/org/apache/tomc

[GitHub] tomcat issue #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread seratch
Github user seratch commented on the issue: https://github.com/apache/tomcat/pull/118 Thank you for merging the changes. 👍 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

svn commit: r1837810 - /tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/FindBookSimpleTag.java

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:18:16 2018 New Revision: 1837810 URL: http://svn.apache.org/viewvc?rev=1837810&view=rev Log: Another typo reported by Kazuhiro Sera. Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/FindBookSimpleTag.java Modified: tomcat/tru

svn commit: r1837809 - in /tomcat/trunk: java/javax/servlet/resources/ java/org/apache/catalina/connector/ java/org/apache/catalina/filters/ java/org/apache/catalina/ha/session/ java/org/apache/catali

2018-08-10 Thread markt
Author: markt Date: Fri Aug 10 15:16:11 2018 New Revision: 1837809 URL: http://svn.apache.org/viewvc?rev=1837809&view=rev Log: Correct various spelling errors throughout the source code and documentation. Patch provided by Kazuhiro Sera. This closes #118 Modified: tomcat/trunk/java/javax/serv

[GitHub] tomcat pull request #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/118 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread markt-asf
Github user markt-asf commented on a diff in the pull request: https://github.com/apache/tomcat/pull/118#discussion_r209292288 --- Diff: java/org/apache/catalina/ha/session/SessionMessageImpl.java --- @@ -144,7 +144,7 @@ public String getEventTypeString() case EVT_G

[GitHub] tomcat pull request #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread markt-asf
Github user markt-asf commented on a diff in the pull request: https://github.com/apache/tomcat/pull/118#discussion_r209290720 --- Diff: java/org/apache/tomcat/dbcp/dbcp2/managed/ManagedConnection.java --- @@ -1,4 +1,4 @@ -/** +vi /** --- End diff -- No worries

[GitHub] tomcat pull request #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread seratch
Github user seratch commented on a diff in the pull request: https://github.com/apache/tomcat/pull/118#discussion_r209289321 --- Diff: java/org/apache/catalina/ha/session/SessionMessageImpl.java --- @@ -144,7 +144,7 @@ public String getEventTypeString() case EVT_GET

[GitHub] tomcat pull request #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread seratch
Github user seratch commented on a diff in the pull request: https://github.com/apache/tomcat/pull/118#discussion_r209289041 --- Diff: java/org/apache/tomcat/dbcp/dbcp2/managed/ManagedConnection.java --- @@ -1,4 +1,4 @@ -/** +vi /** --- End diff -- I will remov

[GitHub] tomcat issue #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/118 Thanks for this. Working through a review of the patch now. Note that there are some files that we can't change such as the Oracle provided XSDs. --- -

[Bug 62615] WsSession leaks if java.net.SocketTimeoutException occurs after session.close()

2018-08-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62615 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 62614] Async servlet over HTTP/2 WriteListener does not work because outputstream.write is hanging even it's ready

2018-08-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[GitHub] tomcat pull request #118: Fix typos detected by github.com/client9/misspell

2018-08-10 Thread seratch
GitHub user seratch opened a pull request: https://github.com/apache/tomcat/pull/118 Fix typos detected by github.com/client9/misspell Fixing typos is sometimes very hard. It's not so easy to visually review them. Recently, I discovered a very useful tool for it, [misspell](https:/

[Bug 62603] Changes in tag files are not reflected in the rendered view or they end up with a java.lang.NoClassDefFoundError

2018-08-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62603 --- Comment #6 from Jordi --- I've reviewed the changes and everything looks good(I will test/debug it also next week) Thanks -- You are receiving this mail because: You are the assignee for the bug. -

svn commit: r1837788 - /tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java

2018-08-10 Thread fschumacher
Author: fschumacher Date: Fri Aug 10 10:10:18 2018 New Revision: 1837788 URL: http://svn.apache.org/viewvc?rev=1837788&view=rev Log: Spacepolice Modified: tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java Modified: tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java URL: htt

svn commit: r1837787 - in /tomcat/trunk: java/org/apache/catalina/realm/JAASRealm.java webapps/docs/changelog.xml

2018-08-10 Thread fschumacher
Author: fschumacher Date: Fri Aug 10 10:08:54 2018 New Revision: 1837787 URL: http://svn.apache.org/viewvc?rev=1837787&view=rev Log: Simplify construction of appName from container name in JAASRealm. There is no need to add a slash in front of the container name as the method makeLegalForJAAS wil

svn commit: r1837786 - in /tomcat/trunk: java/org/apache/catalina/filters/CorsFilter.java webapps/docs/changelog.xml

2018-08-10 Thread fschumacher
Author: fschumacher Date: Fri Aug 10 10:00:18 2018 New Revision: 1837786 URL: http://svn.apache.org/viewvc?rev=1837786&view=rev Log: Use short circuit logic to prevent potential NPE in CorsFilter. The same logic is used a few lines below, so it was most probably intended that way anyways. Modif