[GitHub] [tomcat] alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299284882 ## File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java ## @@ -344,6 +345,29 @@

[GitHub] [tomcat] alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299276651 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1271,6 +1276,11 @@

[GitHub] [tomcat] alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299276368 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1252,6 +1252,11 @@

[GitHub] [tomcat] zhanhb commented on issue #175: Apply the suggestion in rfc7233

zhanhb commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507436005 Good job, there is no issue with the range request now. This is an automated message from

[tomcat] branch 8.5.x updated: Align with 9.0.x. Add additional translations

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 1cee91d Align with 9.0.x. Add additional

[tomcat] branch 7.0.x updated (0ef94ce -> 07b0f95)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 0ef94ce Align with 8.5.x new 7adb47a Align with 8.5.x. Add additional translations new 07b0f95 Align with

[tomcat] 02/02: Align with 8.5.x. Remove unused keys, update/add translations

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 07b0f952b4d5cd5db10780bff1c78c2d8f03577a Author: Mark Thomas AuthorDate: Mon Jul 1 09:23:44 2019 +0100 Align with

[tomcat] 01/02: Align with 8.5.x. Add additional translations

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7adb47ae0c29034e0d3a8ec38655fa6aaef6e711 Author: Mark Thomas AuthorDate: Mon Jul 1 09:03:54 2019 +0100 Align with

[GitHub] [tomcat] markt-asf commented on issue #175: Apply the suggestion in rfc7233

markt-asf commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507409540 I think everything is complete now. Feel free to re-open if you spot something I missed.

[GitHub] [tomcat] markt-asf closed pull request #175: Apply the suggestion in rfc7233

markt-asf closed pull request #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[tomcat] 01/05: Make partial PUT processing optional but still enabled by default

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bb497d62e1405c8ba56d1910672d8c476e0b8dba Author: Mark Thomas AuthorDate: Mon Jul 1 13:28:31 2019 +0100 Make partial

[tomcat] 05/05: Improve parsing of Content-Range headers

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d1f58003a97af79df452cdbe5e94052acc4b7188 Author: Mark Thomas AuthorDate: Mon Jul 1 21:16:15 2019 +0100 Improve

[tomcat] 03/05: Fix configuration of partial PUT

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f9afd7a0be49f974c50db49cd9a12916c9fff4b2 Author: Mark Thomas AuthorDate: Mon Jul 1 17:08:06 2019 +0100 Fix

[tomcat] 02/05: Remove unnecessary test

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 873b25b0c24b71a04b22439487e401b74decb309 Author: Mark Thomas AuthorDate: Mon Jul 1 16:15:47 2019 +0100 Remove

[tomcat] branch master updated (92585d3 -> d1f5800)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 92585d3 If-Range must use exact match on dates (allowing for resolution) new bb497d6 Make partial PUT

[tomcat] 04/05: Remove completed TODO

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3992dc4559e8487f55723dee3e476d1faa1126a1 Author: Mark Thomas AuthorDate: Mon Jul 1 17:12:01 2019 +0100 Remove

[GitHub] [tomcat] markt-asf commented on issue #175: Apply the suggestion in rfc7233

markt-asf commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507304794 Thanks for the the review. I had mis-remembered how partial PUTs were implemented. I'll take another pass at the patch.

Re: [GitHub] [tomcat] alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 6/29/19 16:01, Mark Thomas wrote: > On 29/06/2019 02:26, GitBox wrote: >> alpire opened a new pull request #176: CoyoteAdapter: fix >> out-of-bounds read in checkNormalize URL: >> https://github.com/apache/tomcat/pull/176 >> >> >> On

[GitHub] [tomcat] zhanhb edited a comment on issue #175: Apply the suggestion in rfc7233

zhanhb edited a comment on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507295587 For a put request, usually it won't have a header 'Range', The header specified in rfc 2616 is 'Content-Range'. What will happen to a put request

[GitHub] [tomcat] zhanhb commented on issue #175: Apply the suggestion in rfc7233

zhanhb commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507295587 For a put request, usually it won't have a header 'Range', The header specified in rfc 2616 is 'Content-Range'. What will happen to a put request if

Re: [VOTE] Release Apache Tomcat Native 1.2.23

On Wed, Jun 26, 2019 at 3:20 PM Mark Thomas wrote: > Version 1.2.23 includes the following changes compared to 1.2.21 > > - Fix crashes associated with the use of a CRL > > - Add support for TLS key logging. Patch provided by John Kelly. > > - Make Windows 7 the default build target on Windows >

[Bug 48392] jdbc-pool is not returning the proxied connection in resultSet and statement

https://bz.apache.org/bugzilla/show_bug.cgi?id=48392 --- Comment #9 from Dano George --- The Connection (by the connection pool) appears to be a logical connection, while the close() method is not used to close the connection, virtually, it rather performs cleanup like closing Statement,

Re: [VOTE] Release Apache Tomcat Native 1.2.23

Hi all, Just a reminder that this vote is still open. Thanks, Mark On 26/06/2019 14:20, Mark Thomas wrote: > Version 1.2.23 includes the following changes compared to 1.2.21 > > - Fix crashes associated with the use of a CRL > > - Add support for TLS key logging. Patch provided by John

[tomcat] 02/02: If-Range must use exact match on dates (allowing for resolution)

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 92585d37b9b5a2ee5b88c365032db4b6e1be1452 Author: Mark Thomas AuthorDate: Mon Jul 1 11:27:35 2019 +0100 If-Range

[tomcat] branch master updated (3c1059e -> 92585d3)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 3c1059e Make package versions derive from the upstream projects versions used new f79b542 Ignore Range

[tomcat] 01/02: Ignore Range headers that use unknown units as per RFC 7233.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f79b5424c498d1cfde1aed6de85285b31484af06 Author: Mark Thomas AuthorDate: Mon Jul 1 11:17:45 2019 +0100 Ignore Range

[GitHub] [tomcat] markt-asf commented on issue #175: Apply the suggestion in rfc7233

markt-asf commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507209534 Thanks. I have applied 2 of the 3 changes to 9.0.x (range units and etag) with some additional refactoring / clean-up as well as additional comments.

[tomcat] 02/02: Align with 8.5.x

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0ef94cefaa6ae86791806e83d5f6161786231803 Author: Mark Thomas AuthorDate: Sun Jun 30 23:53:57 2019 +0100 Align with

[tomcat] 01/02: Align with 8.5.x.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 45170f0138845e609869afb70564b1023ff21711 Author: Mark Thomas AuthorDate: Sun Jun 30 23:41:22 2019 +0100 Align with

[tomcat] branch 7.0.x updated (bf5e555 -> 0ef94ce)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from bf5e555 Revert changes that broke compilation with source=1.6 new 45170f0 Align with 8.5.x. new 0ef94ce

Re: [GitHub] [tomcat] alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

On 29/06/2019 21:01, Mark Thomas wrote: > On 29/06/2019 02:26, GitBox wrote: >> alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read >> in checkNormalize >> URL: https://github.com/apache/tomcat/pull/176 >> >> >>On malformed requests, checkNormalize would throw an