Re: buildbot failure in on tomcat-trunk

2019-11-08 Thread Konstantin Kolinko
сб, 9 нояб. 2019 г. в 02:32, Michael Osipov : > > Am 2019-11-09 um 00:19 schrieb build...@apache.org: > > The Buildbot has detected a new failure on builder tomcat-trunk while > > building tomcat. Full details are available at: > > https://ci.apache.org/builders/tomcat-trunk/builds/4713 > >

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #17 from Christopher Schultz --- (In reply to Michael Osipov from comment #15) > (In reply to Christopher Schultz from comment #14) > > This should all really be replaced by external stylesheets, for a few > > reasons: > > > > 1.

Re: buildbot failure in on tomcat-trunk

2019-11-08 Thread Michael Osipov
Am 2019-11-09 um 00:19 schrieb build...@apache.org: The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4713 Buildbot URL: https://ci.apache.org/ Buildslave for this

buildbot failure in on tomcat-85-trunk

2019-11-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2010 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

buildbot failure in on tomcat-trunk

2019-11-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4713 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[Bug 63909] ExpiresFilter not account for 304 when content-type is null

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63909 --- Comment #1 from some.java@gmail.com --- “CustomExpiresFilter” should be “ExpiresFilter” in original config example in description. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 Michael Osipov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 7.0.x updated: BZ 63905: Clean up Tomcat CSS

2019-11-08 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 4b78394 BZ 63905: Clean up Tomcat CSS 4b78394

[tomcat] branch 8.5.x updated: BZ 63905: Clean up Tomcat CSS

2019-11-08 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 98b021b BZ 63905: Clean up Tomcat CSS 98b021b

[tomcat] branch master updated: BZ 63905: Clean up Tomcat CSS

2019-11-08 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 69602cb BZ 63905: Clean up Tomcat CSS

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #15 from Michael Osipov --- (In reply to Christopher Schultz from comment #14) > (In reply to Michael Osipov from comment #13) > > I don't see how "securing the ErrorReportValve" is related to the served > > CSS. > > It's a

[tomcat] 01/02: Align with 8.5.x/9.0.x

2019-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 661f583a14dd509e39d084dc50c7c94ffc7993fd Author: Mark Thomas AuthorDate: Fri Nov 8 22:10:46 2019 + Align with

[tomcat] branch 7.0.x updated (c88cf8f -> a354f2d)

2019-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from c88cf8f Improve clean-up after an OOME during request processing new 661f583 Align with 8.5.x/9.0.x new

[tomcat] 02/02: Fix some Javadoc warnings with Java 13

2019-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a354f2d6dcf6c8ba5ecedbeb6b42a5d6dd5d986c Author: Mark Thomas AuthorDate: Fri Nov 8 22:13:59 2019 + Fix some

[Bug 63909] New: ExpiresFilter not account for 304 when content-type is null

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63909 Bug ID: 63909 Summary: ExpiresFilter not account for 304 when content-type is null Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC OS: Linux

Re: [tomcat] branch master updated: Polish

2019-11-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, That's some nice indenting work, there. No big plans for the weekend, eh? :) - -chris On 11/8/19 17:07, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > markt pushed a commit to branch

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #14 from Christopher Schultz --- (In reply to Michael Osipov from comment #13) > I don't see how "securing the ErrorReportValve" is related to the served CSS. It's a *thin* argument related to fingerprinting the server's version.

[tomcat] branch 8.5.x updated: Polish

2019-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a12a166 Polish a12a166 is described below commit

[tomcat] branch master updated: Polish

2019-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 58898a5 Polish 58898a5 is described below

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #13 from Michael Osipov --- I don't see how "securing the ErrorReportValve" is related to the served CSS. However, I have found a few more nits I am going through locally now where the CSS will now cleanly apply to the

[tomcat] 01/01: BZ 63905: Clean up Tomcat CSS

2019-11-08 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch BZ-63905/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0346831b2abacc706a75f6e9807a449c89964ae4 Author: Michael Osipov AuthorDate: Thu Nov 7 22:21:27 2019 +0100

[tomcat] branch BZ-63905/9.0.x updated (de12b4d -> 0346831)

2019-11-08 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a change to branch BZ-63905/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. discard de12b4d BZ 63905: Clean up Tomcat CSS add 67909e0 Add comment to explain the cleanup add

[GitHub] [tomcat] michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-11-08 Thread GitBox
michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#issuecomment-551985916 That will be fine for me. Unless community does not insinst on tests. I won't able to work on the tests on Monday.

[GitHub] [tomcat] rmaucher commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-11-08 Thread GitBox
rmaucher commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#issuecomment-551978388 You should commit this rather quickly or you're going to miss the next tags.

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #12 from Mark Thomas --- Probably not. The argument against it was made in bug 56383. I'm not convinced. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #11 from Remy Maucherat --- (In reply to Christopher Schultz from comment #10) > CSS is not a requirement for a valid HTML document. There is no conflict > between removing CSS entirely and returning a valid HTML document along

[tomcat] branch 8.5.x updated: Fix logic that meant AJP was not always non-blocking between requests

2019-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 420c883 Fix logic that meant AJP was not always

[tomcat] branch master updated: Fix logic that meant AJP was not always non-blocking between requests

2019-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ffb553c Fix logic that meant AJP was not always

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #10 from Christopher Schultz --- (In reply to Michael Osipov from comment #6) > (In reply to Christopher Schultz from comment #4) > > Or we could just drop the CSS because... who cares? If the response entity > > is >

[Bug 63859] AJP cping/cpong mode failing on Tomcat 9.x

2019-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63859 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #14 from Mark

[GitHub] [tomcat] michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-11-08 Thread GitBox
michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#issuecomment-551842002 If there are no further objections I'd add test code next week and merge this into master.

[tomcat] branch master updated: Add comment to explain the cleanup

2019-11-08 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 67909e0 Add comment to explain the cleanup