[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #35 from Christopher Schultz --- (In reply to Michael Osipov from comment #34) > Awesome, can you retry with Java 8? This is Oracle 1.8.0_181. Selector Provider: sun.nio.ch.KQueueSelectorProvider@16e15b65 16,10461 32,5245 64,2696

[Bug 63875] Tomcat 8.5.46, APR/libtcnative crashes

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63875 Christopher Schultz changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[Bug 63875] Tomcat 8.5.46, APR/libtcnative crashes

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63875 sachin.pip...@globallogic.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED

[tomcat] branch 8.5.x updated: Properly calculate dynamic parts of ErrorReportValve response for TestHttp2InitialConnection

2019-11-13 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f056ef1 Properly calculate dynamic parts of

Re: [tomcat] branch master updated: Fix test fallout of BZ 63905

2019-11-13 Thread Michael Osipov
Am 2019-11-13 um 17:48 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 11/9/19 05:58, micha...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository

[tomcat] branch master updated: Properly calculate dynamic parts of ErrorReportValve response for TestHttp2InitialConnection

2019-11-13 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new df08451 Properly calculate dynamic parts of

[tomcat] branch master updated: Polish. Trivial clean-up while looking at 9.0.x/8.5.x/7.0.x diff

2019-11-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 335502a Polish. Trivial clean-up while looking

Re: [tomcat] branch master updated: Fix test fallout of BZ 63905

2019-11-13 Thread Michael Osipov
Am 2019-11-13 um 17:48 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 11/9/19 05:58, micha...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository

Re: [tomcat] branch master updated: BZ 63905: Clean up Tomcat CSS

2019-11-13 Thread Michael Osipov
Am 2019-11-13 um 17:41 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 11/8/19 17:49, micha...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository

[Bug 63867] Add option for reason phrase

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63867 --- Comment #19 from Michael Osipov --- The problem also is that the only would fix the symptom and push the remedy even more into the future where the problem will get worse. -- You are receiving this mail because: You are the assignee for

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #34 from Michael Osipov --- (In reply to Christopher Schultz from comment #33) > (In reply to Rainer Jung from comment #23) > > Plus: performance behavior plus provider string would also be interesting > > for MacOS. > > Some info

[tomcat] branch master updated: Fix SpotBugs warnings

2019-11-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 35e4aaa Fix SpotBugs warnings 35e4aaa is

[Bug 63865] Cookie Attribute SameSite=None is default to unset in Chrome browser

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63865 --- Comment #5 from Remy Maucherat --- There's a release batch almost every month, so please stop asking "when" ... -- You are receiving this mail because: You are the assignee for the bug.

[tomcat] branch master updated: Add explicit list of missing Graal features for Tomcat

2019-11-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 27d82e2 Add explicit list of missing Graal

[Bug 63865] Cookie Attribute SameSite=None is default to unset in Chrome browser

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63865 --- Comment #4 from Christopher Schultz --- (In reply to Pushyami Gundala from comment #3) > Thanks for the fix. When will 8.5.48 going to be released? as Chrome 80 is > scheduled to release Feb 4, 2020 >

[Bug 63867] Add option for reason phrase

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63867 --- Comment #18 from Christopher Schultz --- (In reply to Nathan Clement from comment #17) > We operate a REST API and thousands of corporate/government clients connect > to our API. We know that some of these clients rely on the reason

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #33 from Christopher Schultz --- (In reply to Rainer Jung from comment #23) > Plus: performance behavior plus provider string would also be interesting > for MacOS. Some info from MacOS: $ java -showversion

Re: [PROPOSAL] Tomcat 10: Drop APR Connector

2019-11-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 11/11/19 14:20, Rémy Maucherat wrote: > On Mon, Nov 11, 2019 at 7:47 PM Michael Osipov > mailto:micha...@apache.org>> wrote: > > To revive this, why APR is stil important: > > https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 > >

Re: [tomcat] branch master updated: Fix test fallout of BZ 63905

2019-11-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 11/9/19 05:58, micha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > michaelo pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #19 from Christopher Schultz --- (In reply to Michael Osipov from comment #18) > (In reply to Christopher Schultz from comment #17) > > (In reply to Michael Osipov from comment #15) > > > (In reply to Christopher Schultz from

Re: [tomcat] branch master updated: BZ 63905: Clean up Tomcat CSS

2019-11-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 11/8/19 17:49, micha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > michaelo pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #32 from Michael Osipov --- I am down now to: $ for file in output/build/logs/*TestNonBlockingAPI* ; do head -2 $file; done Testsuite: org.apache.catalina.nonblocking.TestNonBlockingAPI Tests run: 9, Failures: 0, Errors: 0,

[Bug 63865] Cookie Attribute SameSite=None is default to unset in Chrome browser

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63865 --- Comment #3 from Pushyami Gundala --- Thanks for the fix. When will 8.5.48 going to be released? as Chrome 80 is scheduled to release Feb 4, 2020 https://www.chromestatus.com/features/schedule -- You are receiving this mail because: You

[Bug 63922] The Java NMT (Native Memory Trackingú cannot be activated by Tomcat 7, 8 or 9 windows service

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63922 --- Comment #2 from Artur Linhart --- OK, thank you for correcting me. See the issue https://issues.apache.org/jira/browse/DAEMON-412 -- You are receiving this mail because: You are the assignee for the bug.

Tagging 9.0.28 and 8.5.48

2019-11-13 Thread Mark Thomas
Hi all, Rather later than I had hoped, it looks like we are in a position to tag 9.0.28 and 8.5.48. As usual, I'll run the unit tests on various platforms and, assuming all is well, tag shortly afterwards. Mark - To

[Bug 63922] The Java NMT (Native Memory Trackingú cannot be activated by Tomcat 7, 8 or 9 windows service

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63922 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #31 from Mark Thomas --- Thanks. Missed that. Fixed now. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

[tomcat] branch 8.5.x updated: Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63916

2019-11-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9df8cae Additional fix for

[tomcat] branch master updated: Additional fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63916

2019-11-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4f38e7f Additional fix for

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #30 from Michael Osipov --- (In reply to Michael Osipov from comment #29) > (In reply to Mark Thomas from comment #28) > > Fixed in: > > - master for 9.0.28 onwards > > - 8.5.x for 8.5.48 onwards > > I see now > > $ for file in

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #29 from Michael Osipov --- (In reply to Mark Thomas from comment #28) > Fixed in: > - master for 9.0.28 onwards > - 8.5.x for 8.5.48 onwards I see now $ for file in output/build/logs/*TestNonBlockingAPI* ; do head -2 $file; done

[Bug 63922] The Java NMT (Native Memory Trackingú cannot be activated by Tomcat 7, 8 or 9 windows service

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63922 Artur Linhart changed: What|Removed |Added Summary|The Native Memory Tracking |The Java NMT (Native Memory

[Bug 63922] New: The Native Memory Tracking cannot be activated by Tomcat 7, 8 or 9 windows service

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63922 Bug ID: 63922 Summary: The Native Memory Tracking cannot be activated by Tomcat 7, 8 or 9 windows service Product: Tomcat 9 Version: unspecified Hardware: PC

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 speed up test

2019-11-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 8475c0f Fix

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 speed up test

2019-11-13 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 38e7f28 Fix

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #27 from Mark Thomas --- I have been mixing up socket.txBufSize and socket.appWriteBufSize. My testing shows that socket.appWriteBufSize has no measurable impact on performance of the stand-alone test. Performance of the

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #26 from Michael Osipov --- A local change to Tomcat master: > diff --git a/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java > b/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java > index

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #25 from Michael Osipov --- Here are new test results, is the terminal/consumer (telnet) too slow? For both: telnet localhost > /dev/null FreeBSD: All telnet output has been redirected to /dev/null. default: Writing 10MB

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #24 from Michael Osipov --- (In reply to Rainer Jung from comment #22) > According to the Javadoc, the Selector has various impls and is encapsulated > via a SelectorProvider. The chosen provider decides about which system api > is

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #23 from Rainer Jung --- Plus: performance behavior plus provider string would also be interesting for MacOS. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #22 from Rainer Jung --- According to the Javadoc, the Selector has various impls and is encapsulated via a SelectorProvider. The chosen provider decides about which system api is being used (poll, epoll, event ports, kqueue, ...).

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #21 from Michael Osipov --- New test results: RHEL: 8 KiB: Writing 10MB took [1601] milliseconds; nothing added default: Writing 10MB took [1176] milliseconds HP-UX: 8 KiB: Writing 10MB took [89460] milliseconds; add 68 ms for

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #20 from Remy Maucherat --- With NIO2, when I set a really low send buffer (I tried as low as 32 bytes) it does change what the read/write logs from TestNonBlockingAPI look like as expected, but the "performance" does not go down

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #19 from Mark Thomas --- Hmm. No change at all with a Executor. The cut-off for buffer size between good and bad performance is still exactly 4537 bytes. That doesn't match with what I thought was going on. -- You are receiving

[Bug 48392] jdbc-pool is not returning the proxied connection in resultSet and statement

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=48392 --- Comment #9 from KMI --- Hi, I'm using ddlutils 1.0 and tomcat jdbc pool 1.0.7.1 and I getting an error due to a connection is closed and the pool is not aware of that. Basically the issue is that ddlutils has a resultset iterator and

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #18 from Mark Thomas --- Tomcat is calling write until 0 bytes are written before adding to the poller so that isn't what is going on here. (In reply to Remy Maucherat from comment #12) > By default on my Linux the socket send

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #17 from Michael Osipov --- (In reply to Mark Thomas from comment #14) > I think I have a fix. I've updated the test to keep writing until the > non-blocking write returns 0 bytes written and only then add the connection > to the

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #16 from Michael Osipov --- (In reply to Remy Maucherat from comment #15) > The performance numbers would still indicate FreeBSD has a specific poller > issue of some kind though, the difference is too large there. I will inquire

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #15 from Remy Maucherat --- The performance numbers would still indicate FreeBSD has a specific poller issue of some kind though, the difference is too large there. -- You are receiving this mail because: You are the assignee for

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #14 from Mark Thomas --- I think I have a fix. I've updated the test to keep writing until the non-blocking write returns 0 bytes written and only then add the connection to the Poller. Performance is back to normal for me even

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #13 from Michael Osipov --- (In reply to Mark Thomas from comment #11) > Simpler test case that reproduces the issue > > https://github.com/markt-asf/tomcat-bugs/blob/master/src/java/org/apache/ > tomcat/Bug63916NioPoller.java >

[Bug 63916] org.apache.catalina.nonblocking.TestNonBlockingAPI abysmally slow with NIO/NIO2 on FreeBSD

2019-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63916 --- Comment #12 from Remy Maucherat --- By default on my Linux the socket send buffer size is 2304. For NIO to have the same "performance" and behavior running the test [as seen with the debug logs] as NIO2, the send buffer size needs to be