[Bug 51436] ServletRequestListener fails to access request parameters when an Expect-Header is sent

2019-12-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=51436 iamyale...@gmail.com changed: What|Removed |Added URL||www.eastnaija.com -- You are

buildbot failure in on tomcat-trunk

2019-12-04 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4797 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 8.5.x updated: Correct typo in changelog.

2019-12-04 Thread kkolinko
This is an automated email from the ASF dual-hosted git repository. kkolinko pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 5ee3182 Correct typo in changelog. 5ee3182 is

[tomcat] branch master updated: Correct typo in changelog.

2019-12-04 Thread kkolinko
This is an automated email from the ASF dual-hosted git repository. kkolinko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 284fb0e Correct typo in changelog. 284fb0e

[GitHub] [tomcat] markt-asf commented on a change in pull request #223: Log compression

2019-12-04 Thread GitBox
markt-asf commented on a change in pull request #223: Log compression URL: https://github.com/apache/tomcat/pull/223#discussion_r353983965 ## File path: java/org/apache/catalina/valves/AccessLogValve.java ## @@ -37,6 +37,7 @@ import org.apache.juli.logging.LogFactory;

[GitHub] [tomcat] markt-asf commented on a change in pull request #223: Log compression

2019-12-04 Thread GitBox
markt-asf commented on a change in pull request #223: Log compression URL: https://github.com/apache/tomcat/pull/223#discussion_r353982545 ## File path: java/org/apache/juli/FileHandler.java ## @@ -393,6 +430,9 @@ private void configure() { if (suffix == null) {

[GitHub] [tomcat] markt-asf commented on a change in pull request #223: Log compression

2019-12-04 Thread GitBox
markt-asf commented on a change in pull request #223: Log compression URL: https://github.com/apache/tomcat/pull/223#discussion_r353982236 ## File path: java/org/apache/juli/FileHandler.java ## @@ -216,6 +218,12 @@ public FileHandler(String directory, String prefix,

[GitHub] [tomcat] markt-asf commented on a change in pull request #223: Log compression

2019-12-04 Thread GitBox
markt-asf commented on a change in pull request #223: Log compression URL: https://github.com/apache/tomcat/pull/223#discussion_r353982689 ## File path: java/org/apache/tomcat/util/file/CompressFileUtils.java ## @@ -0,0 +1,50 @@ +package org.apache.tomcat.util.file;

[GitHub] [tomcat] markt-asf commented on issue #222: EmbeddedServletOptions constructor has been refactored

2019-12-04 Thread GitBox
markt-asf commented on issue #222: EmbeddedServletOptions constructor has been refactored URL: https://github.com/apache/tomcat/pull/222#issuecomment-561837082 As per my previous comment, I am closing this PR without applying it.

[GitHub] [tomcat] markt-asf closed pull request #222: EmbeddedServletOptions constructor has been refactored

2019-12-04 Thread GitBox
markt-asf closed pull request #222: EmbeddedServletOptions constructor has been refactored URL: https://github.com/apache/tomcat/pull/222 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] markt-asf closed pull request #215: fixed typos and grammatical errors

2019-12-04 Thread GitBox
markt-asf closed pull request #215: fixed typos and grammatical errors URL: https://github.com/apache/tomcat/pull/215 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] markt-asf commented on issue #215: fixed typos and grammatical errors

2019-12-04 Thread GitBox
markt-asf commented on issue #215: fixed typos and grammatical errors URL: https://github.com/apache/tomcat/pull/215#issuecomment-561834176 Requested changes weren't made. I've fixed the one clear error and back-ported the fix to 8.5.x. and 7.0.x. I haven't made the stylistic changes.

[tomcat] branch 7.0.x updated: Fix error reported via PR #125

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 5ae2eff Fix error reported via PR #125 5ae2eff is

[tomcat] branch 8.5.x updated: Fix error reported via PR #125

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ec68131 Fix error reported via PR #125 ec68131 is

[tomcat] branch master updated: Fix error reported via PR #125

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 0f96b6b Fix error reported via PR #125 0f96b6b

Re: Embedded and default MIME types

2019-12-04 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/4/19 13:23, Mark Thomas wrote: > On 04/12/2019 18:11, Christopher Schultz wrote: >> Mark, >> >> On 12/4/19 13:02, Mark Thomas wrote: >>> Hi all, >> >>> I was looking at this as an off-shoot of looking at BZ 63985. >> >>> Currently,

[Bug 63931] The remote endpoint was in state [TEXT_FULL_WRITING] which is an invalid state

2019-12-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63931 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: Embedded and default MIME types

2019-12-04 Thread Romain Manni-Bucau
+1 to align both, really reduces diff in tests and prod Le mer. 4 déc. 2019 à 19:23, Mark Thomas a écrit : > On 04/12/2019 18:11, Christopher Schultz wrote: > > Mark, > > > > On 12/4/19 13:02, Mark Thomas wrote: > >> Hi all, > > > >> I was looking at this as an off-shoot of looking at BZ 63985.

[tomcat] branch 8.5.x updated: Update changelog

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b767a5b Update changelog b767a5b is described

[tomcat] branch master updated: Update changelog

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1133920 Update changelog 1133920 is described

Re: Embedded and default MIME types

2019-12-04 Thread Mark Thomas
On 04/12/2019 18:11, Christopher Schultz wrote: > Mark, > > On 12/4/19 13:02, Mark Thomas wrote: >> Hi all, > >> I was looking at this as an off-shoot of looking at BZ 63985. > >> Currently, there are 844 MIME mappings in conf/web.xml that are >> not included in Tomcat.DEFAULT_MIME_MAPPINGS.

Re: Embedded and default MIME types

2019-12-04 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 12/4/19 13:02, Mark Thomas wrote: > Hi all, > > I was looking at this as an off-shoot of looking at BZ 63985. > > Currently, there are 844 MIME mappings in conf/web.xml that are > not included in Tomcat.DEFAULT_MIME_MAPPINGS. Fixing it

Embedded and default MIME types

2019-12-04 Thread Mark Thomas
Hi all, I was looking at this as an off-shoot of looking at BZ 63985. Currently, there are 844 MIME mappings in conf/web.xml that are not included in Tomcat.DEFAULT_MIME_MAPPINGS. Fixing it isn't too hard. The 844 figure comes from a unit test I could easily tweak to generate the code needed to

[Bug 63985] Tomcat 9 does not read UTF-8 files with no bom correctly

2019-12-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63985 Mark Thomas changed: What|Removed |Added OS||All Status|NEW

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Mark Thomas
On 04/12/2019 14:20, Rémy Maucherat wrote: > On Wed, Dec 4, 2019 at 12:44 PM Rémy Maucherat > wrote: > > On Wed, Dec 4, 2019 at 11:51 AM Mark Thomas > wrote: > > On 04/12/2019 10:25, Rémy Maucherat wrote: > > On Wed, Dec

buildbot success in on tomcat-trunk

2019-12-04 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4794 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] branch master updated: Fix javadoc

2019-12-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8f8a3e9 Fix javadoc 8f8a3e9 is described below

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Rémy Maucherat
On Wed, Dec 4, 2019 at 12:44 PM Rémy Maucherat wrote: > On Wed, Dec 4, 2019 at 11:51 AM Mark Thomas wrote: > >> On 04/12/2019 10:25, Rémy Maucherat wrote: >> > On Wed, Dec 4, 2019 at 11:11 AM Mark Thomas > > > wrote: >> > >> > On 04/12/2019 09:58, Mark Thomas

[tomcat] 01/02: Call completion handler directly on timeout

2019-12-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit dee4413449fc2070a220cd66a2f0d05c7c81cd43 Author: remm AuthorDate: Wed Dec 4 14:42:34 2019 +0100 Call completion

[tomcat] 02/02: Fix merge

2019-12-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 17c3094a45bab53b2267d8ed137c6c3750c7fc6c Author: remm AuthorDate: Wed Dec 4 15:00:59 2019 +0100 Fix merge ---

[tomcat] branch 8.5.x updated (1a12467 -> 17c3094)

2019-12-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 1a12467 Fix a couple of very unlikely concurrency issues writing WebSocket msgs new dee4413 Call completion

[tomcat] branch master updated: Call completion handler directly on timeout

2019-12-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e9630b6 Call completion handler directly on

[tomcat] branch 7.0.x updated: Fix a very unlikely concurrency issue writing WebSocket msgs

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new aba28fc Fix a very unlikely concurrency issue

[tomcat] branch 8.5.x updated: Fix a couple of very unlikely concurrency issues writing WebSocket msgs

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 1a12467 Fix a couple of very unlikely concurrency

[tomcat] branch master updated: Fix a couple of very unlikely concurrency issues writing WebSocket msgs

2019-12-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 582cc72 Fix a couple of very unlikely

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Rémy Maucherat
On Wed, Dec 4, 2019 at 11:51 AM Mark Thomas wrote: > On 04/12/2019 10:25, Rémy Maucherat wrote: > > On Wed, Dec 4, 2019 at 11:11 AM Mark Thomas > > wrote: > > > > On 04/12/2019 09:58, Mark Thomas wrote: > > > On 04/12/2019 09:27, Mark Thomas wrote: > > >>

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Mark Thomas
On 04/12/2019 10:25, Rémy Maucherat wrote: > On Wed, Dec 4, 2019 at 11:11 AM Mark Thomas > wrote: > > On 04/12/2019 09:58, Mark Thomas wrote: > > On 04/12/2019 09:27, Mark Thomas wrote: > >> On 04/12/2019 07:55, Rémy Maucherat wrote: > > > > >

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Rémy Maucherat
On Wed, Dec 4, 2019 at 11:11 AM Mark Thomas wrote: > On 04/12/2019 09:58, Mark Thomas wrote: > > On 04/12/2019 09:27, Mark Thomas wrote: > >> On 04/12/2019 07:55, Rémy Maucherat wrote: > > > > > > > >>> Blocking is also used for HTTP/2 where it seems to work. If the write > >>> buffer is full,

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Mark Thomas
On 04/12/2019 09:58, Mark Thomas wrote: > On 04/12/2019 09:27, Mark Thomas wrote: >> On 04/12/2019 07:55, Rémy Maucherat wrote: > > > >>> Blocking is also used for HTTP/2 where it seems to work. If the write >>> buffer is full, 0 bytes are written and the socket is indeed passed to >>> the

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Rémy Maucherat
On Wed, Dec 4, 2019 at 10:59 AM Mark Thomas wrote: > On 04/12/2019 09:27, Mark Thomas wrote: > > On 04/12/2019 07:55, Rémy Maucherat wrote: > > > > >> Blocking is also used for HTTP/2 where it seems to work. If the write > >> buffer is full, 0 bytes are written and the socket is indeed passed

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Mark Thomas
On 04/12/2019 09:27, Mark Thomas wrote: > On 04/12/2019 07:55, Rémy Maucherat wrote: >> Blocking is also used for HTTP/2 where it seems to work. If the write >> buffer is full, 0 bytes are written and the socket is indeed passed to >> the poller but until the operation is complete it is

Re: Blocking IO does not appear to always be blocking with asyncIO

2019-12-04 Thread Mark Thomas
On 04/12/2019 07:55, Rémy Maucherat wrote: > On Tue, Dec 3, 2019 at 10:56 PM Mark Thomas > wrote: > > Hi, > > I've been looking into BZ 63931. The error messages I was expecting to > see were not there. > > The first odd thing I noticed was an NPE here:

[tomcat] branch 8.5.x updated: NIO needs a write loop as demonstrated by BZ63949

2019-12-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new bcee3c4 NIO needs a write loop as demonstrated by

[tomcat] branch master updated: NIO needs a write loop as demonstrated by BZ63949

2019-12-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 0f729cf NIO needs a write loop as demonstrated