buildbot success in on tomcat-trunk

2021-01-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5637 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] branch 8.5.x updated: Avoid possible infinite loop in unwrap

2021-01-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 7aab38f Avoid possible infinite loop in unwrap

[tomcat] branch 9.0.x updated: Avoid possible infinite loop in unwrap

2021-01-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 95ceaf7 Avoid possible infinite loop in unwrap

[tomcat] branch master updated: Avoid possible infinite loop in unwrap

2021-01-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5ee9947 Avoid possible infinite loop in unwrap

[Bug 64771] Windows CPU processor always running by a thread reading request body from https connection

2021-01-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64771 --- Comment #11 from Mark Thomas --- The reproducer provided in the Spring issue uses Tomcat 9.0.41 and that has the available() fixes. Bug 65001 might be a factor and that is a post 9.0.41 fix but since I can't reproduce the issue, I can't

Re: [PATCH] AbstractAccessLogValve: Add pre/post add log element extension points

2021-01-21 Thread Romain Manni-Bucau
Hmm, makes me think about two comments: 1. Looks like a custom formatter not matching inline syntax of abstract logging valve so maybe extract the parser/element factory in a class reusable by multiple implementations. 2. Your pre and post are specific to json but dont enable native json since

Re: [PATCH] AbstractAccessLogValve: Add pre/post add log element extension points

2021-01-21 Thread Thomas Meyer
On Thu, Jan 21, 2021 at 03:28:12PM +0100, Romain Manni-Bucau wrote: > Hi Hi, > Why cant it be added as element earlier at pattern parsing time? Would > avoid to have two particular cases and keep current pattern/impl. > A %java or so sounds more natural no? Mhh, maybe I just share my idea of

Re: [PATCH] AbstractAccessLogValve: Add pre/post add log element extension points

2021-01-21 Thread Romain Manni-Bucau
Hi Why cant it be added as element earlier at pattern parsing time? Would avoid to have two particular cases and keep current pattern/impl. A %java or so sounds more natural no? Le jeu. 21 janv. 2021 à 13:59, Thomas Meyer a écrit : > a sub class can extend before and after the addElement loop

Re: [tomcat] branch 7.0.x updated: File separator, not path separator

2021-01-21 Thread Mark Thomas
On 21/01/2021 14:17, Christopher Schultz wrote: > Mark, > > On 1/21/21 09:15, Mark Thomas wrote: >> On 21/01/2021 13:51, Christopher Schultz wrote: >>> Mark, >>> >>> On 1/20/21 11:58, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt

Re: [tomcat] branch 7.0.x updated: File separator, not path separator

2021-01-21 Thread Christopher Schultz
Mark, On 1/21/21 09:15, Mark Thomas wrote: On 21/01/2021 13:51, Christopher Schultz wrote: Mark, On 1/20/21 11:58, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository

Re: [tomcat] branch 7.0.x updated: File separator, not path separator

2021-01-21 Thread Mark Thomas
On 21/01/2021 13:51, Christopher Schultz wrote: > Mark, > > On 1/20/21 11:58, ma...@apache.org wrote: >> This is an automated email from the ASF dual-hosted git repository. >> >> markt pushed a commit to branch 7.0.x >> in repository https://gitbox.apache.org/repos/asf/tomcat.git >> >> >> The

Re: [tomcat] branch 7.0.x updated: File separator, not path separator

2021-01-21 Thread Christopher Schultz
Mark, On 1/20/21 11:58, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push:

Re: [tomcat] branch 9.0.x updated: Use java.nio.file.Path for consistent sub-directory checking

2021-01-21 Thread Christopher Schultz
Mark, On 1/20/21 08:56, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push:

[PATCH] AbstractAccessLogValve: Add pre/post add log element extension points

2021-01-21 Thread Thomas Meyer
a sub class can extend before and after the addElement loop to establish a context via thread-dependend CharArrayWriter object. --- java/org/apache/catalina/valves/AbstractAccessLogValve.java | 5 + 1 file changed, 5 insertions(+) diff --git

buildbot failure in on tomcat-trunk

2021-01-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5636 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 9.0.x updated: Graal 21.0 now supports serialization

2021-01-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 69c2453 Graal 21.0 now supports serialization

[tomcat] branch master updated: Graal 21.0 now supports serialization

2021-01-21 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 721e6e1 Graal 21.0 now supports serialization

[Bug 64771] Windows CPU processor always running by a thread reading request body from https connection

2021-01-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64771 --- Comment #10 from Remy Maucherat --- (In reply to Mark Thomas from comment #9) > RE-opening this issue while I look at the test case... The use of non container threads doing ??? seems to be the root cause of the problems here. Also the

[Bug 64771] Windows CPU processor always running by a thread reading request body from https connection

2021-01-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64771 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME