Re: BUILDING.txt

2022-08-18 Thread Han Li
> 2022年8月19日 00:18,Christopher Schultz 写道: > > Han, > > On 8/17/22 22:35, Han Li wrote: >> I found that BUILDING.txt in the source distribution of all version hasn’t >> been merged as expected. >> I think this is a source distribution, BUILDING.txt is part of the source, >> so it’s normal fo

[GitHub] [tomcat] ppkarwasz commented on pull request #544: Avoid errors from shutting down `LoggerThread`

2022-08-18 Thread GitBox
ppkarwasz commented on PR #544: URL: https://github.com/apache/tomcat/pull/544#issuecomment-1220013953 @markt-asf, As far as I can see, the `LoggerThread` is the only part of JULI that needs to be concerned with `Throwable`s. I inline the relevant part of `ExceptionUtils#handleExcept

[tomcat] branch 8.5.x updated: Make parsing of Content-Disposition headers more robust

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9595fcdecb Make parsing of Content-Disposition head

[tomcat] branch 10.0.x updated: Make parsing of Content-Disposition headers more robust

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new cf3b9fd545 Make parsing of Content-Disposition he

[tomcat] branch 9.0.x updated: Make parsing of Content-Disposition headers more robust

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f775e1c482 Make parsing of Content-Disposition head

[tomcat] branch main updated: Make parsing of Content-Disposition headers more robust

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 1902252416 Make parsing of Content-Disposition header

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Emmanuel Bourg
On 18/08/2022 10:51, Konstantin Kolinko wrote: Have you considered migrating from Bugzilla to GitHub Issues? I am -1. 1. It is better to stay with a solution owned by ASF as much as possible. Same feeling here, I like how GitHub ties the code hosting and the issue tracker, but I think it

[tomcat] branch 8.5.x updated: Improve handling of stack overflow errors when parsing SSI expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4d207d165e Improve handling of stack overflow error

[tomcat] branch 9.0.x updated: Improve handling of stack overflow errors when parsing SSI expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 43dc48bde7 Improve handling of stack overflow error

[tomcat] branch main updated: Improve handling of stack overflow errors when parsing SSI expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 2bce102b0a Improve handling of stack overflow errors

[tomcat] branch 10.0.x updated: Improve handling of stack overflow errors when parsing SSI expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 912ed70f75 Improve handling of stack overflow err

[tomcat] branch 8.5.x updated: Improve handling of stack overflow errors when parsing EL expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 482edcffcc Improve handling of stack overflow error

[tomcat] branch 9.0.x updated: Improve handling of stack overflow errors when parsing EL expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new fae52996e1 Improve handling of stack overflow error

[tomcat] branch 10.0.x updated: Improve handling of stack overflow errors when parsing EL expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new b61eab57db Improve handling of stack overflow err

[tomcat] branch main updated: Improve handling of stack overflow errors when parsing EL expressions.

2022-08-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 05c2829fb9 Improve handling of stack overflow errors

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Christopher Schultz
All, On 8/18/22 08:30, Mark Thomas wrote: On 18/08/2022 13:21, Graham Leggett wrote: On 18 Aug 2022, at 06:57, Vladimir Sitnikov wrote: Have you considered migrating from Bugzilla to GitHub Issues? I think co-locating issues, code, and PRs at GitHub would make it easier to browse both

Re: BUILDING.txt

2022-08-18 Thread Christopher Schultz
Han, On 8/17/22 22:35, Han Li wrote: I found that BUILDING.txt in the source distribution of all version hasn’t been merged as expected. I think this is a source distribution, BUILDING.txt is part of the source, so it’s normal for this file not to be processed. Well, I know that if I had dow

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Vladimir Sitnikov
>GitLab is certainly there and is well-known, >and anyone can create their own. It is not that hard. For reference, it would be hard to integrate Gitlab with ASF infra. >The result is that they are scattered all over my GMail Inbox Great. Thank you for the suggestion. I knew something was wrong

[GitHub] [tomcat] markt-asf commented on pull request #544: Avoid errors from shutting down `LoggerThread`

2022-08-18 Thread GitBox
markt-asf commented on PR #544: URL: https://github.com/apache/tomcat/pull/544#issuecomment-1219639781 No need for a BZ issue. This looks like it needs some variation of ExceptionUtils.handleThrowable(). JULI may need its own copy of the utility. -- This is an automated message from th

[GitHub] [tomcat] ppkarwasz opened a new pull request, #544: Avoid errors from shutting down `LoggerThread`

2022-08-18 Thread GitBox
ppkarwasz opened a new pull request, #544: URL: https://github.com/apache/tomcat/pull/544 A Java `Error` in the `LoggerThread` can effectively cripple Tomcat JULI, preventing all `AsyncFileHandler` from writing to their files. We experienced such a logging shutdown on a real Gerrit in

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #8 from John Engebretson --- Sure - looking at the specific code in https://github.com/FastFilter/xorfilter/blob/master/xorfilter.go vs https://github.com/apache/tomcat/blob/9.0.x/java/org/apache/catalina/webresources/JarContents.ja

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Konstantin Kolinko
чт, 18 авг. 2022 г. в 15:13, Vladimir Sitnikov : > > > 1. It is better to stay with a solution owned by ASF as much as possible. > > For political reasons such as independence. > > AFAIK, the ASF is incorporated in the USA, so the organization must > follow the USA laws. > Are you sure the ASF prov

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #7 from Vladimir Sitnikov --- > It appears to me that Xor has lower memory usage but increases the cost of a > lookup Would you please clarify why you expect Xor filters to have a slower lookup? See https://arxiv.org/pdf/1912.082

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #6 from John Engebretson --- (In reply to Vladimir Sitnikov from comment #5) > As the set of entries in Jar is known in advance, and the entries are not > modified, Xor Filter might be better. > > See > http://web.stanford.edu/cla

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #5 from Vladimir Sitnikov --- As the set of entries in Jar is known in advance, and the entries are not modified, Xor Filter might be better. See http://web.stanford.edu/class/archive/cs/cs166/cs166.1216/lectures/13/Slides13.pdf#p

[Bug 66209] CPU regression when classpath Bloom filters are active

2022-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 --- Comment #4 from John Engebretson --- > I think it makes sense to re-name/alias the current setting to something > more clear such as "archiveIndexing" with values like "simple", "bloom" and > now "purged-bloom" or whatever. I like this sug

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Mark Thomas
On 18/08/2022 13:21, Graham Leggett wrote: On 18 Aug 2022, at 06:57, Vladimir Sitnikov wrote: Have you considered migrating from Bugzilla to GitHub Issues? I think co-locating issues, code, and PRs at GitHub would make it easier to browse both issues and code. -1. GitHub as a service is

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Graham Leggett
On 18 Aug 2022, at 06:57, Vladimir Sitnikov wrote: > Have you considered migrating from Bugzilla to GitHub Issues? > > I think co-locating issues, code, and PRs at GitHub would make it easier to > browse both issues and code. -1. GitHub as a service is hosted by someone else, who are in no way

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Vladimir Sitnikov
> 1. It is better to stay with a solution owned by ASF as much as possible. > For political reasons such as independence. AFAIK, the ASF is incorporated in the USA, so the organization must follow the USA laws. Are you sure the ASF provides "political independence"? > GitHub is not the only git h

[Bug 66178] Reduce garbage from strings in AbstractArchiveResourceSet.getResource

2022-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66178 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #13 from Mark Thoma

[GitHub] [tomcat-jakartaee-migration] nissan4x4 commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
nissan4x4 commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219283706 Thank you very much Han. That worked perfectly. From: Han Li ***@***.***> Sent: Thursday, 18 August 2022 7:17 PM To: apache/tomcat-jak

[GitHub] [tomcat-jakartaee-migration] aooohan commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
aooohan commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219238170 > but my OS is windows not Unix. Sorry, I was careless. [jakartaee-migration-1.0.2-SNAPSHOT-bin.zip](https://github.com/apache/tomcat-jakartaee-migration/fi

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Han Li
> 2022年8月18日 16:51,Konstantin Kolinko 写道: > > чт, 18 авг. 2022 г. в 07:57, Vladimir Sitnikov : >> >> Hi, >> >> >> Have you considered migrating from Bugzilla to GitHub Issues? >> > > I am -1. > > 1. It is better to stay with a solution owned by ASF as much as possible. +1 Han > > For

[GitHub] [tomcat-jakartaee-migration] nissan4x4 commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
nissan4x4 commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219219413 Hi Han, Thanks for that, but my OS is windows not Unix. From: Han Li ***@***.***> Sent: Thursday, 18 August 2022 6:03 PM To: apache/tomc

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Konstantin Kolinko
чт, 18 авг. 2022 г. в 07:57, Vladimir Sitnikov : > > Hi, > > > Have you considered migrating from Bugzilla to GitHub Issues? > I am -1. 1. It is better to stay with a solution owned by ASF as much as possible. For political reasons such as independence. As well as for redundancy etc. GitHub is

[GitHub] [tomcat-jakartaee-migration] aooohan commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
aooohan commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219162105 Hi, @nissan4x4 [jakartaee-migration-1.0.2-SNAPSHOT-bin.tar.gz](https://github.com/apache/tomcat-jakartaee-migration/files/9371552/jakartaee-migration-1.0.2-SNAPSHO

[GitHub] [tomcat-jakartaee-migration] nissan4x4 commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
nissan4x4 commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219144189 Hi, @aooohan. I am experiencing the same issue as @gregorkistler with the CRC. ``` 18-Aug-2022 14:55:06.339 WARNING [Catalina-utility-1] org.apache.catalina.