[Bug 66613] Developing wiki page: Unclear reference to "service wrapper" in Debugging

2023-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66613 --- Comment #1 from Han Li --- (In reply to Philippe Cloutier from comment #0) > > If you run Tomcat using service wrapper, add the above JVM options before > > any other JVM options. Check the documentation for the service wrapper to > >

[Bug 66609] invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609 --- Comment #4 from webmascon --- created pull request: https://github.com/apache/tomcat/pull/621 -- You are receiving this mail because: You are the assignee for the bug. -

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195738 ## test/org/apache/catalina/servlets/TestDefaultServlet.java: ## @@ -578,6 +578,44 @@ public void testBug57601() throws Exception { tomcat.stop(); }

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195493 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1650,7 +1654,7 @@ protected InputStream renderXml(HttpServletRequest request, String contextPath,

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192773 ## java/org/apache/catalina/util/URLEncoder.java: ## @@ -95,6 +96,8 @@ public final class URLEncoder implements Cloneable { QUERY.addSafeCharacter('_');

[GitHub] [tomcat] alexkachanov commented on a diff in pull request #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov commented on code in PR #621: URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192504 ## java/org/apache/catalina/util/URLEncoder.java: ## @@ -40,6 +40,7 @@ public final class URLEncoder implements Cloneable { public static final URLEncoder

[GitHub] [tomcat] alexkachanov opened a new pull request, #621: Bug 66609 - invalid XML in directory listing with file names containing "&" and "'"

2023-05-23 Thread via GitHub
alexkachanov opened a new pull request, #621: URL: https://github.com/apache/tomcat/pull/621 * fix and junit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[Bug 66613] New: Developing wiki page: Unclear reference to "service wrapper" in Debugging

2023-05-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66613 Bug ID: 66613 Summary: Developing wiki page: Unclear reference to "service wrapper" in Debugging Product: Tomcat 10 Version: unspecified Hardware: All

Re: [tomcat] branch main updated: Clear SocketWrapper reference to help GC

2023-05-23 Thread Christopher Schultz
Han, On 5/20/23 21:42, Han Li wrote: On May 21, 2023, at 01:19, Mark Thomas wrote: On 19/05/2023 04:24, li...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository

Panama support in Tomcat 11 (take 2)

2023-05-23 Thread Rémy Maucherat
Hi, Taking into account the feedback I got, here is the plan for using Panama in Tomcat: - No official support for Panama preview APIs (from 17 or 21). For these two, I will leave the sources in "modules". Users should be able to build the support fairly easily. - Once Panama is non preview (this

Buildbot failure in on tomcat-8.5.x

2023-05-23 Thread buildbot
Build status: BUILD FAILED: failed Snapshot deployed to ASF Maven snapshot repository (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/36/builds/497 Blamelist: Mark Thomas Build Text: failed Snapshot deployed to ASF Maven snapshot repository (failure) Status

RFC 9113 (HTTP/2) and HTTP upgrade to h2c

2023-05-23 Thread Mark Thomas
Hi all, The latest HTTP/2 RFC (9113, June 2022) deprecates the use of HTTP upgrade to start an HTTP/2 clear text connection. Interestingly, a range of vocabulary is used. Section 3.1 says it is "deprecated". Section 11.2 says it is "obsolete" and that "This capability has been removed.".

[tomcat] branch 8.5.x updated (46d81a2019 -> cc8eb4e1ef)

2023-05-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 46d81a2019 Additional false positives new 55c8468456 Code clean-up. Formatting. No functional change. new

[tomcat] 02/02: Align with 9.0.x and 10.1.x

2023-05-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cc8eb4e1ef4846e6d970f493aa196b87df8d1290 Author: Mark Thomas AuthorDate: Tue May 23 11:39:03 2023 +0100 Align with

[tomcat] 01/02: Code clean-up. Formatting. No functional change.

2023-05-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 55c8468456ff228dab91cb021365826acdc57373 Author: Mark Thomas AuthorDate: Tue May 23 11:23:54 2023 +0100 Code

[tomcat] branch 9.0.x updated: Code clean-up. Formatting. No functional change.

2023-05-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5f7a833a77 Code clean-up. Formatting. No

[tomcat] branch 10.1.x updated: Code clean-up. Formatting. No functional change.

2023-05-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new d63d73730e Code clean-up. Formatting. No

[tomcat] branch main updated: Code clean-up. Formatting. No functional change.

2023-05-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 63461b3bed Code clean-up. Formatting. No functional

svn commit: r1910013 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2023-05-23 Thread markt
Author: markt Date: Tue May 23 07:09:45 2023 New Revision: 1910013 URL: http://svn.apache.org/viewvc?rev=1910013=rev Log: Fix typo Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: