Re: Which release artifact should we expect to be reproducible?

2023-10-13 Thread Christopher Schultz
Emmanuel, On 10/12/23 18:13, Emmanuel Bourg wrote: Le 12/10/2023 à 23:27, Christopher Schultz a écrit : I installed the ZIP version of Temurin Java 21 to match your release toolchain and I get every file being different. But the versions are not exactly the same, so that may be the reason:

[Bug 67732] APR Deprecation Note in 10.1 doc is missing

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67732 --- Comment #2 from Marcelo Marques --- Thanks, appreciated the information. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762134403 > > I'm a -0 on loading the password from native code. I would support "consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in libtcnative if we wanted to go for

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
rmaucher commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762132365 > I'm a -0 on loading the password from native code. I would support "consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in libtcnative if we wanted to go for that.

[Bug 67732] APR Deprecation Note in 10.1 doc is missing

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67732 Christopher Schultz changed: What|Removed |Added Status|NEW |RESOLVED OS|

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762123047 > I'm a -0 on loading the password from native code. I would support "consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in libtcnative if we wanted to go for

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
ChristopherSchultz commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1762120662 I'm a -0 on loading the password from native code. I would support "consistency" by _removing_ the existing BIO-loading of the cert, key, etc. in libtcnative if we wanted to go

[Bug 67732] New: APR Deprecation Note in 10.1 doc is missing

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67732 Bug ID: 67732 Summary: APR Deprecation Note in 10.1 doc is missing Product: Tomcat Native Version: 2.0.6 Hardware: PC Status: NEW Severity: normal Priority:

[Bug 67722] Tomcat 10 Http11AprProtocol Protocol handler instantiation failed

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67722 --- Comment #3 from Marcelo Marques --- Thanks for the information. I noticed that the note about APR deprecations was added to the 10.0.x doc https://tomcat.apache.org/tomcat-10.0-doc/config/http.html But it is missing from the 10.1.x doc

Re: [VOTE] Release Apache Tomcat 8.5.95 [CORRECTED]

2023-10-13 Thread Cesar Hernandez
+1 thank you! El jue, 12 oct 2023 a las 10:05, Christopher Schultz (< ch...@christopherschultz.net>) escribió: > All, > > On 10/11/23 21:32, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.95 release is now available for voting. > > > > The notable changes compared to 8.5.94 are: >

[PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-13 Thread via GitHub
michael-o opened a new pull request, #21: URL: https://github.com/apache/tomcat-native/pull/21 This patch has been recently removed because it does not apply to the latest version. Bring back an updated patch because Tomcat Native 1.2.x still supports 1.1.1 for those who need it on

[Bug 67731] Remove win-ipv6.patch

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67731 Michael Osipov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 67731] Remove win-ipv6.patch

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67731 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 67731] New: Remove win-ipv6.patch

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67731 Bug ID: 67731 Summary: Remove win-ipv6.patch Product: Tomcat Native Version: 2.0.6 Hardware: All OS: All Status: NEW Severity: enhancement

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on code in PR #672: URL: https://github.com/apache/tomcat/pull/672#discussion_r1358038098 ## java/org/apache/tomcat/util/net/SSLHostConfig.java: ## @@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws FileNotFoundExceptio

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
rmaucher commented on code in PR #672: URL: https://github.com/apache/tomcat/pull/672#discussion_r1358035893 ## java/org/apache/tomcat/util/net/SSLHostConfig.java: ## @@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws FileNotFoundExceptio

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on code in PR #672: URL: https://github.com/apache/tomcat/pull/672#discussion_r1358027078 ## java/org/apache/tomcat/util/net/SSLHostConfig.java: ## @@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws FileNotFoundExceptio

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on code in PR #672: URL: https://github.com/apache/tomcat/pull/672#discussion_r1358027078 ## java/org/apache/tomcat/util/net/SSLHostConfig.java: ## @@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws FileNotFoundExceptio

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
rmaucher commented on code in PR #672: URL: https://github.com/apache/tomcat/pull/672#discussion_r1358020057 ## java/org/apache/tomcat/util/net/SSLHostConfig.java: ## @@ -796,9 +796,6 @@ public static String adjustRelativePath(String path) throws FileNotFoundExceptio

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761201586 > For certificate (key) file, there's an attempt to always use PEMFile. When that fails, it uses the code path where it simply passes the file name, since that's what the native API has

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
rmaucher commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761197570 For certificate (key) file, there's an attempt to always use PEMFile. When that fails, it uses the code path where it simply passes the file name, since that's what the native API has had

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761175235 > Ok trying again. So the code addition in tomcat-native simply uses a file BIO to load the contents of the file and use it as a password. So overall, I do not understand the benefit of

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
rmaucher commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761170846 Ok trying again. So the code addition in tomcat-native simply uses a file BIO to load the contents of the file and use it as a password. So overall, I do not understand the benefit of the

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761153823 > I don't get it overall. Since that's what ultimately happens (the tomcat-native patch simply does that), I think the content of the files should simply be loaded as the password in the

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
rmaucher commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1761136665 I don't get it overall. Since that's what ultimately happens (the tomcat-native patch simply does that), I think the content of the files should simply be loaded as the password in the

Buildbot failure in on tomcat-9.0.x

2023-10-13 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/732 Blamelist: remm Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] 93d70e339b378d2c2aeeb4ae1ad5324731b31c33

Re: [PR] Fix NioChannel's toString() throwing NullPointerException in some cases [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on PR #671: URL: https://github.com/apache/tomcat/pull/671#issuecomment-1761094466 > The benefit seems null IMO, in the debugger it will print out that this is null instead of a NPE, which should mean the same for a developer. Also, Nio2Channel.toString is the same.

[PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-13 Thread via GitHub
michael-o opened a new pull request, #672: URL: https://github.com/apache/tomcat/pull/672 NOTE: Disregard the `[TEMPORARY]` commits, they are for testing purposes only and will *not* be merged. Test matrix: * OpenSSL: 1.1.1, 3.0 * Tomcat Native: 1.2, 2.0 * OS: Windows,

[PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostCon… [tomcat-native]

2023-10-13 Thread via GitHub
michael-o opened a new pull request, #20: URL: https://github.com/apache/tomcat-native/pull/20 …fig#certificateKeystorePasswordFile This has been done on purpose because Tomcat is not the only consumer of this library and this should be available consistently to everyone out there.

Re: [PR] Fix NioChannel's toString() throwing NullPointerException in some cases [tomcat]

2023-10-13 Thread via GitHub
rmaucher commented on PR #671: URL: https://github.com/apache/tomcat/pull/671#issuecomment-1761084688 The benefit seems null IMO, in the debugger it will print out that this is null instead of a NPE, which should mean the same for a developer. Also, Nio2Channel.toString is the same. --

Re: [PR] Fix NioChannel's toString() throwing NullPointerException in some cases [tomcat]

2023-10-13 Thread via GitHub
michael-o commented on PR #671: URL: https://github.com/apache/tomcat/pull/671#issuecomment-1761073554 @markt-asf Are we good to merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tomcat] branch 9.0.x updated: Add release date for 9.0.82

2023-10-13 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 93d70e339b Add release date for 9.0.82 93d70e339b

[ANN] Apache Tomcat 9.0.82 available

2023-10-13 Thread Rémy Maucherat
The Apache Tomcat team announces the immediate availability of Apache Tomcat 9.0.82. Apache Tomcat 9 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language, Java WebSocket and JASPIC technologies. Apache Tomcat 9.0.82 is a bugfix and

svn commit: r1912930 - in /tomcat/site/trunk/docs/tomcat-9.0-doc: ./ annotationapi/ annotationapi/javax/annotation/ annotationapi/javax/annotation/security/ annotationapi/javax/annotation/sql/ api/ ap

2023-10-13 Thread remm
Author: remm Date: Fri Oct 13 07:35:21 2023 New Revision: 1912930 URL: http://svn.apache.org/viewvc?rev=1912930=rev Log: Docs update for 9.0.82 [This commit notification would consist of 68 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.]

svn commit: r1912929 - in /tomcat/site/trunk: ./ docs/ xdocs/

2023-10-13 Thread remm
Author: remm Date: Fri Oct 13 07:29:28 2023 New Revision: 1912929 URL: http://svn.apache.org/viewvc?rev=1912929=rev Log: Update website for 9.0.82 Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/docs/download-90.html

[Bug 67722] Tomcat 10 Http11AprProtocol Protocol handler instantiation failed

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67722 --- Comment #2 from Michael Osipov --- (In reply to Remy Maucherat from comment #1) > In the logs, the first error is: > 12-Oct-2023 14:42:21.043 SEVERE [main] > org.apache.catalina.connector.Connector. Protocol handler > instantiation failed

svn commit: r64510 - /dev/tomcat/tomcat-9/v9.0.82/ /release/tomcat/tomcat-9/v9.0.82/

2023-10-13 Thread remm
Author: remm Date: Fri Oct 13 06:48:15 2023 New Revision: 64510 Log: Release Apache Tomcat 9.0.82 Added: release/tomcat/tomcat-9/v9.0.82/ - copied from r64509, dev/tomcat/tomcat-9/v9.0.82/ Removed: dev/tomcat/tomcat-9/v9.0.82/

[VOTE][RESULT] Release Apache Tomcat 9.0.82

2023-10-13 Thread Rémy Maucherat
The following votes were cast: Binding: +1: isapir, fschumacher, remm, csutherl, markt, lihan, schultz Non-binding: +1: Cesar Hernandez No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. Rémy

[Bug 67722] Tomcat 10 Http11AprProtocol Protocol handler instantiation failed

2023-10-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67722 Remy Maucherat changed: What|Removed |Added Resolution|--- |INVALID Status|NEW